)]}'
{"devstack/lib/persister.sh":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d91c40a6ec3c871318f4b7c5540ebea2fb88ba33","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" DEFAULT log_config_append ${MONASCA_PERSISTER_LOGGING_CONF}"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka uri $SERVICE_HOST:9092"},{"line_number":141,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka consumer_id 1"},{"line_number":142,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafa client_id 1"},{"line_number":143,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka database_batch_size 1000"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_8645a145","line":140,"updated":"2017-07-27 04:54:30.000000000","message":"This setting is redundant now + it is now even specified in kafka_common.py","commit_id":"6776f5b6cf15eb4b125caabd0916900e70041dee"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"04e26be4436779a0233caa6bcd3c120d3f8023d4","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka uri $SERVICE_HOST:9092"},{"line_number":141,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka consumer_id 1"},{"line_number":142,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafa client_id 1"},{"line_number":143,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka database_batch_size 1000"},{"line_number":144,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka max_wait_time_secobds 30"},{"line_number":145,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka fetch_size_bytes 4096"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_6b4e0898","line":142,"updated":"2017-07-27 04:45:13.000000000","message":"Yes, please ;-). Please fix the typo ;-)","commit_id":"6776f5b6cf15eb4b125caabd0916900e70041dee"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d91c40a6ec3c871318f4b7c5540ebea2fb88ba33","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka uri $SERVICE_HOST:9092"},{"line_number":141,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka consumer_id 1"},{"line_number":142,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafa client_id 1"},{"line_number":143,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka database_batch_size 1000"},{"line_number":144,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka max_wait_time_secobds 30"},{"line_number":145,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka fetch_size_bytes 4096"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_e63d8dc4","line":142,"range":{"start_line":142,"start_character":52,"end_line":142,"end_character":53},"updated":"2017-07-27 04:54:30.000000000","message":"also, I think that we can set something meaningful under client_id and consumer_id. Maybe\n\n   persister_$SERVICE_HOST \n\n?","commit_id":"6776f5b6cf15eb4b125caabd0916900e70041dee"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"1b2f65d6295ebc292e12312b7ed052bcf6235c1e","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka uri $SERVICE_HOST:9092"},{"line_number":141,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka consumer_id 1"},{"line_number":142,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafa client_id 1"},{"line_number":143,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka database_batch_size 1000"},{"line_number":144,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka max_wait_time_secobds 30"},{"line_number":145,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka fetch_size_bytes 4096"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_c67cc920","line":142,"range":{"start_line":142,"start_character":52,"end_line":142,"end_character":53},"in_reply_to":"ff346bd7_e63d8dc4","updated":"2017-07-27 05:09:13.000000000","message":"Looking at this differently, we might just remove that as long as we apply the comments from monasca-persister change.","commit_id":"6776f5b6cf15eb4b125caabd0916900e70041dee"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d91c40a6ec3c871318f4b7c5540ebea2fb88ba33","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" kafka_alarm_history topic alarm-state-transitions"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" zookeeper uri $SERVICE_HOST:2181"},{"line_number":158,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" zookeeper partition_interval_recheck_seconds 15"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    if [[ \"${MONASCA_METRICS_DB,,}\" \u003d\u003d \u0027influxdb\u0027 ]]; then"},{"line_number":161,"context_line":"        iniset \"$MONASCA_PERSISTER_CONF\" influxdb database_name mon"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_c66849ba","line":158,"updated":"2017-07-27 04:54:30.000000000","message":"In overall, for all the settings that do have some default settings, please remove entries from here. If those values are as they were inside persister.conf stored together with the plugin, might be good idea to place them as default inside monasca-persister change.","commit_id":"6776f5b6cf15eb4b125caabd0916900e70041dee"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d91c40a6ec3c871318f4b7c5540ebea2fb88ba33","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    if [[ \"${MONASCA_METRICS_DB,,}\" \u003d\u003d \u0027influxdb\u0027 ]]; then"},{"line_number":161,"context_line":"        iniset \"$MONASCA_PERSISTER_CONF\" influxdb database_name mon"},{"line_number":162,"context_line":"        iniset \"$MONASCA_PERSISTER_CONF\" influxdb ip_address ${SERVICE_HOST}"},{"line_number":163,"context_line":"        iniset \"$MONASCA_PERSISTER_CONF\" influxdb port 8086"},{"line_number":164,"context_line":"        iniset \"$MONASCA_PERSISTER_CONF\" influxdb password password"},{"line_number":165,"context_line":"        iniset \"$MONASCA_PERSISTER_CONF\" repositories metrics_driver ${M_REPO_DRIVER_INFLUX}"},{"line_number":166,"context_line":"        iniset \"$MONASCA_PERSISTER_CONF\" repositories alarm_state_history_driver ${AH_REPO_DRIVER_INFLUX}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_865ec10f","line":163,"updated":"2017-07-27 04:54:30.000000000","message":"Port should be default value inside monasca-persister change thus here this line should be removed.","commit_id":"6776f5b6cf15eb4b125caabd0916900e70041dee"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"f6320f5dea926950125f7761c1bc38856674678a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"configure_monasca_persister_python() {"},{"line_number":126,"context_line":"    # ensure fresh installation of configuration files"},{"line_number":127,"context_line":"    rm -rf ${MONASCA_PERSISTER_CONF} ${MONASCA_PERSISTER_LOGGING_CONF}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    $MONASCA_PERSISTER_BIN_DIR/oslo-config-generator \\"},{"line_number":132,"context_line":"            --config-file $MONASCA_PERSISTER_DIR/config-generator/persister.conf \\"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ff346bd7_8e24655f","line":129,"range":{"start_line":128,"start_character":0,"end_line":129,"end_character":0},"updated":"2017-07-28 11:24:48.000000000","message":"Too many empty lines.","commit_id":"5f0f0945f9da3a300de47914937f3ff348fd6660"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"f48294594517c7ae32b25c61d889109ebe0dc8e7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"configure_monasca_persister_python() {"},{"line_number":126,"context_line":"    # ensure fresh installation of configuration files"},{"line_number":127,"context_line":"    rm -rf ${MONASCA_PERSISTER_CONF} ${MONASCA_PERSISTER_LOGGING_CONF}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    $MONASCA_PERSISTER_BIN_DIR/oslo-config-generator \\"},{"line_number":132,"context_line":"            --config-file $MONASCA_PERSISTER_DIR/config-generator/persister.conf \\"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ff346bd7_2ea699ac","line":129,"range":{"start_line":128,"start_character":0,"end_line":129,"end_character":0},"in_reply_to":"ff346bd7_8e24655f","updated":"2017-07-28 11:29:51.000000000","message":"Done","commit_id":"5f0f0945f9da3a300de47914937f3ff348fd6660"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"f6320f5dea926950125f7761c1bc38856674678a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            --config-file $MONASCA_PERSISTER_DIR/config-generator/persister.conf \\"},{"line_number":133,"context_line":"            --output-file /tmp/persister.conf"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    install -m 600 /tmp/persister.conf ${MONASCA_PERSISTER_CONF}"},{"line_number":136,"context_line":"    install -m 600 ${MONASCA_PERSISTER_DIR}/etc/monasca/persister-logging.conf ${MONASCA_PERSISTER_LOGGING_CONF}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    install -m 600 /tmp/persister.conf ${MONASCA_PERSISTER_CONF} \u0026\u0026 rm -rf /tmp/persister.con"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ff346bd7_4e1afd16","line":135,"range":{"start_line":135,"start_character":4,"end_line":135,"end_character":64},"updated":"2017-07-28 11:24:48.000000000","message":"Same line as in 138","commit_id":"5f0f0945f9da3a300de47914937f3ff348fd6660"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"f48294594517c7ae32b25c61d889109ebe0dc8e7","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            --config-file $MONASCA_PERSISTER_DIR/config-generator/persister.conf \\"},{"line_number":133,"context_line":"            --output-file /tmp/persister.conf"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    install -m 600 /tmp/persister.conf ${MONASCA_PERSISTER_CONF}"},{"line_number":136,"context_line":"    install -m 600 ${MONASCA_PERSISTER_DIR}/etc/monasca/persister-logging.conf ${MONASCA_PERSISTER_LOGGING_CONF}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    install -m 600 /tmp/persister.conf ${MONASCA_PERSISTER_CONF} \u0026\u0026 rm -rf /tmp/persister.con"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ff346bd7_4eab1d74","line":135,"range":{"start_line":135,"start_character":4,"end_line":135,"end_character":64},"in_reply_to":"ff346bd7_4e1afd16","updated":"2017-07-28 11:29:51.000000000","message":"Done","commit_id":"5f0f0945f9da3a300de47914937f3ff348fd6660"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"f6320f5dea926950125f7761c1bc38856674678a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    install -m 600 /tmp/persister.conf ${MONASCA_PERSISTER_CONF}"},{"line_number":136,"context_line":"    install -m 600 ${MONASCA_PERSISTER_DIR}/etc/monasca/persister-logging.conf ${MONASCA_PERSISTER_LOGGING_CONF}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    install -m 600 /tmp/persister.conf ${MONASCA_PERSISTER_CONF} \u0026\u0026 rm -rf /tmp/persister.con"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" DEFAULT log_config_append ${MONASCA_PERSISTER_LOGGING_CONF}"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ff346bd7_2e1579e5","line":138,"updated":"2017-07-28 11:24:48.000000000","message":"f","commit_id":"5f0f0945f9da3a300de47914937f3ff348fd6660"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"f48294594517c7ae32b25c61d889109ebe0dc8e7","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    install -m 600 /tmp/persister.conf ${MONASCA_PERSISTER_CONF}"},{"line_number":136,"context_line":"    install -m 600 ${MONASCA_PERSISTER_DIR}/etc/monasca/persister-logging.conf ${MONASCA_PERSISTER_LOGGING_CONF}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    install -m 600 /tmp/persister.conf ${MONASCA_PERSISTER_CONF} \u0026\u0026 rm -rf /tmp/persister.con"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    iniset \"$MONASCA_PERSISTER_CONF\" DEFAULT log_config_append ${MONASCA_PERSISTER_LOGGING_CONF}"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ff346bd7_6ea02191","line":138,"in_reply_to":"ff346bd7_2e1579e5","updated":"2017-07-28 11:29:51.000000000","message":"Done","commit_id":"5f0f0945f9da3a300de47914937f3ff348fd6660"}]}