)]}'
{"config-generator/README.rst":[{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"eead06f05a78efef94946467359aa19ced7772a3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"config-generator"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"To generate sample configuration execute::"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  tox -e genconfig"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9f436f4f_1fb6948b","line":5,"updated":"2017-08-14 10:56:31.000000000","message":"configuration file","commit_id":"601fbc6cde55671dfb8f1c0a8c38c9b104f87200"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"1ede96a3312b578248e217073ff015beb5a415cc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"config-generator"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"To generate sample configuration execute::"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  tox -e genconfig"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9f436f4f_6934c093","line":5,"in_reply_to":"9f436f4f_1fb6948b","updated":"2017-08-14 20:01:42.000000000","message":"Done","commit_id":"601fbc6cde55671dfb8f1c0a8c38c9b104f87200"}],"devstack/plugin.sh":[{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"bde17d9ce35e86b455fe6c6be222c5cdfb8fbc0f","unresolved":false,"context_lines":[{"line_number":794,"context_line":"        $MONASCA_API_BIN_DIR/oslo-config-generator \\"},{"line_number":795,"context_line":"            --config-file $MONASCA_API_DIR/config-generator/api.conf \\"},{"line_number":796,"context_line":"            --output-file /tmp/api.conf"},{"line_number":797,"context_line":"        install -m 600 /tmp/api.conf $MONASCA_API_CONF"},{"line_number":798,"context_line":"        install -m 600 $MONASCA_API_DIR/etc/api-logging.conf $MONASCA_API_LOGGING_CONF"},{"line_number":799,"context_line":"        install -m 600 $MONASCA_API_DIR/etc/api-config.ini $MONASCA_API_PASTE_INI"},{"line_number":800,"context_line":"        # create configuration files in target locations"}],"source_content_type":"text/x-sh","patch_set":9,"id":"bf3e73b7_5f94a244","line":797,"range":{"start_line":797,"start_character":8,"end_line":797,"end_character":54},"updated":"2017-08-07 08:57:20.000000000","message":"I think template(tmp/api.conf) file should be deleted, like in persister.","commit_id":"8921088f044b9345a5cadc884e1bd98484714ac0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ff76d02cbbeda99b2e690e599506770e9b61e08c","unresolved":false,"context_lines":[{"line_number":794,"context_line":"        $MONASCA_API_BIN_DIR/oslo-config-generator \\"},{"line_number":795,"context_line":"            --config-file $MONASCA_API_DIR/config-generator/api.conf \\"},{"line_number":796,"context_line":"            --output-file /tmp/api.conf"},{"line_number":797,"context_line":"        install -m 600 /tmp/api.conf $MONASCA_API_CONF"},{"line_number":798,"context_line":"        install -m 600 $MONASCA_API_DIR/etc/api-logging.conf $MONASCA_API_LOGGING_CONF"},{"line_number":799,"context_line":"        install -m 600 $MONASCA_API_DIR/etc/api-config.ini $MONASCA_API_PASTE_INI"},{"line_number":800,"context_line":"        # create configuration files in target locations"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9f436f4f_033b7ed1","line":797,"range":{"start_line":797,"start_character":8,"end_line":797,"end_character":54},"in_reply_to":"bf3e73b7_5f94a244","updated":"2017-08-08 04:34:36.000000000","message":"Done","commit_id":"8921088f044b9345a5cadc884e1bd98484714ac0"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        sudo chmod 0775 /var/log/monasca/api"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        # create configuration files in target locations"},{"line_number":793,"context_line":"        rm -rf $MONASCA_API_CONF $MONASCA_API_PASTE_INI $MONASCA_API_LOGGING_CONF"},{"line_number":794,"context_line":"        $MONASCA_API_BIN_DIR/oslo-config-generator \\"},{"line_number":795,"context_line":"            --config-file $MONASCA_API_DIR/config-generator/api.conf \\"}],"source_content_type":"text/x-sh","patch_set":18,"id":"9f436f4f_5fb10e8f","line":792,"range":{"start_line":792,"start_character":7,"end_line":792,"end_character":56},"updated":"2017-08-21 11:54:24.000000000","message":"This change is unrelated to the rest of the patch.","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":798,"context_line":"        install -m 600 /tmp/api.conf $MONASCA_API_CONF \u0026\u0026 rm -rf /tmp/api.conf"},{"line_number":799,"context_line":"        install -m 600 $MONASCA_API_DIR/etc/api-logging.conf $MONASCA_API_LOGGING_CONF"},{"line_number":800,"context_line":"        install -m 600 $MONASCA_API_DIR/etc/api-config.ini $MONASCA_API_PASTE_INI"},{"line_number":801,"context_line":"        # create configuration files in target locations"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        local dbAlarmUrl"},{"line_number":804,"context_line":"        local dbMetricDriver"}],"source_content_type":"text/x-sh","patch_set":18,"id":"9f436f4f_5f5fce40","line":801,"range":{"start_line":801,"start_character":8,"end_line":801,"end_character":56},"updated":"2017-08-21 11:54:24.000000000","message":"this appears to be misplaced. should be above the code block","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c56d705245253612b90381acebd8fc0413bf129f","unresolved":false,"context_lines":[{"line_number":798,"context_line":"        install -m 600 /tmp/api.conf $MONASCA_API_CONF \u0026\u0026 rm -rf /tmp/api.conf"},{"line_number":799,"context_line":"        install -m 600 $MONASCA_API_DIR/etc/api-logging.conf $MONASCA_API_LOGGING_CONF"},{"line_number":800,"context_line":"        install -m 600 $MONASCA_API_DIR/etc/api-config.ini $MONASCA_API_PASTE_INI"},{"line_number":801,"context_line":"        # create configuration files in target locations"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        local dbAlarmUrl"},{"line_number":804,"context_line":"        local dbMetricDriver"}],"source_content_type":"text/x-sh","patch_set":18,"id":"9f436f4f_b1edc1b8","line":801,"range":{"start_line":801,"start_character":8,"end_line":801,"end_character":56},"in_reply_to":"9f436f4f_5f5fce40","updated":"2017-08-21 21:14:06.000000000","message":"well, actually the code that is responsible for putting the configuration files inside the target locations as well as creating some of them (api-config.conf) can be found between these comments. What happens after is merely setting proper values.","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        iniset \"$MONASCA_API_CONF\" influxdb ip_address $SERVICE_HOST"},{"line_number":828,"context_line":"        iniset \"$MONASCA_API_CONF\" influxdb port 8086"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        # keystone \u0026 security"},{"line_number":831,"context_line":"        configure_auth_token_middleware $MONASCA_API_CONF \"admin\" $MONASCA_API_CACHE_DIR"},{"line_number":832,"context_line":"        iniset \"$MONASCA_API_CONF\" keystone_authtoken region_name $REGION_NAME"},{"line_number":833,"context_line":"        iniset \"$MONASCA_API_CONF\" keystone_authtoken project_name \"admin\""}],"source_content_type":"text/x-sh","patch_set":18,"id":"9f436f4f_9f6c1609","line":830,"range":{"start_line":830,"start_character":8,"end_line":830,"end_character":29},"updated":"2017-08-21 11:54:24.000000000","message":"this is unrelated","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c56d705245253612b90381acebd8fc0413bf129f","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        iniset \"$MONASCA_API_CONF\" influxdb ip_address $SERVICE_HOST"},{"line_number":828,"context_line":"        iniset \"$MONASCA_API_CONF\" influxdb port 8086"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        # keystone \u0026 security"},{"line_number":831,"context_line":"        configure_auth_token_middleware $MONASCA_API_CONF \"admin\" $MONASCA_API_CACHE_DIR"},{"line_number":832,"context_line":"        iniset \"$MONASCA_API_CONF\" keystone_authtoken region_name $REGION_NAME"},{"line_number":833,"context_line":"        iniset \"$MONASCA_API_CONF\" keystone_authtoken project_name \"admin\""}],"source_content_type":"text/x-sh","patch_set":18,"id":"9f436f4f_113ecd28","line":830,"range":{"start_line":830,"start_character":8,"end_line":830,"end_character":29},"in_reply_to":"9f436f4f_9f6c1609","updated":"2017-08-21 21:14:06.000000000","message":"maybe, but there\u0027s a lot of settings being done here so I decided to organize those sections just a bit.","commit_id":"0781009d389edf52b06855eff85e9122697c457d"}],"doc/source/configuration/sample.rst":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":28,"context_line":"This sample configuration can also be viewed in `api-logging.conf"},{"line_number":29,"context_line":"\u003c../../../etc/api-logging.conf\u003e`_."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":".. literalinclude:: ../../../etc/api-logging.conf"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Sample Configuration For Paster"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f436f4f_5af8fcc2","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":49},"updated":"2017-08-21 11:54:24.000000000","message":"If the path begins with \"/\", the path is relative to the top-level dir instead of relative to the current file\u0027s path.\n\nhttp://www.sphinx-doc.org/en/stable/markup/code.html#includes","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c56d705245253612b90381acebd8fc0413bf129f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"This sample configuration can also be viewed in `api-logging.conf"},{"line_number":29,"context_line":"\u003c../../../etc/api-logging.conf\u003e`_."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":".. literalinclude:: ../../../etc/api-logging.conf"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Sample Configuration For Paster"}],"source_content_type":"text/x-rst","patch_set":18,"id":"9f436f4f_510d758e","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":49},"in_reply_to":"9f436f4f_5af8fcc2","updated":"2017-08-21 21:14:06.000000000","message":"hmmm...I can check that, I took that file pretty much raw from other projects at they were following up that approach.","commit_id":"0781009d389edf52b06855eff85e9122697c457d"}],"monasca_api/common/repositories/cassandra/metrics_repository.py":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            self.conf \u003d cfg.CONF"},{"line_number":41,"context_line":"            self._cassandra_cluster \u003d Cluster("},{"line_number":42,"context_line":"                self.conf.cassandra.cluster_ip_addresses"},{"line_number":43,"context_line":"            )"},{"line_number":44,"context_line":"            self.cassandra_session \u003d self._cassandra_cluster.connect("},{"line_number":45,"context_line":"                self.conf.cassandra.keyspace"},{"line_number":46,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_9a830405","line":43,"range":{"start_line":42,"start_character":12,"end_line":43,"end_character":13},"updated":"2017-08-21 11:54:24.000000000","message":"Perhaps this behaviour should be updated separately, as you\u0027re introducing the config generator AND changing the presentation/consumption of a config option in the same change.","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c56d705245253612b90381acebd8fc0413bf129f","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            self.conf \u003d cfg.CONF"},{"line_number":41,"context_line":"            self._cassandra_cluster \u003d Cluster("},{"line_number":42,"context_line":"                self.conf.cassandra.cluster_ip_addresses"},{"line_number":43,"context_line":"            )"},{"line_number":44,"context_line":"            self.cassandra_session \u003d self._cassandra_cluster.connect("},{"line_number":45,"context_line":"                self.conf.cassandra.keyspace"},{"line_number":46,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_f1d469bd","line":43,"range":{"start_line":42,"start_character":12,"end_line":43,"end_character":13},"in_reply_to":"9f436f4f_9a830405","updated":"2017-08-21 21:14:06.000000000","message":"Hmm...well, yes and no - basically monasca-api suffered a bit, as far as I remember, from the fact that options that were meant to be IP adresses or port numbers were represented, respectively, as strings and integers. Seemed only fitting to wrap up those minor changes for certain variables within that change.\n\nI can change it back, but it won\u0027t be much of reversing. If you still feel like that this necessary I can surely do that.","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                self.conf.cassandra.cluster_ip_addresses"},{"line_number":43,"context_line":"            )"},{"line_number":44,"context_line":"            self.cassandra_session \u003d self._cassandra_cluster.connect("},{"line_number":45,"context_line":"                self.conf.cassandra.keyspace"},{"line_number":46,"context_line":"            )"},{"line_number":47,"context_line":"        except Exception as ex:"},{"line_number":48,"context_line":"            LOG.exception(ex)"},{"line_number":49,"context_line":"            raise exceptions.RepositoryException(ex)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_3acad86d","line":46,"range":{"start_line":45,"start_character":12,"end_line":46,"end_character":13},"updated":"2017-08-21 11:54:24.000000000","message":"unrelated change","commit_id":"0781009d389edf52b06855eff85e9122697c457d"}],"monasca_api/conf/__init__.py":[{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"dc2cb2c4514b001d4b1a00eaa6a21f0d131fa281","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def load_conf_modules():"},{"line_number":28,"context_line":"    \"\"\"Loads all modules that contain configuration"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Method iterates over modules of :py:module:`monasca_api.conf`"},{"line_number":31,"context_line":"    and imports only those that contain following methods:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf3e73b7_fdc59e5c","line":28,"updated":"2017-08-07 11:17:03.000000000","message":"missing dot","commit_id":"8921088f044b9345a5cadc884e1bd98484714ac0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ff76d02cbbeda99b2e690e599506770e9b61e08c","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def load_conf_modules():"},{"line_number":28,"context_line":"    \"\"\"Loads all modules that contain configuration"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Method iterates over modules of :py:module:`monasca_api.conf`"},{"line_number":31,"context_line":"    and imports only those that contain following methods:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f436f4f_63512a0f","line":28,"in_reply_to":"bf3e73b7_fdc59e5c","updated":"2017-08-08 04:34:36.000000000","message":"Done","commit_id":"8921088f044b9345a5cadc884e1bd98484714ac0"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"dc2cb2c4514b001d4b1a00eaa6a21f0d131fa281","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def register_opts():"},{"line_number":53,"context_line":"    \"\"\"Registers all conf modules opts"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    This method allows different modules to register"},{"line_number":56,"context_line":"    opts according to their needs."}],"source_content_type":"text/x-python","patch_set":9,"id":"bf3e73b7_7daf6e94","line":53,"updated":"2017-08-07 11:17:03.000000000","message":"the same as above","commit_id":"8921088f044b9345a5cadc884e1bd98484714ac0"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ff76d02cbbeda99b2e690e599506770e9b61e08c","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def register_opts():"},{"line_number":53,"context_line":"    \"\"\"Registers all conf modules opts"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    This method allows different modules to register"},{"line_number":56,"context_line":"    opts according to their needs."}],"source_content_type":"text/x-python","patch_set":9,"id":"9f436f4f_834c0e77","line":53,"in_reply_to":"bf3e73b7_7daf6e94","updated":"2017-08-08 04:34:36.000000000","message":"Done","commit_id":"8921088f044b9345a5cadc884e1bd98484714ac0"}],"monasca_api/conf/cassandra.py":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":22,"context_line":"                default\u003d[\u0027127.0.0.1\u0027],"},{"line_number":23,"context_line":"                item_type\u003dtypes.HostAddress(),"},{"line_number":24,"context_line":"                help\u003d\u0027\u0027\u0027"},{"line_number":25,"context_line":"Comma separated list of Cassandra node IP addresses"},{"line_number":26,"context_line":"\u0027\u0027\u0027),"},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027keyspace\u0027, default\u003d\u0027monasca\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027\u0027\u0027"},{"line_number":29,"context_line":"keyspace where metric are stored\u0027\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_ba080891","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":4},"updated":"2017-08-21 11:54:24.000000000","message":"Questionable indentation choice. It should be inline with the rest of the parameters, if I\u0027m not mistaken.","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u0027\u0027\u0027),"},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027keyspace\u0027, default\u003d\u0027monasca\u0027,"},{"line_number":28,"context_line":"               help\u003d\u0027\u0027\u0027"},{"line_number":29,"context_line":"keyspace where metric are stored\u0027\u0027\u0027)"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"cassandra_group \u003d cfg.OptGroup(name\u003d\u0027cassandra\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_3a677854","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":35},"updated":"2017-08-21 11:54:24.000000000","message":"ditto on indentation","commit_id":"0781009d389edf52b06855eff85e9122697c457d"}],"monasca_api/conf/influxdb.py":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":20,"context_line":"influxdb_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027database_name\u0027, default\u003d\u0027mon\u0027,"},{"line_number":22,"context_line":"               help\u003d\u0027\u0027\u0027"},{"line_number":23,"context_line":"Database name where metrics are stored"},{"line_number":24,"context_line":"\u0027\u0027\u0027),"},{"line_number":25,"context_line":"    cfg.HostAddressOpt(\u0027ip_address\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":26,"context_line":"                       help\u003d\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_1a9274f7","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":38},"updated":"2017-08-21 11:54:24.000000000","message":"Same comment as earlier re: indentation of the parameters","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c56d705245253612b90381acebd8fc0413bf129f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"influxdb_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027database_name\u0027, default\u003d\u0027mon\u0027,"},{"line_number":22,"context_line":"               help\u003d\u0027\u0027\u0027"},{"line_number":23,"context_line":"Database name where metrics are stored"},{"line_number":24,"context_line":"\u0027\u0027\u0027),"},{"line_number":25,"context_line":"    cfg.HostAddressOpt(\u0027ip_address\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":26,"context_line":"                       help\u003d\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_9194fde9","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":38},"in_reply_to":"9f436f4f_1a9274f7","updated":"2017-08-21 21:14:06.000000000","message":"Everywhere the reply is the same, they way the string is written here is reflected in generated configuration file. Linebreaks put here are therefore in config file and are increasing a bit it\u0027s readability. Also that this the convention I picked from another OS project, though that is hardly an argument :D","commit_id":"0781009d389edf52b06855eff85e9122697c457d"}],"monasca_api/healthcheck/metrics_db_check.py":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if self._cluster is None:"},{"line_number":88,"context_line":"            return False, \"Cassandra driver not imported\""},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            cassandra \u003d self._cluster.Cluster("},{"line_number":91,"context_line":"                CONF.cassandra.cluster_ip_addresses"},{"line_number":92,"context_line":"            )"},{"line_number":93,"context_line":"            session \u003d cassandra.connect(CONF.cassandra.keyspace)"},{"line_number":94,"context_line":"            session.shutdown()"},{"line_number":95,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f436f4f_35a9cbdc","line":92,"range":{"start_line":90,"start_character":12,"end_line":92,"end_character":13},"updated":"2017-08-21 11:54:24.000000000","message":"again, arguing that this is an unrelated change because it is changing how the config option is presented","commit_id":"0781009d389edf52b06855eff85e9122697c457d"}],"tox.ini":[{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"eead06f05a78efef94946467359aa19ced7772a3","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[testenv:genconfig]"},{"line_number":128,"context_line":"description \u003d Generates sample documentation file for monasca-api"},{"line_number":129,"context_line":"commands \u003d oslo-config-generator --config-file\u003dconfig-generator/api.conf"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"[testenv:venv]"}],"source_content_type":"text/x-properties","patch_set":16,"id":"9f436f4f_fb0be326","line":128,"range":{"start_line":128,"start_character":31,"end_line":128,"end_character":44},"updated":"2017-08-14 10:56:31.000000000","message":"configuration","commit_id":"601fbc6cde55671dfb8f1c0a8c38c9b104f87200"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"1ede96a3312b578248e217073ff015beb5a415cc","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[testenv:genconfig]"},{"line_number":128,"context_line":"description \u003d Generates sample documentation file for monasca-api"},{"line_number":129,"context_line":"commands \u003d oslo-config-generator --config-file\u003dconfig-generator/api.conf"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"[testenv:venv]"}],"source_content_type":"text/x-properties","patch_set":16,"id":"9f436f4f_292a382b","line":128,"range":{"start_line":128,"start_character":31,"end_line":128,"end_character":44},"in_reply_to":"9f436f4f_fb0be326","updated":"2017-08-14 20:01:42.000000000","message":"Done","commit_id":"601fbc6cde55671dfb8f1c0a8c38c9b104f87200"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":98,"context_line":"[testenv:devdocs]"},{"line_number":99,"context_line":"description \u003d Builds developer documentation"},{"line_number":100,"context_line":"commands \u003d"},{"line_number":101,"context_line":"  rm -rf doc/build doc/source/contributor/api"},{"line_number":102,"context_line":"  {[testenv:checkjson]commands}"},{"line_number":103,"context_line":"  python setup.py build_sphinx"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-properties","patch_set":18,"id":"9f436f4f_f5ea23d6","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":45},"updated":"2017-08-21 11:54:24.000000000","message":"This looks like an unrelated change i.e. clean-up in tox job","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c56d705245253612b90381acebd8fc0413bf129f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"[testenv:devdocs]"},{"line_number":99,"context_line":"description \u003d Builds developer documentation"},{"line_number":100,"context_line":"commands \u003d"},{"line_number":101,"context_line":"  rm -rf doc/build doc/source/contributor/api"},{"line_number":102,"context_line":"  {[testenv:checkjson]commands}"},{"line_number":103,"context_line":"  python setup.py build_sphinx"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-properties","patch_set":18,"id":"9f436f4f_7165191d","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":45},"in_reply_to":"9f436f4f_f5ea23d6","updated":"2017-08-21 21:14:06.000000000","message":"Not at all unrelated IMHO, without that each run of the checknicess pick up the built documentation and kick out the validation. I am not for doing a changes for such things if they can be included in existing one. That\u0027s, on other side of the coin, a minor refactor and I do not particularly favor creating changes for such purpose.","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"389ad4ed378027df28920e7e452a640170b4b074","unresolved":false,"context_lines":[{"line_number":107,"context_line":"usedevelop \u003d False"},{"line_number":108,"context_line":"description \u003d Validates (pep-like) documenation"},{"line_number":109,"context_line":"commands \u003d"},{"line_number":110,"context_line":"  rm -rf {toxinidir}/doc/build {toxinidir}/api-ref/build {toxinidir}/releasenotes/build"},{"line_number":111,"context_line":"  doc8 --file-encoding utf-8 {toxinidir}/doc"},{"line_number":112,"context_line":"  doc8 --file-encoding utf-8 {toxinidir}/api-ref"},{"line_number":113,"context_line":"  doc8 --file-encoding utf-8 {toxinidir}/releasenotes"}],"source_content_type":"text/x-properties","patch_set":18,"id":"9f436f4f_75b873e4","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":87},"updated":"2017-08-21 11:54:24.000000000","message":"ditto: unrelated change","commit_id":"0781009d389edf52b06855eff85e9122697c457d"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c56d705245253612b90381acebd8fc0413bf129f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"usedevelop \u003d False"},{"line_number":108,"context_line":"description \u003d Validates (pep-like) documenation"},{"line_number":109,"context_line":"commands \u003d"},{"line_number":110,"context_line":"  rm -rf {toxinidir}/doc/build {toxinidir}/api-ref/build {toxinidir}/releasenotes/build"},{"line_number":111,"context_line":"  doc8 --file-encoding utf-8 {toxinidir}/doc"},{"line_number":112,"context_line":"  doc8 --file-encoding utf-8 {toxinidir}/api-ref"},{"line_number":113,"context_line":"  doc8 --file-encoding utf-8 {toxinidir}/releasenotes"}],"source_content_type":"text/x-properties","patch_set":18,"id":"9f436f4f_9162bd15","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":87},"in_reply_to":"9f436f4f_75b873e4","updated":"2017-08-21 21:14:06.000000000","message":"Same response.","commit_id":"0781009d389edf52b06855eff85e9122697c457d"}]}