)]}'
{"devstack/lib/griddb.sh":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"a0b0fe68dfcc50d64f4f14e3e4cb340ecfed4127","unresolved":false,"context_lines":[{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"function install_monasca_griddb {"},{"line_number":49,"context_line":"    install_monasca_griddb_c_client"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"function clean_monasca_griddb {"}],"source_content_type":"text/x-sh","patch_set":22,"id":"3f4b6375_d53046eb","line":49,"updated":"2017-10-20 07:15:26.000000000","message":"You don\u0027t need yet another method, it will be sufficient to have just one. \n\nStill there\u0027s no condition around the body that would prevent installing it all the time (that is not want we want).\n\nThis is true only if user would like to deploy with grid-db, false otherwise.","commit_id":"97990784bfa25fd300db79a23fe4457674121e0e"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"2c9369c214a01f591b5781cfd49df93ba5ae837e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"function install_monasca_griddb {"},{"line_number":49,"context_line":"    install_monasca_griddb_c_client"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"function clean_monasca_griddb {"}],"source_content_type":"text/x-sh","patch_set":22,"id":"3f4b6375_b0e25c00","line":49,"in_reply_to":"3f4b6375_3470a3dc","updated":"2017-10-21 23:08:56.000000000","message":"yeah well...if you install it here gates for docs and python [py, pep etc] won\u0027t pick it up. That should go to the tox.ini if I understand you correctly.","commit_id":"97990784bfa25fd300db79a23fe4457674121e0e"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"795c33ed3316900aaabe3dad74abd66cab6298bd","unresolved":false,"context_lines":[{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"function install_monasca_griddb {"},{"line_number":49,"context_line":"    install_monasca_griddb_c_client"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"function clean_monasca_griddb {"}],"source_content_type":"text/x-sh","patch_set":22,"id":"3f4b6375_2b7a7687","line":49,"in_reply_to":"3f4b6375_b0e25c00","updated":"2017-10-23 06:37:22.000000000","message":"Oh... I see. I\u0027ll try it.","commit_id":"97990784bfa25fd300db79a23fe4457674121e0e"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"86fa8e03ad78a752130ee261aa72a0da7e15524b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"function install_monasca_griddb {"},{"line_number":49,"context_line":"    install_monasca_griddb_c_client"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"function clean_monasca_griddb {"}],"source_content_type":"text/x-sh","patch_set":22,"id":"3f4b6375_3470a3dc","line":49,"in_reply_to":"3f4b6375_d53046eb","updated":"2017-10-21 14:46:09.000000000","message":"It requires 4 methods to (un)install GridDB server and the client.\n\nWe need install_monasca_griddb() and clean_monasca_griddb() only when griddb is selected as metrics repository, but we alwasys need install_monasca_griddb_c_client() and clean_monasca_griddb_c_client() for running unit tests and document generation.","commit_id":"97990784bfa25fd300db79a23fe4457674121e0e"}],"devstack/plugin.sh":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"361b2da542f92802c50977a9e6d3c97addb6639b","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"    fi"},{"line_number":1340,"context_line":"}"},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"function install_monasca_griddb_c_client {"},{"line_number":1343,"context_line":""},{"line_number":1344,"context_line":"    echo_summary \"Install GridDB C Client library\""},{"line_number":1345,"context_line":""}],"source_content_type":"text/x-sh","patch_set":21,"id":"3f4b6375_6c00b368","line":1342,"updated":"2017-10-20 04:20:15.000000000","message":"If I may suggest, please move that method and one below to dedicated script inside devstack/lib. plugin.sh is cluttered as it is now so best thing is to avoid putting more items to it. \n\nAlso these will result in installing the plugin always while it should be installed only if corresponding GridDB is enabled inside devstack.\n\nIf you need more help on this topic, let me know.","commit_id":"4d6e1b6e17da18bc39d6e612f0ef997fbdd9c24b"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"57af4bb0276f70f99e8c5f5db8b4dd5024a85003","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"    fi"},{"line_number":1340,"context_line":"}"},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"function install_monasca_griddb_c_client {"},{"line_number":1343,"context_line":""},{"line_number":1344,"context_line":"    echo_summary \"Install GridDB C Client library\""},{"line_number":1345,"context_line":""}],"source_content_type":"text/x-sh","patch_set":21,"id":"3f4b6375_6fb8a575","line":1342,"in_reply_to":"3f4b6375_6c00b368","updated":"2017-10-20 05:51:29.000000000","message":"Thanks. I\u0027ve moved functions to devstack/lib/griddb.sh.","commit_id":"4d6e1b6e17da18bc39d6e612f0ef997fbdd9c24b"}],"etc/api-config.conf":[{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"df6f6cda9a07263c336043b41f1d27620b0160e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"log_config_append\u003d/etc/monasca/api-logging.conf"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Identifies the region that the Monasca API is running in."}],"source_content_type":"text/plain","patch_set":11,"id":"7f287b81_f7b2bd48","line":1,"updated":"2017-08-29 11:40:04.000000000","message":"Configuration file is right now generated though config generator.\nChange for this was merged: https://review.openstack.org/#/c/490778/","commit_id":"366c626c71cbc57848122a3b48d0531871f484c6"}],"monasca_api/common/repositories/griddb/metrics_repository.py":[{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"df4ab78fa4c4a20e385bd09472aef60e1a03943a","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @gsexception_handler"},{"line_number":111,"context_line":"    def _get_time_series(self, *args):"},{"line_number":112,"context_line":"        \"\"\"Aquire time series object of GridDB."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param args: tuple for the time series name"},{"line_number":115,"context_line":"        :type args: list(str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_ebf13603","line":112,"range":{"start_line":112,"start_character":11,"end_line":112,"end_character":17},"updated":"2017-08-20 12:26:15.000000000","message":"Acquire","commit_id":"26cf0310ae03484b75a9629effca0909106c714d"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"d2a4ca07ab88ac20814f8536c75c51c198359099","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @gsexception_handler"},{"line_number":111,"context_line":"    def _get_time_series(self, *args):"},{"line_number":112,"context_line":"        \"\"\"Aquire time series object of GridDB."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param args: tuple for the time series name"},{"line_number":115,"context_line":"        :type args: list(str)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_0159f658","line":112,"range":{"start_line":112,"start_character":11,"end_line":112,"end_character":17},"in_reply_to":"9f436f4f_ebf13603","updated":"2017-08-21 06:17:17.000000000","message":"Done","commit_id":"26cf0310ae03484b75a9629effca0909106c714d"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"df4ab78fa4c4a20e385bd09472aef60e1a03943a","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        :return: Alarm history list"},{"line_number":228,"context_line":"        :rtype: list(tuple)"},{"line_number":229,"context_line":"        \"\"\""},{"line_number":230,"context_line":"        # Query alarm hisotry records"},{"line_number":231,"context_line":"        ts \u003d self._get_time_series(ALARM_STATE_HISTORY_PREFIX, tenant_id)"},{"line_number":232,"context_line":"        query_string \u003d \"select *\""},{"line_number":233,"context_line":"        time_cond \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_cbf672fa","line":230,"range":{"start_line":230,"start_character":22,"end_line":230,"end_character":29},"updated":"2017-08-20 12:26:15.000000000","message":"history","commit_id":"26cf0310ae03484b75a9629effca0909106c714d"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"d2a4ca07ab88ac20814f8536c75c51c198359099","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        :return: Alarm history list"},{"line_number":228,"context_line":"        :rtype: list(tuple)"},{"line_number":229,"context_line":"        \"\"\""},{"line_number":230,"context_line":"        # Query alarm hisotry records"},{"line_number":231,"context_line":"        ts \u003d self._get_time_series(ALARM_STATE_HISTORY_PREFIX, tenant_id)"},{"line_number":232,"context_line":"        query_string \u003d \"select *\""},{"line_number":233,"context_line":"        time_cond \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_e1539238","line":230,"range":{"start_line":230,"start_character":22,"end_line":230,"end_character":29},"in_reply_to":"9f436f4f_cbf672fa","updated":"2017-08-21 06:17:17.000000000","message":"Done","commit_id":"26cf0310ae03484b75a9629effca0909106c714d"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f94b8da7467f4ad1c5c92888d084446fcb79570f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from monasca_common.rest.utils import from_json"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from oslo_config import cfg"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_log import log"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_ffa56248","line":28,"updated":"2017-08-21 11:26:28.000000000","message":"Import in general are grouped as in:\n\n1) system imports (internal python libs)\n2) libs from the requirements\n3) internal imports\n\nalso please use full imports and not import specific objects but modules.","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"c797fd37ff0cff2c89fb56ad4ef556686b485310","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from monasca_common.rest.utils import from_json"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from oslo_config import cfg"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_log import log"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_7d996377","line":28,"in_reply_to":"9f436f4f_ffa56248","updated":"2017-08-22 07:27:13.000000000","message":"Done","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"e1166deeef9d903927f75f727383baf49e455528","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        # Filter metrics with dimensions and name"},{"line_number":318,"context_line":"        if dimensions:"},{"line_number":319,"context_line":"            for key, value in dimensions.items():"},{"line_number":320,"context_line":"                if value \u003d\u003d \"\":"},{"line_number":321,"context_line":"                    values \u003d None"},{"line_number":322,"context_line":"                else:"},{"line_number":323,"context_line":"                    values \u003d value.split(\"|\")"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"                new_metrics \u003d []"},{"line_number":326,"context_line":"                for metric_hash, metric_map in metrics:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_556c4f35","line":323,"range":{"start_line":320,"start_character":16,"end_line":323,"end_character":45},"updated":"2017-08-21 12:08:09.000000000","message":"You can write it as:\n   values \u003d value.split(\"|\") if value else None","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"c797fd37ff0cff2c89fb56ad4ef556686b485310","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        # Filter metrics with dimensions and name"},{"line_number":318,"context_line":"        if dimensions:"},{"line_number":319,"context_line":"            for key, value in dimensions.items():"},{"line_number":320,"context_line":"                if value \u003d\u003d \"\":"},{"line_number":321,"context_line":"                    values \u003d None"},{"line_number":322,"context_line":"                else:"},{"line_number":323,"context_line":"                    values \u003d value.split(\"|\")"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"                new_metrics \u003d []"},{"line_number":326,"context_line":"                for metric_hash, metric_map in metrics:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_bdc6ab48","line":323,"range":{"start_line":320,"start_character":16,"end_line":323,"end_character":45},"in_reply_to":"9f436f4f_556c4f35","updated":"2017-08-22 07:27:13.000000000","message":"Done","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"e1166deeef9d903927f75f727383baf49e455528","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        return [{\u0027dimension_name\u0027: _} for _ in dimension_names_list]"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @exception_handler"},{"line_number":414,"context_line":"    def list_dimension_values(self, tenant_id, region, metric_name,"},{"line_number":415,"context_line":"                              dimension_name):"},{"line_number":416,"context_line":"        \"\"\"Get dimension values list."},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        :param tenant_id: Tenant ID"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_1580078b","line":415,"range":{"start_line":414,"start_character":0,"end_line":415,"end_character":46},"updated":"2017-08-21 12:08:09.000000000","message":"wrong brake of the line. Number of arguments should be equal in each line","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"c797fd37ff0cff2c89fb56ad4ef556686b485310","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        return [{\u0027dimension_name\u0027: _} for _ in dimension_names_list]"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    @exception_handler"},{"line_number":414,"context_line":"    def list_dimension_values(self, tenant_id, region, metric_name,"},{"line_number":415,"context_line":"                              dimension_name):"},{"line_number":416,"context_line":"        \"\"\"Get dimension values list."},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        :param tenant_id: Tenant ID"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_5d069f88","line":415,"range":{"start_line":414,"start_character":0,"end_line":415,"end_character":46},"in_reply_to":"9f436f4f_1580078b","updated":"2017-08-22 07:27:13.000000000","message":"Done","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"e1166deeef9d903927f75f727383baf49e455528","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        # Filter measurements with dimensions and metric name"},{"line_number":490,"context_line":"        if dimensions:"},{"line_number":491,"context_line":"            for d_key, d_value in dimensions.items():"},{"line_number":492,"context_line":"                if d_value \u003d\u003d \"\":"},{"line_number":493,"context_line":"                    d_values \u003d None"},{"line_number":494,"context_line":"                else:"},{"line_number":495,"context_line":"                    d_values \u003d d_value.split(\"|\")"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"                new_measurements \u003d []"},{"line_number":498,"context_line":"                for m in measurements:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_b5337b13","line":495,"range":{"start_line":492,"start_character":16,"end_line":495,"end_character":49},"updated":"2017-08-21 12:08:09.000000000","message":"d_values \u003d d_value.split(\"|\") if d_value else None","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"c797fd37ff0cff2c89fb56ad4ef556686b485310","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        # Filter measurements with dimensions and metric name"},{"line_number":490,"context_line":"        if dimensions:"},{"line_number":491,"context_line":"            for d_key, d_value in dimensions.items():"},{"line_number":492,"context_line":"                if d_value \u003d\u003d \"\":"},{"line_number":493,"context_line":"                    d_values \u003d None"},{"line_number":494,"context_line":"                else:"},{"line_number":495,"context_line":"                    d_values \u003d d_value.split(\"|\")"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"                new_measurements \u003d []"},{"line_number":498,"context_line":"                for m in measurements:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_3d099b94","line":495,"range":{"start_line":492,"start_character":16,"end_line":495,"end_character":49},"in_reply_to":"9f436f4f_b5337b13","updated":"2017-08-22 07:27:13.000000000","message":"Done","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"e1166deeef9d903927f75f727383baf49e455528","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        # Filter measurements with dimensions and metric name"},{"line_number":586,"context_line":"        if dimensions:"},{"line_number":587,"context_line":"            for d_key, d_value in dimensions.items():"},{"line_number":588,"context_line":"                if d_value \u003d\u003d \"\":"},{"line_number":589,"context_line":"                    d_values \u003d None"},{"line_number":590,"context_line":"                else:"},{"line_number":591,"context_line":"                    d_values \u003d d_value.split(\"|\")"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"                new_measurements \u003d []"},{"line_number":594,"context_line":"                for m in measurements:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_d93519dd","line":591,"range":{"start_line":588,"start_character":16,"end_line":591,"end_character":49},"updated":"2017-08-21 12:08:09.000000000","message":"The same as above","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"c797fd37ff0cff2c89fb56ad4ef556686b485310","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        # Filter measurements with dimensions and metric name"},{"line_number":586,"context_line":"        if dimensions:"},{"line_number":587,"context_line":"            for d_key, d_value in dimensions.items():"},{"line_number":588,"context_line":"                if d_value \u003d\u003d \"\":"},{"line_number":589,"context_line":"                    d_values \u003d None"},{"line_number":590,"context_line":"                else:"},{"line_number":591,"context_line":"                    d_values \u003d d_value.split(\"|\")"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"                new_measurements \u003d []"},{"line_number":594,"context_line":"                for m in measurements:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_3d7cfbe9","line":591,"range":{"start_line":588,"start_character":16,"end_line":591,"end_character":49},"in_reply_to":"9f436f4f_d93519dd","updated":"2017-08-22 07:27:13.000000000","message":"Done","commit_id":"84f1b68f210d8116c4892d227371f32b52497e77"},{"author":{"_account_id":26733,"name":"Amir Mofakhar","email":"amir@mofakhar.info","username":"amofakhar"},"change_message_id":"471854805ab24e9ccdd1211a6b270eacdb59c1f2","unresolved":false,"context_lines":[{"line_number":56,"context_line":")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def to_hash_str(hash_long):"},{"line_number":60,"context_line":"    \"\"\"Convert an integer in DB into a hex string"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    :param hash_long: 64bit signed integer"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f4b6375_66868a16","line":59,"updated":"2017-10-31 10:02:54.000000000","message":"In my opinion, It is better to name it as \"int_to_hash_str\", the same for other next functions: to_hash_long, from_timestamp_ms, ...\nIt is a more clean code if method name describes its functionality itself!","commit_id":"c36e1919de08c810b29f515342468718d55f7c9a"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"f3b6a356ef81d3f12711b9fa9227897722d4e99a","unresolved":false,"context_lines":[{"line_number":56,"context_line":")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def to_hash_str(hash_long):"},{"line_number":60,"context_line":"    \"\"\"Convert an integer in DB into a hex string"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    :param hash_long: 64bit signed integer"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f4b6375_021c5bbf","line":59,"in_reply_to":"3f4b6375_66868a16","updated":"2017-10-31 14:17:52.000000000","message":"Right. I like \"int2hashstr()\" but your int_to_hash_str() also looks better.\nJust wanted to know, is there any guideline of method and/or class naming in monasca?","commit_id":"c36e1919de08c810b29f515342468718d55f7c9a"}],"monasca_api/healthcheck/metrics_db_check.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"f044a7e38cddb91f42e065985e16da4f005bebc2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        elif self._db \u003d\u003d \u0027cassandra\u0027:"},{"line_number":62,"context_line":"            status \u003d self._check_cassandra_status()"},{"line_number":63,"context_line":"        else:"},{"line_number":64,"context_line":"            status \u003d self._check_griddb_status()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return base.CheckResult(healthy\u003dstatus[0],"},{"line_number":67,"context_line":"                                message\u003dstatus[1])"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f287b81_1a31cca3","line":64,"updated":"2017-08-30 14:27:32.000000000","message":"Seems like _check_status should be made a method in the metrics repo interface and the three implementations below that are specific to each DB moved into their respective repos.","commit_id":"e79b7a1e4920805f455f8c0d6ddacfc94c452876"}]}