)]}'
{"monasca_api/common/repositories/influxdb/metrics_repository.py":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"2040ba060b397a507c0c03bb93e30dce349ac921","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        for name in dim_name_set:"},{"line_number":419,"context_line":"            json_dim_name_list.append({u\u0027dimension_name\u0027: name})"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        json_dim_name_list \u003d sorted(json_dim_name_list, key\u003dlambda x: sorted(x.values()))"},{"line_number":422,"context_line":"        return json_dim_name_list"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def _build_serie_metric_list_to_v0_11_0(self, series_names, tenant_id, region,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_c71fea6d","line":421,"range":{"start_line":421,"start_character":70,"end_line":421,"end_character":76},"updated":"2018-06-25 13:59:32.000000000","message":"nit: There is always only one dict item in each list item. We don\u0027t need another sorting and can reduce to:\n\n  key\u003dlambda x: x.values()","commit_id":"cfc574df50a04573d7dacee8654343168fcb5542"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"3ab784d585969966c47d68cfcb6f5817d747cb2b","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        for name in dim_name_set:"},{"line_number":419,"context_line":"            json_dim_name_list.append({u\u0027dimension_name\u0027: name})"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        json_dim_name_list \u003d sorted(json_dim_name_list, key\u003dlambda x: sorted(x.values()))"},{"line_number":422,"context_line":"        return json_dim_name_list"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def _build_serie_metric_list_to_v0_11_0(self, series_names, tenant_id, region,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_8b9d4abc","line":421,"range":{"start_line":421,"start_character":70,"end_line":421,"end_character":76},"in_reply_to":"5f7c97a3_c71fea6d","updated":"2018-06-27 09:36:08.000000000","message":"Done","commit_id":"cfc574df50a04573d7dacee8654343168fcb5542"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"6ccd379c536db2c0954ce74433b487bcbf9c18d0","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        for name in dim_name_set:"},{"line_number":419,"context_line":"            json_dim_name_list.append({u\u0027dimension_name\u0027: name})"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        json_dim_name_list \u003d sorted(json_dim_name_list, key\u003dlambda x: x.values())"},{"line_number":422,"context_line":"        return json_dim_name_list"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def _build_serie_metric_list_to_v0_11_0(self, series_names, tenant_id, region,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_e1541f56","line":421,"range":{"start_line":421,"start_character":70,"end_line":421,"end_character":80},"updated":"2018-06-27 11:24:57.000000000","message":"Sorry, apparently[1] it doesn\u0027t work, my fault. But this does:\n\n  key\u003dlambda x: x[u\u0027dimension_name\u0027]\n\n[1] http://logs.openstack.org/48/559948/6/check/openstack-tox-py35/8dfe996/job-output.txt.gz#_2018-06-27_10_11_39_271272","commit_id":"24bbfb5458d613972fe9657c370b419d9835227c"}],"monasca_api/tests/test_repositories.py":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"9046df79ff06d8383acfe31ae4c8f59492826319","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            limit\u003d1)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        self.assertEqual([{"},{"line_number":329,"context_line":"            u\u0027id\u0027: b\u002701d39f19798ed27bbf458300bf843edd17654614\u0027,"},{"line_number":330,"context_line":"            u\u0027name\u0027: u\u0027disk.space_used_perc\u0027,"},{"line_number":331,"context_line":"            u\u0027dimensions\u0027: {"},{"line_number":332,"context_line":"                u\u0027device\u0027: u\u0027rootfs\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_8d5c287f","line":329,"updated":"2018-04-18 12:10:13.000000000","message":"The fact that you had to change these unit tests indicates that the behavior of the component changed as well. Please note that:\n\nPython 2: type(b\u0027foo\u0027) -\u003e \u003ctype \u0027str\u0027\u003e\nPython 3: type(b\u0027foo\u0027) -\u003e \u003cclass \u0027bytes\u0027\u003e\n\nPlease check if you can use some of ideas from this change https://review.openstack.org/560302","commit_id":"c11fd0ba4127a26c721b5948060e61e8feed81dc"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"f5c8fd403678c06ca0013add01f095271a49ee0b","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            limit\u003d1)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        self.assertEqual([{"},{"line_number":329,"context_line":"            u\u0027id\u0027: b\u002701d39f19798ed27bbf458300bf843edd17654614\u0027,"},{"line_number":330,"context_line":"            u\u0027name\u0027: u\u0027disk.space_used_perc\u0027,"},{"line_number":331,"context_line":"            u\u0027dimensions\u0027: {"},{"line_number":332,"context_line":"                u\u0027device\u0027: u\u0027rootfs\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_aa86a064","line":329,"in_reply_to":"9f6a8fd7_8d5c287f","updated":"2018-05-22 12:04:36.000000000","message":"Yes, It look like the behavior of the component changed.\n\nI will try to use some idea from this change.","commit_id":"c11fd0ba4127a26c721b5948060e61e8feed81dc"}]}