)]}'
{"devstack/lib/persister.sh":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"875b96b591056a49c7aead44607d9041ea1e527f","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # Set up logging"},{"line_number":166,"context_line":"    if [ \"$SYSLOG\" !\u003d \"False\" ]; then"},{"line_number":167,"context_line":"        iniset $MONASCA_PERSISTER_CONF DEFAULT use_syslog \"True\""},{"line_number":168,"context_line":"    fi"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    # Format logging"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_7f1bca7e","line":167,"updated":"2018-10-04 12:18:53.000000000","message":"Could we offload the parsing of boolean strings to Oslo by removing the if statement and replacing it with```iniset $MONASCA_PERSISTER_CONF DEFAULT use_syslog $SYSLOG```?","commit_id":"8bd78bb185c51fd8243ae9705847c64f61e69843"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"c2b1b7e0da7d268962badea9d4a694c0f97dab88","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # Set up logging"},{"line_number":166,"context_line":"    if [ \"$SYSLOG\" !\u003d \"False\" ]; then"},{"line_number":167,"context_line":"        iniset $MONASCA_PERSISTER_CONF DEFAULT use_syslog \"True\""},{"line_number":168,"context_line":"    fi"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    # Format logging"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_2fc66b4c","line":167,"in_reply_to":"3f79a3b5_7f1bca7e","updated":"2018-10-05 10:03:20.000000000","message":"Good point. Done.","commit_id":"8bd78bb185c51fd8243ae9705847c64f61e69843"}]}
