)]}'
{"monasca_api/config.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3e66d1c087032568f253c784a0404e4284185e51","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    _CONF_LOADED \u003d True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def _get_config_files():"},{"line_number":66,"context_line":"    \"\"\"Get the possible configuration files accepted by oslo.config"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    This also includes the deprecated ones"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_284508b4","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":24},"updated":"2019-01-07 16:43:07.000000000","message":"It looks like the DB migration code also needs updating and this needs reverting to a public method:\n\n`doug@old_cranky:~/git/monasca-api/monasca_api$ grep -rin get_config_file\\(\ncmd/monasca_db.py:160:         default_config_files\u003dmonasca_api.config.get_config_file(None),`","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"2263ae7b01e77145da125a8f3a554188ba3876f7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    _CONF_LOADED \u003d True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def _get_config_files():"},{"line_number":66,"context_line":"    \"\"\"Get the possible configuration files accepted by oslo.config"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    This also includes the deprecated ones"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_fe201afa","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":24},"in_reply_to":"dfd5e7cf_284508b4","updated":"2019-01-07 19:04:28.000000000","message":"Done","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d5f912a94d9b7fd814265d07649d771bc8c4b35c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # deprecated config files"},{"line_number":73,"context_line":"    for prog_name in [\u0027api\u0027, \u0027api-config\u0027]:"},{"line_number":74,"context_line":"        old_conf_files \u003d cfg.find_config_files(project\u003d\u0027monasca\u0027, prog\u003dprog_name)"},{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_19dc1d73","line":75,"range":{"start_line":75,"start_character":15,"end_line":75,"end_character":29},"updated":"2019-01-07 15:09:29.000000000","message":"Can this ever be None?","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"1dfd06316b075af9e35a8417b717f4c51afffd28","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # deprecated config files"},{"line_number":73,"context_line":"    for prog_name in [\u0027api\u0027, \u0027api-config\u0027]:"},{"line_number":74,"context_line":"        old_conf_files \u003d cfg.find_config_files(project\u003d\u0027monasca\u0027, prog\u003dprog_name)"},{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_74b690dc","line":75,"range":{"start_line":75,"start_character":15,"end_line":75,"end_character":29},"in_reply_to":"dfd5e7cf_19dc1d73","updated":"2019-01-07 15:55:46.000000000","message":"No. See https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L278","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3e66d1c087032568f253c784a0404e4284185e51","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # deprecated config files"},{"line_number":73,"context_line":"    for prog_name in [\u0027api\u0027, \u0027api-config\u0027]:"},{"line_number":74,"context_line":"        old_conf_files \u003d cfg.find_config_files(project\u003d\u0027monasca\u0027, prog\u003dprog_name)"},{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_08760408","line":75,"range":{"start_line":75,"start_character":15,"end_line":75,"end_character":29},"in_reply_to":"dfd5e7cf_74b690dc","updated":"2019-01-07 16:43:07.000000000","message":"Thanks for the link.","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d5f912a94d9b7fd814265d07649d771bc8c4b35c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"},{"line_number":79,"context_line":"    return conf_files"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_79820952","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":40},"updated":"2019-01-07 15:09:29.000000000","message":"Should we stick with the original behaviour here and just return the first file?","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"891ce4fcbd7886ce6e70660cd9da5174aeca0a22","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"},{"line_number":79,"context_line":"    return conf_files"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_82940446","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":40},"in_reply_to":"dfd5e7cf_6751f2d8","updated":"2019-01-08 11:18:58.000000000","message":"Re \"not set `project`\": I would prefer to do what other projects do. What\u0027s the problem with having multiple locations?\n\nRe \"deprecation files usage\". Done. deprecated files are now only used if none of the standard files are found.","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3e66d1c087032568f253c784a0404e4284185e51","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"},{"line_number":79,"context_line":"    return conf_files"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_e864e0bb","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":40},"in_reply_to":"dfd5e7cf_74ebf0af","updated":"2019-01-07 16:43:07.000000000","message":"So if I do an upgrade I could have the new config file and the old config file in the same directory. Won\u0027t the new code now find and return all of them? Previously, it only looked for deprecated config files if the standard one wasn\u0027t there.","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"1dfd06316b075af9e35a8417b717f4c51afffd28","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"},{"line_number":79,"context_line":"    return conf_files"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_74ebf0af","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":40},"in_reply_to":"dfd5e7cf_79820952","updated":"2019-01-07 15:55:46.000000000","message":"I think no. The old behavior was wrong because the standard oslo.config file names were not recognized. \nSo I would be in favor of changing this.","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1acfbfd932aa2ca4d9aac8c23da4692aaa49591b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"},{"line_number":79,"context_line":"    return conf_files"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_6751f2d8","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":40},"in_reply_to":"dfd5e7cf_7eb74a88","updated":"2019-01-08 10:22:03.000000000","message":"Regarding the new config file, can we *not* set `project` so that there is only one standard one: `monasca-api.conf`?\n\nRegarding returning multiple files, the Oslo docs suggest that the last file will take precedence [1]. This would mean that the old config file could take precedence over the new one if someone forgot to remove it. Even if that wasn\u0027t the case I still don\u0027t think we should change the old behaviour of only returning the old config file if we don\u0027t find a new one. It makes it harder to review the change, has potential to introduce bugs and doesn\u0027t offer any benefit that I can see.\n\n[1] https://docs.openstack.org/oslo.config/latest/configuration/options.html","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"68606b35c6855a7413b6766be2d97cd21075af02","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"},{"line_number":79,"context_line":"    return conf_files"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_766685f0","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":40},"in_reply_to":"dfd5e7cf_82940446","updated":"2019-01-08 11:51:47.000000000","message":"It\u0027s not a problem as such, it\u0027s more of a nit that we\u0027re announcing that the new config file is called `monasca-api.conf` but we\u0027ve also added undocumented support for `monasca.conf` as well. I\u0027m happy enough now. Thanks for fixing it up.","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"2263ae7b01e77145da125a8f3a554188ba3876f7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        if len(old_conf_files) \u003e 0:"},{"line_number":76,"context_line":"            LOG.warning(\u0027Found deprecated old location \"{}\" \u0027"},{"line_number":77,"context_line":"                        \u0027of main configuration file\u0027.format(old_conf_files))"},{"line_number":78,"context_line":"            conf_files +\u003d old_conf_files"},{"line_number":79,"context_line":"    return conf_files"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_7eb74a88","line":78,"range":{"start_line":78,"start_character":12,"end_line":78,"end_character":40},"in_reply_to":"dfd5e7cf_e864e0bb","updated":"2019-01-07 19:04:28.000000000","message":"The thing with \"the standard one\" is, that oslo.config has a couple of standard files. See https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L293\n\nThe current code would look first for the new paths and then for the deprecated ones. So a config option defined in both places would then the option would be taken from the first (new paths) place. So I think that is fine.","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"}],"releasenotes/notes/use-standard-config-file-path-a4c1a29d9d3fcc07.yaml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"68d2f09beb6f308a28f280fadc6da9d22d0e7a58","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Configuration file path /etc/monasca/api-config.conf and"},{"line_number":5,"context_line":"    /etc/monasca/api.conf are deprecated. Use the standard path"},{"line_number":6,"context_line":"    /etc/monasca/monasca-api.conf or the configuration dir (supported via"},{"line_number":7,"context_line":"    oslo.config) /etc/monaca/monasca-api.conf.d/any_config_name.conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfd5e7cf_471b8e1a","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":28},"updated":"2019-01-08 10:24:11.000000000","message":"nit: s/monaca/monasca","commit_id":"265c6043c517fbf0ce1b57926ec64fc6f85f346c"}]}