)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"7eba6a718b78de4f695afbfdd91f6fe137ead5e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ethan Apodaca \u003ceapodaca@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-03-27 13:25:58 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update /v2/alarms/count api endpoint"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Allow metric_dimensions filter to filter on multiple dimension values:"},{"line_number":10,"context_line":"  metric_dimensions\u003ddns|compute|nova"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5fc1f717_457e77af","line":7,"updated":"2019-03-27 21:12:43.000000000","message":"Per the git commit guidelines, https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure, this message could be improved a bit including:\n- a more meaningful summary message.  Perhaps something like \u0027Filter alarm counts on multiple dimension values\u0027\n- some more context in the detail.  It appears that this is giving an example for usage, and that could be a bit more explicit.  It would be worth mentioning the rationale for the change (parity with the alarm list API, IIUC).","commit_id":"118849cd10ab7c4a3ad1e6ed32478e7f7157efa1"}],"monasca_api/common/repositories/sqla/alarms_repository.py":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"bbd8f37cf453737c3850b796c7bcc54bb655bced","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                sub_query_md_base \u003d select([md.c.dimension_set_id]).select_from(md)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"                for i, metric_dimension in enumerate(query_parms[\u0027metric_dimensions\u0027].items()):"},{"line_number":551,"context_line":"                    metric_value \u003d metric_dimension[1] if six.PY3 else \\"},{"line_number":552,"context_line":"                        metric_dimension[1].encode(\u0027utf8\u0027)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"                    if \u0027|\u0027 in metric_value:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_905f8474","line":551,"range":{"start_line":551,"start_character":20,"end_line":551,"end_character":32},"updated":"2019-04-01 09:31:48.000000000","message":"The name is misleading, should be `dimension_value`.","commit_id":"07d946e9a48c103dc9d0d913218b438d5f49fb43"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"bbd8f37cf453737c3850b796c7bcc54bb655bced","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                sub_query_md_base \u003d select([md.c.dimension_set_id]).select_from(md)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"                for i, metric_dimension in enumerate(query_parms[\u0027metric_dimensions\u0027].items()):"},{"line_number":551,"context_line":"                    metric_value \u003d metric_dimension[1] if six.PY3 else \\"},{"line_number":552,"context_line":"                        metric_dimension[1].encode(\u0027utf8\u0027)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"                    if \u0027|\u0027 in metric_value:"},{"line_number":555,"context_line":"                        metric_value \u003d tuple(metric_value.split(\u0027|\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_10d874ee","line":552,"range":{"start_line":551,"start_character":35,"end_line":552,"end_character":58},"updated":"2019-04-01 09:31:48.000000000","message":"nit: I\u0027d prefer to use `oslo_utils.encodeutils.safe_encode(metric_dimension[1], incoming\u003d\u0027utf-8\u0027)` as recommended here [1].\n\n[1] https://wiki.openstack.org/wiki/Python3#safe_encode","commit_id":"07d946e9a48c103dc9d0d913218b438d5f49fb43"},{"author":{"_account_id":30177,"name":"Ethan Apodaca","email":"eapodaca@suse.com","username":"eapodaca"},"change_message_id":"29c242d8766c6f3f5e8a82aef2ae4277ef1929cf","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                sub_query_md_base \u003d select([md.c.dimension_set_id]).select_from(md)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"                for i, metric_dimension in enumerate(query_parms[\u0027metric_dimensions\u0027].items()):"},{"line_number":551,"context_line":"                    metric_value \u003d metric_dimension[1] if six.PY3 else \\"},{"line_number":552,"context_line":"                        metric_dimension[1].encode(\u0027utf8\u0027)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"                    if \u0027|\u0027 in metric_value:"},{"line_number":555,"context_line":"                        metric_value \u003d tuple(metric_value.split(\u0027|\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_57748dfe","line":552,"range":{"start_line":551,"start_character":35,"end_line":552,"end_character":58},"in_reply_to":"5fc1f717_10d874ee","updated":"2019-04-02 19:43:17.000000000","message":"I am simply following the way that user input text is handled in this function and file. There are lots of places where this is handled this way should all of those be updated with this change?","commit_id":"07d946e9a48c103dc9d0d913218b438d5f49fb43"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"271c55eb490fcc482e98b82031d5cd3cd64e822e","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                sub_query_md_base \u003d select([md.c.dimension_set_id]).select_from(md)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"                for i, metric_dimension in enumerate(query_parms[\u0027metric_dimensions\u0027].items()):"},{"line_number":551,"context_line":"                    metric_value \u003d metric_dimension[1] if six.PY3 else \\"},{"line_number":552,"context_line":"                        metric_dimension[1].encode(\u0027utf8\u0027)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"                    if \u0027|\u0027 in metric_value:"},{"line_number":555,"context_line":"                        metric_value \u003d tuple(metric_value.split(\u0027|\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_3a1e7d74","line":552,"range":{"start_line":551,"start_character":35,"end_line":552,"end_character":58},"in_reply_to":"5fc1f717_57748dfe","updated":"2019-04-03 09:29:08.000000000","message":"You\u0027re right. I guess you can leave it as is.","commit_id":"07d946e9a48c103dc9d0d913218b438d5f49fb43"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"bbd8f37cf453737c3850b796c7bcc54bb655bced","unresolved":false,"context_lines":[{"line_number":576,"context_line":"                                            sub_query_md.c.dimension_set_id \u003d\u003d"},{"line_number":577,"context_line":"                                            mdd.c.metric_dimension_set_id))"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"                    parms[md_name] \u003d metric_dimension[0] if six.PY3 else \\"},{"line_number":580,"context_line":"                        metric_dimension[0].encode(\u0027utf8\u0027)"},{"line_number":581,"context_line":"                    parms[md_value] \u003d metric_value"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"                    sub_query \u003d (sub_query"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_30fed038","line":580,"range":{"start_line":579,"start_character":37,"end_line":580,"end_character":58},"updated":"2019-04-01 09:31:48.000000000","message":"Compare the note above about `oslo_utils`.","commit_id":"07d946e9a48c103dc9d0d913218b438d5f49fb43"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"271c55eb490fcc482e98b82031d5cd3cd64e822e","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                sub_query_md_base \u003d select([md.c.dimension_set_id]).select_from(md)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"                for i, metric_dimension in enumerate(query_parms[\u0027metric_dimensions\u0027].items()):"},{"line_number":551,"context_line":"                    metric_value \u003d metric_dimension[1] if six.PY3 else \\"},{"line_number":552,"context_line":"                        metric_dimension[1].encode(\u0027utf8\u0027)"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"                    if \u0027|\u0027 in metric_value:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_fa2795c6","line":551,"range":{"start_line":551,"start_character":20,"end_line":551,"end_character":32},"updated":"2019-04-03 09:29:08.000000000","message":"Please rename this variable to `dimension_value`.","commit_id":"bb49d1e8f92ab3e34a451e9b7e5c56b418d7a6e5"}],"releasenotes/notes/story-2005311-f746ca6c725335b2.yaml":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"271c55eb490fcc482e98b82031d5cd3cd64e822e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5fc1f717_8e42d20e","updated":"2019-04-03 09:29:08.000000000","message":"Looks good. Please just rename the file to something meaningful like `alarms-count-dimensions-*`.","commit_id":"bb49d1e8f92ab3e34a451e9b7e5c56b418d7a6e5"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"271c55eb490fcc482e98b82031d5cd3cd64e822e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allow metric_dimensions filter to filter on multiple dimension values,"},{"line_number":5,"context_line":"    on alamrs count endpoint (IE metric_dimension\u003dhostname:host1|host2)."},{"line_number":6,"context_line":"    This brings the query paramaters into parity betweent he alarms list"},{"line_number":7,"context_line":"    and alarms count endpoints. This also restores functionality that was"},{"line_number":8,"context_line":"    available on the deprecated java api."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5fc1f717_9a61b114","line":6,"range":{"start_line":6,"start_character":58,"end_line":6,"end_character":60},"updated":"2019-04-03 09:29:08.000000000","message":"please remove","commit_id":"bb49d1e8f92ab3e34a451e9b7e5c56b418d7a6e5"}]}
