)]}'
{"id":"openstack%2Fmonasca-api~658527","triplet_id":"openstack%2Fmonasca-api~master~Ia621e8fc3b05bdc1f0c628057f5dbeedd10c9431","project":"openstack/monasca-api","branch":"master","topic":"alarms-get-404notfount-bug","hashtags":[],"change_id":"Ia621e8fc3b05bdc1f0c628057f5dbeedd10c9431","subject":"Fix alarms get method return 404 not found bug","status":"ABANDONED","created":"2019-05-11 07:33:23.000000000","updated":"2019-10-09 00:07:16.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b77709fc9370968a90df761974c9121a75e69ee1","_number":658527,"virtual_id_number":658527,"owner":{"_account_id":29970,"name":"jianweizhang","email":"zhangjianweibj@inspur.com","username":"zhangjianwei"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},{"date":"2019-05-31 02:54:26.000000000","_account_id":29970,"name":"jianweizhang","email":"zhangjianweibj@inspur.com","username":"zhangjianwei"},{"date":"2019-06-04 09:48:05.000000000","_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},{"value":-1,"date":"2019-05-30 12:27:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29970,"name":"jianweizhang","email":"zhangjianweibj@inspur.com","username":"zhangjianwei"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2019-06-04 13:19:09.000000000","_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":29970,"name":"jianweizhang","email":"zhangjianweibj@inspur.com","username":"zhangjianwei"},{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-06-04 08:49:20.000000000","_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29970,"name":"jianweizhang","email":"zhangjianweibj@inspur.com","username":"zhangjianwei"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-30 12:27:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-04 08:49:20.000000000","updated_by":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"reviewer":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"state":"REVIEWER"},{"updated":"2019-06-04 09:48:05.000000000","updated_by":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"reviewer":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"state":"REVIEWER"},{"updated":"2019-06-04 13:19:09.000000000","updated_by":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"reviewer":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"state":"REVIEWER"}],"messages":[{"id":"10a3c296e1874556a0db7feb4b0bd6c7ddd76da5","author":{"_account_id":29970,"name":"jianweizhang","email":"zhangjianweibj@inspur.com","username":"zhangjianwei"},"date":"2019-05-11 07:33:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"433347776e94f6c2ba66d688375ff436cd8cf9fc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-11 08:21:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/27/658527/1/check/openstack-tox-cover/7f61e3a/ : POST_FAILURE in 3m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/27/658527/1/check/openstack-tox-lower-constraints/b75f2fa/ : SUCCESS in 12m 07s\n- openstack-tox-pep8 http://logs.openstack.org/27/658527/1/check/openstack-tox-pep8/aca6c13/ : SUCCESS in 7m 33s\n- openstack-tox-py27 http://logs.openstack.org/27/658527/1/check/openstack-tox-py27/3699354/ : FAILURE in 7m 28s\n- openstack-tox-py36 http://logs.openstack.org/27/658527/1/check/openstack-tox-py36/56e6018/ : FAILURE in 3m 43s\n- openstack-tox-docs http://logs.openstack.org/27/658527/1/check/openstack-tox-docs/97506f6/html/ : SUCCESS in 4m 38s\n- monasca-tempest-python2-influxdb http://logs.openstack.org/27/658527/1/check/monasca-tempest-python2-influxdb/bedcabf/ : FAILURE in 23m 27s\n- monasca-tempest-python3-influxdb http://logs.openstack.org/27/658527/1/check/monasca-tempest-python3-influxdb/eec924e/ : FAILURE in 35m 23s\n- monasca-tempest-java-influxdb http://logs.openstack.org/27/658527/1/check/monasca-tempest-java-influxdb/5ff84b6/ : FAILURE in 23m 28s (non-voting)\n- monasca-tempest-python2-cassandra http://logs.openstack.org/27/658527/1/check/monasca-tempest-python2-cassandra/7ec141b/ : FAILURE in 39m 52s\n- monasca-tempest-python3-cassandra http://logs.openstack.org/27/658527/1/check/monasca-tempest-python3-cassandra/8ea6add/ : FAILURE in 24m 17s (non-voting)\n- monasca-tempest-python2-java-cassandra http://logs.openstack.org/27/658527/1/check/monasca-tempest-python2-java-cassandra/e0e3e0c/ : FAILURE in 35m 08s\n- monasca-tempest-python3-java-cassandra http://logs.openstack.org/27/658527/1/check/monasca-tempest-python3-java-cassandra/ddc75d2/ : FAILURE in 21m 00s (non-voting)\n- monascalog-python3-tempest http://logs.openstack.org/27/658527/1/check/monascalog-python3-tempest/c1da456/ : FAILURE in 42m 53s\n- build-monasca-docker-image http://logs.openstack.org/27/658527/1/check/build-monasca-docker-image/4e49ae6/ : SUCCESS in 6m 23s","accounts_in_message":[],"_revision_number":1},{"id":"aba0fbd2894c7d425c52dabc91def670fb0ba64e","author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"date":"2019-05-30 11:33:48.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"787041ec2becb69639efc5223b01a2d2c82de8de","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-30 12:27:24.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/27/658527/2/check/openstack-tox-cover/7f02ab1/cover/ : SUCCESS in 5m 51s\n- openstack-tox-lower-constraints http://logs.openstack.org/27/658527/2/check/openstack-tox-lower-constraints/047fdc9/ : SUCCESS in 10m 50s\n- openstack-tox-pep8 http://logs.openstack.org/27/658527/2/check/openstack-tox-pep8/f62ac21/ : SUCCESS in 3m 52s\n- openstack-tox-py27 http://logs.openstack.org/27/658527/2/check/openstack-tox-py27/354b70b/ : SUCCESS in 3m 42s\n- openstack-tox-py36 http://logs.openstack.org/27/658527/2/check/openstack-tox-py36/580e1f0/ : SUCCESS in 3m 51s\n- openstack-tox-docs http://logs.openstack.org/27/658527/2/check/openstack-tox-docs/30700c7/html/ : SUCCESS in 4m 18s\n- monasca-tempest-python2-influxdb http://logs.openstack.org/27/658527/2/check/monasca-tempest-python2-influxdb/d816c7a/ : FAILURE in 38m 48s\n- monasca-tempest-python3-influxdb http://logs.openstack.org/27/658527/2/check/monasca-tempest-python3-influxdb/3fa981b/ : FAILURE in 43m 24s\n- monasca-tempest-java-influxdb http://logs.openstack.org/27/658527/2/check/monasca-tempest-java-influxdb/88485dc/ : FAILURE in 46m 23s (non-voting)\n- monasca-tempest-python2-cassandra http://logs.openstack.org/27/658527/2/check/monasca-tempest-python2-cassandra/ff1695d/ : FAILURE in 37m 58s\n- monasca-tempest-python3-cassandra http://logs.openstack.org/27/658527/2/check/monasca-tempest-python3-cassandra/eb228aa/ : FAILURE in 19m 37s (non-voting)\n- monasca-tempest-python2-java-cassandra http://logs.openstack.org/27/658527/2/check/monasca-tempest-python2-java-cassandra/d3d8ee4/ : FAILURE in 33m 09s\n- monasca-tempest-python3-java-cassandra http://logs.openstack.org/27/658527/2/check/monasca-tempest-python3-java-cassandra/e9cc127/ : FAILURE in 21m 05s (non-voting)\n- monascalog-python3-tempest http://logs.openstack.org/27/658527/2/check/monascalog-python3-tempest/6c0c755/ : FAILURE in 44m 39s (non-voting)\n- build-monasca-docker-image http://logs.openstack.org/27/658527/2/check/build-monasca-docker-image/ca01840/ : SUCCESS in 5m 35s","accounts_in_message":[],"_revision_number":2},{"id":"4b9440cb7c37fa1efeae2bade0bfe254faf6c995","author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"date":"2019-05-30 14:29:56.000000000","message":"Patch Set 2:\n\nThank you! Are you able to add a unit test? Is the other branch of the if statement also affected?","accounts_in_message":[],"_revision_number":2},{"id":"d63e3bd19f61556882550fc1d7bff3ad481e1dad","author":{"_account_id":29970,"name":"jianweizhang","email":"zhangjianweibj@inspur.com","username":"zhangjianwei"},"date":"2019-05-31 02:54:26.000000000","message":"Patch Set 2:\n\non_get() method calls function self._alarm_show(req.uri, req.project_id, alarm_id).alarm_show function then calls function _alarms_repo.get_alarm(tenant_id, alarm_id).\nin file sqla/alarms_repository.py,line 259.if alarms query return null or zero.then it raise a exception.\n\n            if rows is None or len(rows) \u003d\u003d 0:\n                raise exceptions.DoesNotExistException\n\ni only catch this exception.no other branch was affected.","accounts_in_message":[],"_revision_number":2},{"id":"9bac41a0a7a94c86926804b05addefcaeb839fca","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-06-04 08:49:20.000000000","message":"Patch Set 2:\n\nWhy is passing errors to users a bad practice? Could you give some reference? In contrary, I would say it\u0027s misleading to return the success code when it\u0027s not the case. Here respective Falcon documentation section [1] and HTTP status codes description [2].\n\nI have run the following:\n\n  # curl -XGET -I -H \"X-Auth-Token: ...\" -H \"Content-type: application/json\" http://monasca_ip:8070/v2.0/alarms/foo\n\nand received:\n\n  HTTP/1.1 404 Not Found\n  Date: Tue, 04 Jun 2019 08:16:12 GMT\n  Server: Apache\n  Content-Length: 0\n  x-openstack-request-id: req-5f1c53b3-9074-478c-97f6-55b0297d1c6b\n  Content-Type: application/json; charset\u003dUTF-8\n\nWhy is that problematic for you and what response would you expect? \n\nI think what we could do is to add more details in `title` and `description` of the error, similarly as we do it here [3].\n\nWe also should update the API spec about return codes [4].\n\n[1] https://falcon.readthedocs.io/en/stable/api/errors.html\n[2] https://httpstatuses.com/404\n[3] https://opendev.org/openstack/monasca-api/src/branch/master/monasca_api/v2/reference/alarm_definitions.py#L224\n[4] https://opendev.org/openstack/monasca-api/src/branch/master/docs/monasca-api-spec.md#response-25","accounts_in_message":[],"_revision_number":2},{"id":"170e6751045a50d683d4015f6c78de8868a02d12","author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"date":"2019-06-04 09:48:05.000000000","message":"Patch Set 2:\n\nI think witek has a good point. I agree that 404 is the most suitable return code here, and that adding more info to the response is the best way of making this more user friendly.","accounts_in_message":[],"_revision_number":2},{"id":"b2e095b0e34096f67db65cac97a8c933c43b7c25","author":{"_account_id":29970,"name":"jianweizhang","email":"zhangjianweibj@inspur.com","username":"zhangjianwei"},"date":"2019-10-09 00:07:16.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0d8197b28c56777fdae6a62048982f5b13ee6687","revisions":{"33381da53381c318966ec85df0d0233e44a9f74e":{"kind":"REWORK","_number":1,"created":"2019-05-11 07:33:23.000000000","uploader":{"_account_id":29970,"name":"jianweizhang","email":"zhangjianweibj@inspur.com","username":"zhangjianwei"},"ref":"refs/changes/27/658527/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-api","ref":"refs/changes/27/658527/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-api refs/changes/27/658527/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-api refs/changes/27/658527/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-api refs/changes/27/658527/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-api refs/changes/27/658527/1"}}},"commit":{"parents":[{"commit":"26133aefe413546f91aaa13c981fe93a69dfc2eb","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-api/commit/26133aefe413546f91aaa13c981fe93a69dfc2eb"}]}],"author":{"name":"zhangjianweibj","email":"zhangjianweibj@inspur.com","date":"2019-05-11 07:16:40.000000000","tz":480},"committer":{"name":"zhangjianweibj","email":"zhangjianweibj@inspur.com","date":"2019-05-11 07:16:40.000000000","tz":480},"subject":"Fix alarms get method return 404 not found bug","message":"Fix alarms get method return 404 not found bug\n\nIf a user get alarm that not exist in database,then return a 404\nnot found error to user (if i use postman get the alarm that not\nexist,then a blank page without any message except 404 not found).\nThis is a very bad design.Any erros or exceptions should not\nforward to users.\n\nChange-Id: Ia621e8fc3b05bdc1f0c628057f5dbeedd10c9431\nStory: 2005648\nTask: 30929\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-api/commit/33381da53381c318966ec85df0d0233e44a9f74e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-api/commit/33381da53381c318966ec85df0d0233e44a9f74e"}]},"branch":"refs/heads/master"},"0d8197b28c56777fdae6a62048982f5b13ee6687":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-05-30 11:33:48.000000000","uploader":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"ref":"refs/changes/27/658527/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-api","ref":"refs/changes/27/658527/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-api refs/changes/27/658527/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-api refs/changes/27/658527/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-api refs/changes/27/658527/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-api refs/changes/27/658527/2"}}},"commit":{"parents":[{"commit":"936c50861e3d2ce01c1e8173426eb773a819b08c","subject":"Merge \"Change repository links usage in Dockerfile and build image\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-api/commit/936c50861e3d2ce01c1e8173426eb773a819b08c"}]}],"author":{"name":"zhangjianweibj","email":"zhangjianweibj@inspur.com","date":"2019-05-11 07:16:40.000000000","tz":480},"committer":{"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","date":"2019-05-30 11:33:48.000000000","tz":0},"subject":"Fix alarms get method return 404 not found bug","message":"Fix alarms get method return 404 not found bug\n\nIf a user get alarm that not exist in database,then return a 404\nnot found error to user (if i use postman get the alarm that not\nexist,then a blank page without any message except 404 not found).\nThis is a very bad design.Any erros or exceptions should not\nforward to users.\n\nChange-Id: Ia621e8fc3b05bdc1f0c628057f5dbeedd10c9431\nStory: 2005648\nTask: 30929\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-api/commit/0d8197b28c56777fdae6a62048982f5b13ee6687"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-api/commit/0d8197b28c56777fdae6a62048982f5b13ee6687"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}