)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"dfda9d5b6f83fd7bf6c00f6ac8ad532dcd8ed453","unresolved":false,"context_lines":[{"line_number":17,"context_line":"https://falcon.readthedocs.io/en/latest/user/faq.html#how-does-falcon-"},{"line_number":18,"context_line":"handle-a-trailing-slash-in-the-request-path"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This commit adds support for using the new release. It currently makes"},{"line_number":21,"context_line":"no effort to be backwards compatible with older releases."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The change also updates the requirements for influxdb and sphinx"},{"line_number":24,"context_line":"libraries to match global requirements."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bfb3d3c7_dd53dde1","line":21,"range":{"start_line":20,"start_character":52,"end_line":21,"end_character":57},"updated":"2019-05-17 15:30:45.000000000","message":"Is there anything which prevents running this code with Falcon 1.x?","commit_id":"dda465c0d8be2f92cf6355b50e5fceaea29ce789"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"057bebe6abb79e42edbb03b93663231073b6c070","unresolved":false,"context_lines":[{"line_number":17,"context_line":"https://falcon.readthedocs.io/en/latest/user/faq.html#how-does-falcon-"},{"line_number":18,"context_line":"handle-a-trailing-slash-in-the-request-path"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This commit adds support for using the new release. It currently makes"},{"line_number":21,"context_line":"no effort to be backwards compatible with older releases."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The change also updates the requirements for influxdb and sphinx"},{"line_number":24,"context_line":"libraries to match global requirements."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bfb3d3c7_f6f47e89","line":21,"range":{"start_line":20,"start_character":52,"end_line":21,"end_character":57},"in_reply_to":"bfb3d3c7_2bddd341","updated":"2019-05-22 10:32:26.000000000","message":"This option has been added in 1.2.0 but even with that one the tests fail.","commit_id":"dda465c0d8be2f92cf6355b50e5fceaea29ce789"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"b1e75da557145d5edb69a954049260d782bc2ae8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"https://falcon.readthedocs.io/en/latest/user/faq.html#how-does-falcon-"},{"line_number":18,"context_line":"handle-a-trailing-slash-in-the-request-path"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This commit adds support for using the new release. It currently makes"},{"line_number":21,"context_line":"no effort to be backwards compatible with older releases."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The change also updates the requirements for influxdb and sphinx"},{"line_number":24,"context_line":"libraries to match global requirements."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bfb3d3c7_2bddd341","line":21,"range":{"start_line":20,"start_character":52,"end_line":21,"end_character":57},"in_reply_to":"bfb3d3c7_dd53dde1","updated":"2019-05-22 09:38:03.000000000","message":"I am aware of one issue in 1.0.0, but there may be more:\n\n- app.req_options.strip_url_path_trailing_slash doesn\u0027t exist in Falcon 1.0.0","commit_id":"dda465c0d8be2f92cf6355b50e5fceaea29ce789"}],"monasca_api/api/server.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f02c1c8423c6e5de3f15b774011fdc3624fb148e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # NOTE(dszumski): Falcon 2.0.0 switches the default for this from True"},{"line_number":37,"context_line":"    # to False so we explicitly set it here to prevent the behaviour"},{"line_number":38,"context_line":"    # changing between versions."},{"line_number":39,"context_line":"    app.req_options.strip_url_path_trailing_slash \u003d True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    versions \u003d simport.load(cfg.CONF.dispatcher.versions)()"},{"line_number":42,"context_line":"    app.add_route(\"/\", versions)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_83346ddf","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":7},"updated":"2019-05-15 16:11:39.000000000","message":"This option doesn\u0027t appear to exist in 1.0.0, we could try/catch if we need to support older versions than 2.0.0.","commit_id":"1e55e43848bf4eca1f250dfce1b00b6a8997f158"}],"monasca_api/v2/reference/helpers.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9c648e8057c75077e7f9fa9a92de2248acfe55ee","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    :raises falcon.HTTPBadRequest:"},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":"    try:"},{"line_number":43,"context_line":"        return req.media"},{"line_number":44,"context_line":"    except Exception as ex:"},{"line_number":45,"context_line":"        LOG.exception(ex)"},{"line_number":46,"context_line":"        raise falcon.HTTPBadRequest(\u0027Bad request\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_2dad709a","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":14},"updated":"2019-05-15 14:47:34.000000000","message":"JSON schema is supported out of the box:\n\nhttps://falcon.readthedocs.io/en/stable/api/media.html#media\n\nThis fixes the unit tests under py35 for me. Internally it calls bounded_stream, which introduces a slight performance cost according to commentary in the code:\n\nFor a slight performance cost, you may instead wish to use\n            :py:attr:`bounded_stream`, which wraps the native WSGI\n            input object to normalize its behavior.","commit_id":"616677e6e30b0e72292ba4865be6777e3df7cc6b"}]}