)]}'
{"monasca_api/common/repositories/cassandra/metrics_repository.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7e49f1999307c4516ad57ed8f5ee3b5bfb272624","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                              end_timestamp\u003dNone):"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        if start_timestamp or end_timestamp:"},{"line_number":164,"context_line":"            LOG.info(\"Scoping by timestamp not implemented for cassandra.\")"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            if metric_name:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_2754e5fe","line":164,"range":{"start_line":164,"start_character":16,"end_line":164,"end_character":20},"updated":"2019-07-12 15:44:50.000000000","message":"It\u0027s probably worth adding something like this here, to help people who want might want to implement this: #NOTE(bkunwar) See story https://storyboard.openstack.org/#!/story/2006204 for more details","commit_id":"d52a86af45f95c58ec8124e7437e16c11c418455"}],"monasca_api/tests/test_repositories.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7e49f1999307c4516ad57ed8f5ee3b5bfb272624","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @patch(\"monasca_api.common.repositories.influxdb.\""},{"line_number":194,"context_line":"           \"metrics_repository.client.InfluxDBClient\")"},{"line_number":195,"context_line":"    def test_list_dimension_values(self, influxdb_client_mock):"},{"line_number":196,"context_line":"        mock_client \u003d influxdb_client_mock.return_value"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        tenant \u003d u\u002738dc2a2549f94d2e9a4fa1cc45a4970c\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_874039a7","line":195,"range":{"start_line":195,"start_character":4,"end_line":195,"end_character":7},"updated":"2019-07-12 15:44:50.000000000","message":"Looking at the code, I think this should support being called without start and end times (i.e. it supports the old behaviour which is good).\n\nInstead of changing these tests to support the new behaviour, can we create new tests(and factor out the common bits perhaps)?\n\nAlso we don\u0027t reject requests which have just a start, or just an end time. We could add tests for those cases too, and check that the query to Influx looks sane. I see that if we just specify an end time, then it looks like no times are included in the Influx query, which seems sensible.","commit_id":"d52a86af45f95c58ec8124e7437e16c11c418455"}]}
