)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"50090104587c9be2be41c5a9ea59b65a6c80424d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Kunwar \u003cbrtknr@bath.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-05 13:48:52 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Minor refactor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I585642b958581962da5f359099941b91542e0a3b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_0c4e6296","line":7,"updated":"2019-08-05 14:06:37.000000000","message":"We need a convincing reason here why this should be merged.\n\nI think the change to influxdb conf makes the code more readable, and I don\u0027t mind merging that, but it\u0027s not clear what the change to the influxdb_opts brings. For that reason I would rather not merge that part because it clutters up the git history.","commit_id":"d57c2855a1a3d0076f4388cf7798b478c87774a6"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"355acab3ce6bedc7cb2b62f026a4e32715c463c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Kunwar \u003cbrtknr@bath.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-05 13:48:52 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Minor refactor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I585642b958581962da5f359099941b91542e0a3b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_cc112a5f","line":7,"in_reply_to":"7faddb67_0c4e6296","updated":"2019-08-05 14:10:32.000000000","message":"The change to influxdb_opts was to bring the config in line with the equivalent piece of code in monasca-persister which was formatted slightly differently.","commit_id":"d57c2855a1a3d0076f4388cf7798b478c87774a6"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"160b524b9625271b59f82d22649abc0b83541fa8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Kunwar \u003cbrtknr@bath.edu\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-05 13:48:52 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Minor refactor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I585642b958581962da5f359099941b91542e0a3b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_82e8d9e1","line":7,"in_reply_to":"7faddb67_cc112a5f","updated":"2019-08-05 15:13:27.000000000","message":"Thanks, although I see where you are coming from I am still reluctant to change the formatting of influxdb_opts because the downsides (review time checking the formatting matches the standard in Monasca API, time people might have to spend rebasing patches which *might* get broken, watering down of the git history) out weight the advantages.\n\nThe commit message still needs to follow the guidance here:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"d57c2855a1a3d0076f4388cf7798b478c87774a6"}],"monasca_api/common/repositories/influxdb/metrics_repository.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"160b524b9625271b59f82d22649abc0b83541fa8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def __init__(self):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            self.conf \u003d cfg.CONF.influxdb"},{"line_number":43,"context_line":"            self.influxdb_client \u003d client.InfluxDBClient("},{"line_number":44,"context_line":"                self.conf.ip_address,"},{"line_number":45,"context_line":"                self.conf.port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_87b30b98","line":42,"range":{"start_line":42,"start_character":12,"end_line":42,"end_character":16},"updated":"2019-08-05 15:13:27.000000000","message":"This isn\u0027t used outside the constructor so no need for it to be an instance var. Also, we should be able to use the global CONF var directly?","commit_id":"d57c2855a1a3d0076f4388cf7798b478c87774a6"}],"monasca_api/conf/influxdb.py":[{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"36fe890d07b78cd3d594cd078bfcfa30f7edf6a7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"influxdb_opts \u003d ["},{"line_number":21,"context_line":"    cfg.StrOpt(\u0027database_name\u0027, default\u003d\u0027mon\u0027,"},{"line_number":22,"context_line":"               help\u003d\u0027Database name where metrics are stored\u0027),"},{"line_number":23,"context_line":"    cfg.HostAddressOpt(\u0027ip_address\u0027, default\u003d\u0027127.0.0.1\u0027,"},{"line_number":24,"context_line":"                       help\u003d\u0027IP address to Influxdb server\u0027),"},{"line_number":25,"context_line":"    cfg.PortOpt(\u0027port\u0027, default\u003d8086,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_01b78088","line":22,"range":{"start_line":22,"start_character":21,"end_line":22,"end_character":59},"updated":"2019-08-13 12:23:05.000000000","message":"This code format is used because we wanted to have new line symbol before and after help.I\u0027m not sure witch format is better.\n\n\"\\nHELP\\n\" \nor \n\u0027\u0027\u0027\nHELP\n\u0027\u0027\u0027","commit_id":"d57c2855a1a3d0076f4388cf7798b478c87774a6"}]}