)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"71f6391f6dad94e1ad44ddb26ce44c7f602174a5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin Chacon Piza \u003cmartin@chaconpiza.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-08 18:10:40 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[goal] Migrate testing to ubuntu focal"},{"line_number":8,"context_line":"As per victoria cycle testing runtime and community goal[1]"},{"line_number":9,"context_line":"we need to migrate upstream CI/CD to Ubuntu Focal(20.04)."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f560f44_69bfb1fb","line":7,"updated":"2020-10-12 09:58:49.000000000","message":"Please add empty line after the first line of the commit message.","commit_id":"a3cde75bdfa7e369ad3914eaa91cddfc891f51dc"},{"author":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"change_message_id":"33952c093695316e5d1754511eebd7748ac106d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Martin Chacon Piza \u003cmartin@chaconpiza.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-08 18:10:40 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[goal] Migrate testing to ubuntu focal"},{"line_number":8,"context_line":"As per victoria cycle testing runtime and community goal[1]"},{"line_number":9,"context_line":"we need to migrate upstream CI/CD to Ubuntu Focal(20.04)."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f560f44_91498733","line":7,"in_reply_to":"9f560f44_69bfb1fb","updated":"2020-10-12 13:46:28.000000000","message":"Done","commit_id":"a3cde75bdfa7e369ad3914eaa91cddfc891f51dc"}],"devstack/files/zookeeper/log4j.properties":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"71f6391f6dad94e1ad44ddb26ce44c7f602174a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f560f44_a96d4968","updated":"2020-10-12 09:58:49.000000000","message":"Please add license info at the top of the file.","commit_id":"a3cde75bdfa7e369ad3914eaa91cddfc891f51dc"},{"author":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"change_message_id":"33952c093695316e5d1754511eebd7748ac106d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f560f44_b14acb20","in_reply_to":"9f560f44_a96d4968","updated":"2020-10-12 13:46:28.000000000","message":"Done","commit_id":"a3cde75bdfa7e369ad3914eaa91cddfc891f51dc"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"71f6391f6dad94e1ad44ddb26ce44c7f602174a5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#log4j.rootLogger\u003d${zookeeper.root.logger}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Example with rolling log file"},{"line_number":20,"context_line":"log4j.rootLogger\u003dINFO, ROLLINGFILE"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Example with rolling log file and tracing"},{"line_number":23,"context_line":"#log4j.rootLogger\u003dTRACE, CONSOLE, ROLLINGFILE, TRACEFILE"}],"source_content_type":"text/x-ini","patch_set":5,"id":"9f560f44_497f4d16","line":20,"updated":"2020-10-12 09:58:49.000000000","message":"The logging configuration is changed I guess. Please make a note in the commit message.","commit_id":"a3cde75bdfa7e369ad3914eaa91cddfc891f51dc"},{"author":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"change_message_id":"33952c093695316e5d1754511eebd7748ac106d6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#log4j.rootLogger\u003d${zookeeper.root.logger}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Example with rolling log file"},{"line_number":20,"context_line":"log4j.rootLogger\u003dINFO, ROLLINGFILE"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Example with rolling log file and tracing"},{"line_number":23,"context_line":"#log4j.rootLogger\u003dTRACE, CONSOLE, ROLLINGFILE, TRACEFILE"}],"source_content_type":"text/x-ini","patch_set":5,"id":"9f560f44_31587bf7","line":20,"in_reply_to":"9f560f44_497f4d16","updated":"2020-10-12 13:46:28.000000000","message":"Done","commit_id":"a3cde75bdfa7e369ad3914eaa91cddfc891f51dc"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"71f6391f6dad94e1ad44ddb26ce44c7f602174a5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# Log INFO level and above messages to the console"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"log4j.appender.CONSOLE\u003dorg.apache.log4j.ConsoleAppender"},{"line_number":29,"context_line":"log4j.appender.CONSOLE.Threshold\u003d${zookeeper.console.threshold}"},{"line_number":30,"context_line":"log4j.appender.CONSOLE.layout\u003dorg.apache.log4j.PatternLayout"},{"line_number":31,"context_line":"log4j.appender.CONSOLE.layout.ConversionPattern\u003d%d{ISO8601} [myid:%X{myid}] - %-5p [%t:%C{1}@%L] - %m%n"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-ini","patch_set":5,"id":"9f560f44_69c97177","line":29,"updated":"2020-10-12 09:58:49.000000000","message":"You\u0027re changing the log level to DEBUG. Please add a note about it in the commit message.","commit_id":"a3cde75bdfa7e369ad3914eaa91cddfc891f51dc"},{"author":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"change_message_id":"33952c093695316e5d1754511eebd7748ac106d6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# Log INFO level and above messages to the console"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"log4j.appender.CONSOLE\u003dorg.apache.log4j.ConsoleAppender"},{"line_number":29,"context_line":"log4j.appender.CONSOLE.Threshold\u003d${zookeeper.console.threshold}"},{"line_number":30,"context_line":"log4j.appender.CONSOLE.layout\u003dorg.apache.log4j.PatternLayout"},{"line_number":31,"context_line":"log4j.appender.CONSOLE.layout.ConversionPattern\u003d%d{ISO8601} [myid:%X{myid}] - %-5p [%t:%C{1}@%L] - %m%n"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-ini","patch_set":5,"id":"9f560f44_9172277b","line":29,"in_reply_to":"9f560f44_69c97177","updated":"2020-10-12 13:46:28.000000000","message":"Done","commit_id":"a3cde75bdfa7e369ad3914eaa91cddfc891f51dc"}],"devstack/lib/zookeeper.sh":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"71f6391f6dad94e1ad44ddb26ce44c7f602174a5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    # but monasca devstack cannot allow it do be done properly"},{"line_number":61,"context_line":"    # we\u0027d have to first refactor parts where services are:"},{"line_number":62,"context_line":"    # installed, configured and started in single phase"},{"line_number":63,"context_line":"    configure_zookeeper"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"$_XTRACE_ZOOKEEPER"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f560f44_69ca1146","side":"PARENT","line":63,"updated":"2020-10-12 09:58:49.000000000","message":"Is `configure_zookeeper` being called anywhere? I think we should keep it or drop completely.","commit_id":"721d5e8fb5318bf08946404836dbc8e0a485431a"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"7cf721127fcc34915af3a01634f4c7d8121d5fa8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    # but monasca devstack cannot allow it do be done properly"},{"line_number":61,"context_line":"    # we\u0027d have to first refactor parts where services are:"},{"line_number":62,"context_line":"    # installed, configured and started in single phase"},{"line_number":63,"context_line":"    configure_zookeeper"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"$_XTRACE_ZOOKEEPER"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f560f44_a488d0c2","side":"PARENT","line":63,"in_reply_to":"9f560f44_09627516","updated":"2020-10-12 10:38:11.000000000","message":"Right, sorry, missed it.","commit_id":"721d5e8fb5318bf08946404836dbc8e0a485431a"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"5ac69875bbb126092b7602270be8d13dcafbe20a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    # but monasca devstack cannot allow it do be done properly"},{"line_number":61,"context_line":"    # we\u0027d have to first refactor parts where services are:"},{"line_number":62,"context_line":"    # installed, configured and started in single phase"},{"line_number":63,"context_line":"    configure_zookeeper"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"$_XTRACE_ZOOKEEPER"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f560f44_09627516","side":"PARENT","line":63,"in_reply_to":"9f560f44_69ca1146","updated":"2020-10-12 10:13:47.000000000","message":"This change remove configure_zookeeper function.","commit_id":"721d5e8fb5318bf08946404836dbc8e0a485431a"},{"author":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"change_message_id":"33952c093695316e5d1754511eebd7748ac106d6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    # but monasca devstack cannot allow it do be done properly"},{"line_number":61,"context_line":"    # we\u0027d have to first refactor parts where services are:"},{"line_number":62,"context_line":"    # installed, configured and started in single phase"},{"line_number":63,"context_line":"    configure_zookeeper"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"$_XTRACE_ZOOKEEPER"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f560f44_11d29734","side":"PARENT","line":63,"in_reply_to":"9f560f44_a488d0c2","updated":"2020-10-12 13:46:28.000000000","message":"Installation, configuration and start/restart are written in the same function, similar to Kafka [1]\n\nI would propose to divide these functions in a further change. Including Zookeeper, Kafka and -if it would be the case- others.\n\n[1] https://opendev.org/openstack/monasca-api/src/branch/master/devstack/plugin.sh#L327","commit_id":"721d5e8fb5318bf08946404836dbc8e0a485431a"}]}