)]}'
{"ceilosca/ceilometer/publisher/monasca_data_filter.py":[{"author":{"_account_id":12637,"name":"Srinivas Sakhamuri","email":"srini.openstack@gmail.com","username":"srsakhamuri"},"change_message_id":"681ffc6d2073fbd1b1e83eeafab03ea57b2145c8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        meter_value \u003d sample.get(\u0027volume\u0027) or sample.get(\u0027counter_volume\u0027)"},{"line_number":113,"context_line":"        if meter_value is None:"},{"line_number":114,"context_line":"            meter_value \u003d 0"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        metric \u003d dict("},{"line_number":117,"context_line":"            name\u003dmeter_name,"},{"line_number":118,"context_line":"            timestamp\u003dself._convert_timestamp(sample[\u0027timestamp\u0027]),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_b69a5760","line":115,"updated":"2015-11-12 18:51:43.000000000","message":"I agree with Rohit reg. the ceilo publisher check, but I think we can have this change, since we may be using this via load sim, or simply using it in a utility to transform sample. Having an extra check is useful.","commit_id":"49270f678dae1a9abb41c255ea06b0e05f138402"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"6c7cb39fcb0ae541bd7751626fba84dc001f568a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        meter_value \u003d sample.get(\u0027volume\u0027) or sample.get(\u0027counter_volume\u0027)"},{"line_number":113,"context_line":"        if meter_value is None:"},{"line_number":114,"context_line":"            meter_value \u003d 0"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        metric \u003d dict("},{"line_number":117,"context_line":"            name\u003dmeter_name,"},{"line_number":118,"context_line":"            timestamp\u003dself._convert_timestamp(sample[\u0027timestamp\u0027]),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_a3433741","line":115,"updated":"2015-11-11 19:51:29.000000000","message":"I think we dont need to account for None volume as samples with None or non-numeric volume will be dropped before they reach publisher. The same change is on master and stable/kilo.\n\nrefer: https://github.com/openstack/ceilometer/blob/stable/liberty/ceilometer/pipeline.py#L585","commit_id":"49270f678dae1a9abb41c255ea06b0e05f138402"},{"author":{"_account_id":13560,"name":"Rohit Jaiswal","email":"rohit.jaiswal@gmail.com","username":"rjaiswal"},"change_message_id":"6c7cb39fcb0ae541bd7751626fba84dc001f568a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            timestamp\u003dself._convert_timestamp(sample[\u0027timestamp\u0027]),"},{"line_number":119,"context_line":"            value\u003dmeter_value,"},{"line_number":120,"context_line":"            dimensions\u003ddimensions,"},{"line_number":121,"context_line":"            value_meta\u003dvalue_meta,"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        LOG.debug(_LI(\"Generated metric with name %(name)s,\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_6349cf5f","line":121,"updated":"2015-11-11 19:51:29.000000000","message":"the value_meta change looks good.","commit_id":"49270f678dae1a9abb41c255ea06b0e05f138402"}]}
