)]}'
{"java/monasca-common-model/src/main/java/com/hpcloud/mon/common/event/AlarmDefinitionCreatedEvent.java":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"b2cc61ff61d01cae27e99a2aff3efbc8b2720b7d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      return true;"},{"line_number":54,"context_line":"    if (obj \u003d\u003d null)"},{"line_number":55,"context_line":"      return false;"},{"line_number":56,"context_line":"    if (getClass() !\u003d obj.getClass())"},{"line_number":57,"context_line":"      return false;"},{"line_number":58,"context_line":"    AlarmDefinitionCreatedEvent other \u003d (AlarmDefinitionCreatedEvent) obj;"},{"line_number":59,"context_line":"    if (alarmDefinitionId \u003d\u003d null) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_0fedfab7","line":56,"updated":"2014-09-16 15:32:58.000000000","message":"I think you want to use instanceof instead of comparing class types.  Block, p. 39.","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"dc29accca7e06cc435e67661f5e2acd1d6fcaf9d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      return true;"},{"line_number":54,"context_line":"    if (obj \u003d\u003d null)"},{"line_number":55,"context_line":"      return false;"},{"line_number":56,"context_line":"    if (getClass() !\u003d obj.getClass())"},{"line_number":57,"context_line":"      return false;"},{"line_number":58,"context_line":"    AlarmDefinitionCreatedEvent other \u003d (AlarmDefinitionCreatedEvent) obj;"},{"line_number":59,"context_line":"    if (alarmDefinitionId \u003d\u003d null) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_639e9dba","line":56,"in_reply_to":"fa98f980_0fedfab7","updated":"2014-09-16 17:20:26.000000000","message":"The debate I\u0027ve seen on this is whether you want to accept subclasses as being equal (which instanceof would accomplish), which sometimes you do and sometimes you don\u0027t. In general it is assumed you don\u0027t, which is why this code (which is generated by eclipse) uses the class comparison by default. I can switch for these though..","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b3a66a3a1782a3ca77cc9e930956ac6d21a1b657","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  public String tenantId;"},{"line_number":31,"context_line":"  public String alarmDefinitionId;"},{"line_number":32,"context_line":"  public String alarmName;"},{"line_number":33,"context_line":"  public String alarmExpression;"},{"line_number":34,"context_line":"  public Map\u003cString, AlarmSubExpression\u003e alarmSubExpressions;"},{"line_number":35,"context_line":"  public List\u003cString\u003e matchBy;"}],"source_content_type":"text/x-java","patch_set":4,"id":"fa98f980_2bf452ce","line":32,"updated":"2014-09-17 18:13:46.000000000","message":"Missing description","commit_id":"2dd6c5299940ff0e3c86ebadc0a1fa17273387dd"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"08cc9da26b138b0fb6b154621aab46eb37c7e2b6","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  public String tenantId;"},{"line_number":31,"context_line":"  public String alarmDefinitionId;"},{"line_number":32,"context_line":"  public String alarmName;"},{"line_number":33,"context_line":"  public String alarmExpression;"},{"line_number":34,"context_line":"  public Map\u003cString, AlarmSubExpression\u003e alarmSubExpressions;"},{"line_number":35,"context_line":"  public List\u003cString\u003e matchBy;"}],"source_content_type":"text/x-java","patch_set":4,"id":"fa98f980_9c682323","line":32,"in_reply_to":"fa98f980_2bf452ce","updated":"2014-09-17 18:16:59.000000000","message":"Done","commit_id":"2dd6c5299940ff0e3c86ebadc0a1fa17273387dd"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"5196dcbaec37406e6f731349af51f1a4ac431035","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  public String tenantId;"},{"line_number":31,"context_line":"  public String alarmDefinitionId;"},{"line_number":32,"context_line":"  public String alarmName;"},{"line_number":33,"context_line":"  public String alarmDescription;"},{"line_number":34,"context_line":"  public String alarmExpression;"},{"line_number":35,"context_line":"  public Map\u003cString, AlarmSubExpression\u003e alarmSubExpressions;"}],"source_content_type":"text/x-java","patch_set":5,"id":"fa98f980_79fd463b","line":32,"updated":"2014-09-18 04:16:58.000000000","message":"I think alarm should be removed from these field names. It really isn\u0027t the alarmName it is the alarmDefinitionName but since the event is AlarmDefinitionCreatedEvent, it is probably redundant to call it alarmDefinitionName","commit_id":"145f1aa7e9f5ff92455559155db44031e2427546"}],"java/monasca-common-model/src/main/java/com/hpcloud/mon/common/event/AlarmDefinitionDeletedEvent.java":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"b2cc61ff61d01cae27e99a2aff3efbc8b2720b7d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      return true;"},{"line_number":46,"context_line":"    if (obj \u003d\u003d null)"},{"line_number":47,"context_line":"      return false;"},{"line_number":48,"context_line":"    if (getClass() !\u003d obj.getClass())"},{"line_number":49,"context_line":"      return false;"},{"line_number":50,"context_line":"    AlarmDefinitionDeletedEvent other \u003d (AlarmDefinitionDeletedEvent) obj;"},{"line_number":51,"context_line":"    if (alarmDefinitionId \u003d\u003d null) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_6f0a067b","line":48,"updated":"2014-09-16 15:32:58.000000000","message":"instanceof?","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b3a66a3a1782a3ca77cc9e930956ac6d21a1b657","unresolved":false,"context_lines":[{"line_number":26,"context_line":"public class AlarmDefinitionDeletedEvent implements Serializable {"},{"line_number":27,"context_line":"  private static final long serialVersionUID \u003d -845914476456541787L;"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  public String tenantId;"},{"line_number":30,"context_line":"  public String alarmDefinitionId;"},{"line_number":31,"context_line":"  public Map\u003cString, MetricDefinition\u003e subAlarmMetricDefinitions;"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"fa98f980_4befd6e9","line":29,"updated":"2014-09-17 18:13:46.000000000","message":"I don\u0027t think we need tenantId","commit_id":"2dd6c5299940ff0e3c86ebadc0a1fa17273387dd"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"08cc9da26b138b0fb6b154621aab46eb37c7e2b6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"public class AlarmDefinitionDeletedEvent implements Serializable {"},{"line_number":27,"context_line":"  private static final long serialVersionUID \u003d -845914476456541787L;"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  public String tenantId;"},{"line_number":30,"context_line":"  public String alarmDefinitionId;"},{"line_number":31,"context_line":"  public Map\u003cString, MetricDefinition\u003e subAlarmMetricDefinitions;"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"fa98f980_dc72ab10","line":29,"in_reply_to":"fa98f980_4befd6e9","updated":"2014-09-17 18:16:59.000000000","message":"Done","commit_id":"2dd6c5299940ff0e3c86ebadc0a1fa17273387dd"}],"java/monasca-common-model/src/main/java/com/hpcloud/mon/common/event/AlarmDefinitionUpdatedEvent.java":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"b2cc61ff61d01cae27e99a2aff3efbc8b2720b7d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      return true;"},{"line_number":71,"context_line":"    if (obj \u003d\u003d null)"},{"line_number":72,"context_line":"      return false;"},{"line_number":73,"context_line":"    if (getClass() !\u003d obj.getClass())"},{"line_number":74,"context_line":"      return false;"},{"line_number":75,"context_line":"    AlarmDefinitionUpdatedEvent other \u003d (AlarmDefinitionUpdatedEvent) obj;"},{"line_number":76,"context_line":"    if (alarmActionsEnabled !\u003d other.alarmActionsEnabled)"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_4f7c62ec","line":73,"updated":"2014-09-16 15:32:58.000000000","message":"instanceof?","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"}],"java/monasca-common-model/src/main/java/com/hpcloud/mon/common/event/AlarmDeletedEvent.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"12277389a69ffaad2895b162e977bf4847a36d97","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  private static final long serialVersionUID \u003d -988406683520841426L;"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  public String tenantId;"},{"line_number":28,"context_line":"  public String alarmId;"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  public AlarmDeletedEvent() {}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"fa98f980_d85af34e","line":28,"updated":"2014-09-15 23:11:00.000000000","message":"Could you add the AlarmDefinitionId? I think it will make it easier to find the Alarm in some bolts. I can\u0027t get the AlarmDefinition myself once the Alarm is deleted since it is a hard delete from the database","commit_id":"c1bf096fe3ed39e4e72b5cd9f0313077058bd262"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"b2cc61ff61d01cae27e99a2aff3efbc8b2720b7d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  public String tenantId;"},{"line_number":28,"context_line":"  public String alarmId;"},{"line_number":29,"context_line":"  public String alarmDefinitionId;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  public AlarmDeletedEvent() {}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_8fa2ca49","line":29,"updated":"2014-09-16 15:32:58.000000000","message":"Do we need the alarmDefinitionId if we have the alarmId?","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"dc29accca7e06cc435e67661f5e2acd1d6fcaf9d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  public String tenantId;"},{"line_number":28,"context_line":"  public String alarmId;"},{"line_number":29,"context_line":"  public String alarmDefinitionId;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  public AlarmDeletedEvent() {}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_c3dae978","line":29,"in_reply_to":"fa98f980_8fa2ca49","updated":"2014-09-16 17:20:26.000000000","message":"We don\u0027t completely need it, but Craig requested it for convenience.","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"b2cc61ff61d01cae27e99a2aff3efbc8b2720b7d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      return true;"},{"line_number":43,"context_line":"    if (obj \u003d\u003d null)"},{"line_number":44,"context_line":"      return false;"},{"line_number":45,"context_line":"    if (getClass() !\u003d obj.getClass())"},{"line_number":46,"context_line":"      return false;"},{"line_number":47,"context_line":"    AlarmDeletedEvent other \u003d (AlarmDeletedEvent) obj;"},{"line_number":48,"context_line":"    if (alarmDefinitionId \u003d\u003d null) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_2f939e01","line":45,"updated":"2014-09-16 15:32:58.000000000","message":"instanceof?","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b3a66a3a1782a3ca77cc9e930956ac6d21a1b657","unresolved":false,"context_lines":[{"line_number":24,"context_line":"public class AlarmDeletedEvent implements Serializable {"},{"line_number":25,"context_line":"  private static final long serialVersionUID \u003d -988406683520841426L;"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  public String tenantId;"},{"line_number":28,"context_line":"  public String alarmId;"},{"line_number":29,"context_line":"  public String alarmDefinitionId;"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"fa98f980_cec834ab","line":27,"updated":"2014-09-17 18:13:46.000000000","message":"Don\u0027t need tenantId","commit_id":"2dd6c5299940ff0e3c86ebadc0a1fa17273387dd"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"08cc9da26b138b0fb6b154621aab46eb37c7e2b6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"public class AlarmDeletedEvent implements Serializable {"},{"line_number":25,"context_line":"  private static final long serialVersionUID \u003d -988406683520841426L;"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  public String tenantId;"},{"line_number":28,"context_line":"  public String alarmId;"},{"line_number":29,"context_line":"  public String alarmDefinitionId;"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"fa98f980_fc5e8f78","line":27,"in_reply_to":"fa98f980_cec834ab","updated":"2014-09-17 18:16:59.000000000","message":"Done","commit_id":"2dd6c5299940ff0e3c86ebadc0a1fa17273387dd"}],"java/monasca-common-model/src/main/java/com/hpcloud/mon/common/event/AlarmStateTransitionedEvent.java":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"b2cc61ff61d01cae27e99a2aff3efbc8b2720b7d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  public long timestamp;"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  public AlarmStateTransitionedEvent() {}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  public AlarmStateTransitionedEvent(String tenantId, String alarmId, String alarmDefinitionId,"},{"line_number":43,"context_line":"      List\u003cMetricDefinition\u003e metrics, String alarmName, String alarmDescription,"},{"line_number":44,"context_line":"      AlarmState oldState, AlarmState newState, boolean actionsEnabled, String stateChangeReason,"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_af5b0e54","line":41,"updated":"2014-09-16 15:32:58.000000000","message":"equals and haschcode?","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"dc29accca7e06cc435e67661f5e2acd1d6fcaf9d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  public long timestamp;"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  public AlarmStateTransitionedEvent() {}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  public AlarmStateTransitionedEvent(String tenantId, String alarmId, String alarmDefinitionId,"},{"line_number":43,"context_line":"      List\u003cMetricDefinition\u003e metrics, String alarmName, String alarmDescription,"},{"line_number":44,"context_line":"      AlarmState oldState, AlarmState newState, boolean actionsEnabled, String stateChangeReason,"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_4861b810","line":41,"in_reply_to":"fa98f980_af5b0e54","updated":"2014-09-16 17:20:26.000000000","message":"I don\u0027t think events are ever hashed/compared, but added just in case.","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"}],"java/monasca-common-model/src/main/java/com/hpcloud/mon/common/event/AlarmUpdatedEvent.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"12277389a69ffaad2895b162e977bf4847a36d97","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  private static final long serialVersionUID \u003d -890221414491823712L;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  public String tenantId;"},{"line_number":29,"context_line":"  public String alarmId;"},{"line_number":30,"context_line":"  public AlarmState alarmState;"},{"line_number":31,"context_line":"  public AlarmState oldAlarmState;"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"fa98f980_7355a8f8","line":29,"updated":"2014-09-15 23:11:00.000000000","message":"I\u0027m not sure I need the AlarmDefinitionId here, but maybe you should just add it","commit_id":"c1bf096fe3ed39e4e72b5cd9f0313077058bd262"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"b2cc61ff61d01cae27e99a2aff3efbc8b2720b7d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      return true;"},{"line_number":49,"context_line":"    if (obj \u003d\u003d null)"},{"line_number":50,"context_line":"      return false;"},{"line_number":51,"context_line":"    if (getClass() !\u003d obj.getClass())"},{"line_number":52,"context_line":"      return false;"},{"line_number":53,"context_line":"    AlarmUpdatedEvent other \u003d (AlarmUpdatedEvent) obj;"},{"line_number":54,"context_line":"    if (alarmDefinitionId \u003d\u003d null) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"fa98f980_0f017a06","line":51,"updated":"2014-09-16 15:32:58.000000000","message":"instanceof?","commit_id":"3ce3886f13d511eaba851f253bacb3d17ccbf1aa"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b3a66a3a1782a3ca77cc9e930956ac6d21a1b657","unresolved":false,"context_lines":[{"line_number":25,"context_line":"public class AlarmUpdatedEvent implements Serializable {"},{"line_number":26,"context_line":"  private static final long serialVersionUID \u003d -890221414491823712L;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  public String tenantId;"},{"line_number":29,"context_line":"  public String alarmId;"},{"line_number":30,"context_line":"  public String alarmDefinitionId;"},{"line_number":31,"context_line":"  public AlarmState alarmState;"}],"source_content_type":"text/x-java","patch_set":4,"id":"fa98f980_2b90d24d","line":28,"updated":"2014-09-17 18:13:46.000000000","message":"Don\u0027t need tenantId","commit_id":"2dd6c5299940ff0e3c86ebadc0a1fa17273387dd"},{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"08cc9da26b138b0fb6b154621aab46eb37c7e2b6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"public class AlarmUpdatedEvent implements Serializable {"},{"line_number":26,"context_line":"  private static final long serialVersionUID \u003d -890221414491823712L;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  public String tenantId;"},{"line_number":29,"context_line":"  public String alarmId;"},{"line_number":30,"context_line":"  public String alarmDefinitionId;"},{"line_number":31,"context_line":"  public AlarmState alarmState;"}],"source_content_type":"text/x-java","patch_set":4,"id":"fa98f980_1c643348","line":28,"in_reply_to":"fa98f980_2b90d24d","updated":"2014-09-17 18:16:59.000000000","message":"Done","commit_id":"2dd6c5299940ff0e3c86ebadc0a1fa17273387dd"}]}
