)]}'
{"monasca_common/config/opts.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"58bdd7dca4bedb309233b794044f12e70c947f96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_f9267715","line":1,"updated":"2015-08-17 23:07:41.000000000","message":"We should talk about the overall organization of the opts. In general, I would like to see opts for a specific area, like logging, or mysql, or kafka, under that area.\n\nFor example, the opts for kafka would be under\n\nmonasca_common/message/kafka","commit_id":"53de10d51cb4deb9d35cc39126327fba657f18ea"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"58bdd7dca4bedb309233b794044f12e70c947f96","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               help\u003d\u0027The topic for reading transformed events.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027transform_group\u0027, default\u003d\u0027monasca-event\u0027,"},{"line_number":54,"context_line":"               help\u003d\u0027The group name for reading raw events.\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027transform_def_topic\u0027, default\u003d\u0027transform-definitions\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027The topic for transform definition events.\u0027),"},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027fetch_size\u0027, default\u003d32768,"},{"line_number":58,"context_line":"               help\u003d\u0027The number of fetch size bytes.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_f9543755","line":55,"updated":"2015-08-17 23:07:41.000000000","message":"There are Kafka specific options, like fetch_size, buffer_size, ..., and then there are options for things fields like the topic, event_group, or stream_def_group, .... I think these options should be separated.\n\nThe metrics pipeline should in general not know anything about the metrics pipeline, ... Unless it really does need to know.","commit_id":"53de10d51cb4deb9d35cc39126327fba657f18ea"}],"monasca_common/config/register.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"58bdd7dca4bedb309233b794044f12e70c947f96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_99f3bb73","line":1,"updated":"2015-08-17 23:07:41.000000000","message":"I think this would change, based on my comments on where the opts woudl live.","commit_id":"53de10d51cb4deb9d35cc39126327fba657f18ea"}],"monasca_common/repositories/constants.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"58bdd7dca4bedb309233b794044f12e70c947f96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_39b62f8b","line":1,"updated":"2015-08-17 23:07:41.000000000","message":"I don\u0027t see the same paging limits being necessarily used across projects.","commit_id":"53de10d51cb4deb9d35cc39126327fba657f18ea"}],"monasca_common/repositories/events/streams_repository.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"58bdd7dca4bedb309233b794044f12e70c947f96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_99365b02","line":1,"updated":"2015-08-17 23:07:41.000000000","message":"Is there any other project, besides the monasca-events-api that creates a stream definition? \n\nI don\u0027t think there is, so not sure why we would have this repository in common.\n\nI would only put some very \"common\" level of stuff in the monasca-common repo.","commit_id":"53de10d51cb4deb9d35cc39126327fba657f18ea"}],"monasca_common/repositories/exceptions.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"58bdd7dca4bedb309233b794044f12e70c947f96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_5c2511a9","line":1,"updated":"2015-08-17 23:07:41.000000000","message":"So, I expect this to be common across all projects, so this can be in monasca-common","commit_id":"53de10d51cb4deb9d35cc39126327fba657f18ea"}],"monasca_common/repositories/mysql/events/streams_repository.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"58bdd7dca4bedb309233b794044f12e70c947f96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_bc346dde","line":1,"updated":"2015-08-17 23:07:41.000000000","message":"Same comment was earlier about stream definitions.","commit_id":"53de10d51cb4deb9d35cc39126327fba657f18ea"}],"monasca_common/repositories/mysql/mysql_repository.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"58bdd7dca4bedb309233b794044f12e70c947f96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_7c74959b","line":1,"updated":"2015-08-17 23:07:41.000000000","message":"So, this class I expect to be common across all repos, so this should be in monasca-common. There isn\u0027t any code here that is specific to metrics or events or logging.","commit_id":"53de10d51cb4deb9d35cc39126327fba657f18ea"}]}