)]}'
{"java/monasca-common-middleware/src/main/java/monasca/common/middleware/HttpAuthClient.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"5b44ffaa8513d6a67202c348c1b99f0f73bd661a","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  }"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"  private String buildAuth(final String userName, final String password,"},{"line_number":247,"context_line":"                           final String projectId, final String projectName, final String userDomain, final String projectDomain) {"},{"line_number":248,"context_line":"    final JsonObject jsonUserDomain \u003d new JsonObject();"},{"line_number":249,"context_line":"    if (!userDomain.isEmpty()) {"},{"line_number":250,"context_line":"      jsonUserDomain.addProperty(\"name\", userDomain);"}],"source_content_type":"text/x-java","patch_set":1,"id":"fa1b9901_6a596e34","line":247,"updated":"2015-08-21 02:21:08.000000000","message":"Probably would be good idea to add a newline after project Name and then a newline after the start of the function body, after the \"{\"","commit_id":"2fd34f97c2fdbaba0c680e51f2067be59b0683e6"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"5b44ffaa8513d6a67202c348c1b99f0f73bd661a","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"  private String buildAuth(final String userName, final String password,"},{"line_number":247,"context_line":"                           final String projectId, final String projectName, final String userDomain, final String projectDomain) {"},{"line_number":248,"context_line":"    final JsonObject jsonUserDomain \u003d new JsonObject();"},{"line_number":249,"context_line":"    if (!userDomain.isEmpty()) {"},{"line_number":250,"context_line":"      jsonUserDomain.addProperty(\"name\", userDomain);"},{"line_number":251,"context_line":"    } else {"}],"source_content_type":"text/x-java","patch_set":1,"id":"fa1b9901_eab81e13","line":248,"updated":"2015-08-21 02:21:08.000000000","message":"I would like to keep the convention that was used to name variables already if possible.\n\nThe pre-existing parameters to the function, like userName, projectName, had the \"Name\" suffix. Then when the JsonObject is created and assigned to a variable the \"Name\" suffix is dropped.\n\nSo instead of having jsonUserDomain, you would have\n\nfinal JsonObject userDomain \u003d new JsonObject();\n\nand the parameter to the function would be userDomainName.","commit_id":"2fd34f97c2fdbaba0c680e51f2067be59b0683e6"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"5b44ffaa8513d6a67202c348c1b99f0f73bd661a","unresolved":false,"context_lines":[{"line_number":274,"context_line":"      scopeDefined \u003d true;"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    } else if (!projectName.isEmpty()) {"},{"line_number":277,"context_line":"      final JsonObject jsonProjectDomain \u003d new JsonObject();"},{"line_number":278,"context_line":"      if (!projectDomain.isEmpty()) {"},{"line_number":279,"context_line":"        jsonProjectDomain.addProperty(\"name\", projectDomain);"},{"line_number":280,"context_line":"      } else {"}],"source_content_type":"text/x-java","patch_set":1,"id":"fa1b9901_6a43ae13","line":277,"updated":"2015-08-21 02:21:08.000000000","message":"Same comment as above.","commit_id":"2fd34f97c2fdbaba0c680e51f2067be59b0683e6"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"5b44ffaa8513d6a67202c348c1b99f0f73bd661a","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    final String body;"},{"line_number":304,"context_line":"    if (appConfig.getAdminAuthMethod().equalsIgnoreCase(Config.PASSWORD)) {"},{"line_number":305,"context_line":"      body \u003d buildAuth(appConfig.getAdminUser(), appConfig.getAdminPassword(),"},{"line_number":306,"context_line":"                       appConfig.getAdminProjectId(), appConfig.getAdminProjectName(), appConfig.getAdminUserDomainName(), appConfig.getAdminProjectDomainName());"},{"line_number":307,"context_line":"    } else {"},{"line_number":308,"context_line":"      String"},{"line_number":309,"context_line":"          msg \u003d"}],"source_content_type":"text/x-java","patch_set":1,"id":"fa1b9901_6a288e33","line":306,"updated":"2015-08-21 02:21:08.000000000","message":"A new line after \"appConfig.getAdminProjectName()\", would probably be a good idea here.\n\nNote, we\u0027ve adopted to Google style guide for coding conventions at, https://google-styleguide.googlecode.com/svn/trunk/javaguide.html and documented at, https://wiki.openstack.org/wiki/Monasca.\n\nLine lengths are restricted to 100 chars. Not sure you are past that, but I think it would look a little nicer to balance out the lines.","commit_id":"2fd34f97c2fdbaba0c680e51f2067be59b0683e6"}]}