)]}'
{"java/monasca-common-hibernate/src/main/java/monasca/common/hibernate/db/AbstractAuditablePersistable.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3af6671858a5c3dbd59467ed6bc4631df58b8334","unresolved":false,"context_lines":[{"line_number":147,"context_line":"      this.updatedAt \u003d date;"},{"line_number":148,"context_line":"    } else {"},{"line_number":149,"context_line":"      this.createdAt \u003d createdAt.toDateTime(DateTimeZone.UTC).toDate();"},{"line_number":150,"context_line":"      this.updatedAt \u003d updatedAt.toDateTime(DateTimeZone.UTC).toDate();"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":"  }"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"ba15a1d1_22084f91","line":150,"updated":"2015-09-19 05:06:28.000000000","message":"Why isn\u0027t this just:\nif (createdAt \u003d\u003d null) {\n   this.createdAt \u003d date;\n}\nelse {\n   this.createdAt \u003d createdAt;\n}\n\nand then the same for updatedAt? It would easier to read and the code you have here wouldn\u0027t set this.updatedAt if it createdAt was null but updatedAt was not.","commit_id":"332e6c1b840f5beffc3115091f0864869ce7b911"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"442350fd63f411119c58bbc956e26e879115668a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"      this.updatedAt \u003d date;"},{"line_number":148,"context_line":"    } else {"},{"line_number":149,"context_line":"      this.createdAt \u003d createdAt.toDateTime(DateTimeZone.UTC).toDate();"},{"line_number":150,"context_line":"      this.updatedAt \u003d updatedAt.toDateTime(DateTimeZone.UTC).toDate();"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":"  }"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"ba15a1d1_b80a4e78","line":150,"in_reply_to":"ba15a1d1_22084f91","updated":"2015-09-19 11:40:09.000000000","message":"Good point. I will refactor it in next patch set.","commit_id":"332e6c1b840f5beffc3115091f0864869ce7b911"}],"java/monasca-common-hibernate/src/main/java/monasca/common/hibernate/db/AbstractPersistable.java":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"e61908c936737eff400166944747663aff2a71c0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import org.hibernate.annotations.DynamicInsert;"},{"line_number":26,"context_line":"import org.hibernate.annotations.DynamicUpdate;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import monasca.common.hibernate.core.AuditablePersistable;"},{"line_number":29,"context_line":"import monasca.common.hibernate.core.Persistable;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"/**"}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_d9ee0fec","line":28,"updated":"2015-09-25 11:25:49.000000000","message":"The import is never used.","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f1371081618f772d4e31b06343dfc91617647b48","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import org.hibernate.annotations.DynamicInsert;"},{"line_number":26,"context_line":"import org.hibernate.annotations.DynamicUpdate;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import monasca.common.hibernate.core.AuditablePersistable;"},{"line_number":29,"context_line":"import monasca.common.hibernate.core.Persistable;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"/**"}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_c47cad74","line":28,"in_reply_to":"9a1a9d01_d9ee0fec","updated":"2015-09-28 09:14:50.000000000","message":"Done","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"}],"java/monasca-common-hibernate/src/main/java/monasca/common/hibernate/db/SubAlarmDefinitionDb.java":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"e61908c936737eff400166944747663aff2a71c0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"import org.hibernate.annotations.OnDeleteAction;"},{"line_number":29,"context_line":"import org.joda.time.DateTime;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"import monasca.common.model.alarm.AlarmOperator;"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@Entity"},{"line_number":34,"context_line":"@Table(name \u003d \"sub_alarm_definition\")"}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_7963431b","line":31,"updated":"2015-09-25 11:25:49.000000000","message":"Why do you change the ordering? It is not Google Java Style conform anyway.","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"4443a0c6711619f7b7db856f3afea52ca023d134","unresolved":false,"context_lines":[{"line_number":28,"context_line":"import org.hibernate.annotations.OnDeleteAction;"},{"line_number":29,"context_line":"import org.joda.time.DateTime;"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"import monasca.common.model.alarm.AlarmOperator;"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@Entity"},{"line_number":34,"context_line":"@Table(name \u003d \"sub_alarm_definition\")"}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_cd3b80d0","line":31,"in_reply_to":"9a1a9d01_7963431b","updated":"2015-09-26 20:36:19.000000000","message":"Monasca wishes to have their imports at the very bottom.","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"}],"java/monasca-common-util/src/main/java/monasca/common/util/Conversions.java":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"e61908c936737eff400166944747663aff2a71c0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      final T[] enumConstants \u003d enumClazz.getEnumConstants();"},{"line_number":98,"context_line":"      if (index \u003c 0 || index \u003e\u003d enumConstants.length) {"},{"line_number":99,"context_line":"        throw new IllegalArgumentException("},{"line_number":100,"context_line":"            String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" exceeds maximum number of constants %d\","},{"line_number":101,"context_line":"                variant.getClass(),"},{"line_number":102,"context_line":"                variant,"},{"line_number":103,"context_line":"                enumConstants.length"}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_9f55d2c7","line":100,"updated":"2015-09-25 11:25:49.000000000","message":"Is out of range.","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"4443a0c6711619f7b7db856f3afea52ca023d134","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      final T[] enumConstants \u003d enumClazz.getEnumConstants();"},{"line_number":98,"context_line":"      if (index \u003c 0 || index \u003e\u003d enumConstants.length) {"},{"line_number":99,"context_line":"        throw new IllegalArgumentException("},{"line_number":100,"context_line":"            String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" exceeds maximum number of constants %d\","},{"line_number":101,"context_line":"                variant.getClass(),"},{"line_number":102,"context_line":"                variant,"},{"line_number":103,"context_line":"                enumConstants.length"}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_ed3684e6","line":100,"in_reply_to":"9a1a9d01_9f55d2c7","updated":"2015-09-26 20:36:19.000000000","message":"Good point. I will update that ASAP.","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f1371081618f772d4e31b06343dfc91617647b48","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      final T[] enumConstants \u003d enumClazz.getEnumConstants();"},{"line_number":98,"context_line":"      if (index \u003c 0 || index \u003e\u003d enumConstants.length) {"},{"line_number":99,"context_line":"        throw new IllegalArgumentException("},{"line_number":100,"context_line":"            String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" exceeds maximum number of constants %d\","},{"line_number":101,"context_line":"                variant.getClass(),"},{"line_number":102,"context_line":"                variant,"},{"line_number":103,"context_line":"                enumConstants.length"}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_bf20a09c","line":100,"in_reply_to":"9a1a9d01_ed3684e6","updated":"2015-09-28 09:14:50.000000000","message":"Done","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"e61908c936737eff400166944747663aff2a71c0","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    } else if (variant instanceof Enum) {"},{"line_number":110,"context_line":"      return (T) variant;"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":"    throw new IllegalArgumentException(String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" is not a Number.\","},{"line_number":113,"context_line":"        variant.getClass(), variant));"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_7f631eb2","line":112,"updated":"2015-09-25 11:25:49.000000000","message":"It is not a String or Enum either.","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"4443a0c6711619f7b7db856f3afea52ca023d134","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    } else if (variant instanceof Enum) {"},{"line_number":110,"context_line":"      return (T) variant;"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":"    throw new IllegalArgumentException(String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" is not a Number.\","},{"line_number":113,"context_line":"        variant.getClass(), variant));"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_8d3588db","line":112,"in_reply_to":"9a1a9d01_7f631eb2","updated":"2015-09-26 20:36:19.000000000","message":"Good point. I will update that ASAP.","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f1371081618f772d4e31b06343dfc91617647b48","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    } else if (variant instanceof Enum) {"},{"line_number":110,"context_line":"      return (T) variant;"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":"    throw new IllegalArgumentException(String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" is not a Number.\","},{"line_number":113,"context_line":"        variant.getClass(), variant));"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-java","patch_set":7,"id":"9a1a9d01_df2314a6","line":112,"in_reply_to":"9a1a9d01_8d3588db","updated":"2015-09-28 09:14:50.000000000","message":"Done","commit_id":"35a9ff2c4c83a7708afa7511c3d79185983bca56"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"83ec050b0fcca08e126419f7d80ac974ad28715b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import org.joda.time.DateTime;"},{"line_number":22,"context_line":"import org.joda.time.DateTimeZone;"},{"line_number":23,"context_line":"import org.joda.time.chrono.ISOChronology;"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"public final class Conversions {"},{"line_number":26,"context_line":"  private static final String[] SUPPORTED_VARIANT_TO_ENUM_TYPES \u003d new String[]{"}],"source_content_type":"text/x-java","patch_set":8,"id":"9a1a9d01_a413b40c","line":23,"updated":"2015-09-28 10:45:46.000000000","message":"Please see below.","commit_id":"889bf3151cec7c8ac446fb35df8c6eed7f151e02"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"83ec050b0fcca08e126419f7d80ac974ad28715b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"      if(((DateTime) variant).getChronology().equals(ISOChronology.getInstance(timeZone))) {"},{"line_number":80,"context_line":"        // if both share the time zone do not apply conversion"},{"line_number":81,"context_line":"        return (DateTime) variant;"},{"line_number":82,"context_line":"      }"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":"    return new DateTime(variant, timeZone);"},{"line_number":85,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":8,"id":"9a1a9d01_a4f734f4","line":82,"updated":"2015-09-28 10:45:46.000000000","message":"Better:\nreturn ((DateTime) variant).toDateTime(timeZone);","commit_id":"889bf3151cec7c8ac446fb35df8c6eed7f151e02"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"8acda31486e3002b96457ef35c2c87b4de537dd4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"      if(((DateTime) variant).getChronology().equals(ISOChronology.getInstance(timeZone))) {"},{"line_number":80,"context_line":"        // if both share the time zone do not apply conversion"},{"line_number":81,"context_line":"        return (DateTime) variant;"},{"line_number":82,"context_line":"      }"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":"    return new DateTime(variant, timeZone);"},{"line_number":85,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":8,"id":"9a1a9d01_8f0d6992","line":82,"in_reply_to":"9a1a9d01_a4f734f4","updated":"2015-09-28 11:16:03.000000000","message":"Nice catch, done.","commit_id":"889bf3151cec7c8ac446fb35df8c6eed7f151e02"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"83ec050b0fcca08e126419f7d80ac974ad28715b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"      final T[] enumConstants \u003d enumClazz.getEnumConstants();"},{"line_number":116,"context_line":"      if (index \u003c 0 || index \u003e\u003d enumConstants.length) {"},{"line_number":117,"context_line":"        throw new IllegalArgumentException("},{"line_number":118,"context_line":"            String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" is out of range %d\","},{"line_number":119,"context_line":"                variant.getClass(),"},{"line_number":120,"context_line":"                variant,"},{"line_number":121,"context_line":"                enumConstants.length"}],"source_content_type":"text/x-java","patch_set":8,"id":"9a1a9d01_646a7c1c","line":118,"updated":"2015-09-28 10:45:46.000000000","message":"\"[...] is out of range [0, %d].\"","commit_id":"889bf3151cec7c8ac446fb35df8c6eed7f151e02"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"8acda31486e3002b96457ef35c2c87b4de537dd4","unresolved":false,"context_lines":[{"line_number":115,"context_line":"      final T[] enumConstants \u003d enumClazz.getEnumConstants();"},{"line_number":116,"context_line":"      if (index \u003c 0 || index \u003e\u003d enumConstants.length) {"},{"line_number":117,"context_line":"        throw new IllegalArgumentException("},{"line_number":118,"context_line":"            String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" is out of range %d\","},{"line_number":119,"context_line":"                variant.getClass(),"},{"line_number":120,"context_line":"                variant,"},{"line_number":121,"context_line":"                enumConstants.length"}],"source_content_type":"text/x-java","patch_set":8,"id":"9a1a9d01_0a4dc76b","line":118,"in_reply_to":"9a1a9d01_646a7c1c","updated":"2015-09-28 11:16:03.000000000","message":"Done","commit_id":"889bf3151cec7c8ac446fb35df8c6eed7f151e02"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"83ec050b0fcca08e126419f7d80ac974ad28715b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    } else if (variant instanceof Enum) {"},{"line_number":128,"context_line":"      return (T) variant;"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":"    throw new IllegalArgumentException(String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" is not a %s\","},{"line_number":131,"context_line":"        variant.getClass(), variant, Arrays.toString(SUPPORTED_VARIANT_TO_ENUM_TYPES)));"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":8,"id":"9a1a9d01_44cc186a","line":130,"updated":"2015-09-28 10:45:46.000000000","message":"\"[...] is not one of %s.\". And please wrap.","commit_id":"889bf3151cec7c8ac446fb35df8c6eed7f151e02"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"8acda31486e3002b96457ef35c2c87b4de537dd4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    } else if (variant instanceof Enum) {"},{"line_number":128,"context_line":"      return (T) variant;"},{"line_number":129,"context_line":"    }"},{"line_number":130,"context_line":"    throw new IllegalArgumentException(String.format(\"Variant of type \\\"%s\\\", and value \\\"%s\\\" is not a %s\","},{"line_number":131,"context_line":"        variant.getClass(), variant, Arrays.toString(SUPPORTED_VARIANT_TO_ENUM_TYPES)));"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":8,"id":"9a1a9d01_ef7d05e8","line":130,"in_reply_to":"9a1a9d01_44cc186a","updated":"2015-09-28 11:16:03.000000000","message":"Done","commit_id":"889bf3151cec7c8ac446fb35df8c6eed7f151e02"}]}