)]}'
{"monasca_common/kafka/producer.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"340f95deddac17f9aeb3e10f45b560adc4dfa929","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            partitioner \u003d kafka.partitioner.RoundRobinPartitioner"},{"line_number":37,"context_line":"        else:"},{"line_number":38,"context_line":"            partitioner \u003d kafka.partitioner.Murmur2Partitioner"},{"line_number":39,"context_line":"        kwargs \u003d {\u0027partitioner\u0027: partitioner}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self._kafka \u003d kafka.client.KafkaClient(url)"},{"line_number":42,"context_line":"        self._producer \u003d kafka.producer.KeyedProducer("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_056fecc5","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":31},"updated":"2016-04-05 14:29:34.000000000","message":"Personally, I don\u0027 t like reusing the \u0027partitioner\u0027 key for this. The value for it comes in to this method as a string and then gets sets to a class. That seems confusing.","commit_id":"199ec31a0bbd35960d0e5e6f4c55fa8215421c2f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"66ca115ab37be2a5f4c19f047c35bb899d503aff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            partitioner \u003d kafka.partitioner.RoundRobinPartitioner"},{"line_number":37,"context_line":"        else:"},{"line_number":38,"context_line":"            partitioner \u003d kafka.partitioner.Murmur2Partitioner"},{"line_number":39,"context_line":"        kwargs \u003d {\u0027partitioner\u0027: partitioner}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self._kafka \u003d kafka.client.KafkaClient(url)"},{"line_number":42,"context_line":"        self._producer \u003d kafka.producer.KeyedProducer("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_bd9450e2","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":31},"in_reply_to":"9a061dce_056fecc5","updated":"2016-04-05 15:39:37.000000000","message":"That actually makes sense. \n\nI think I could replace \u0027partitioner\u0027 with boolean argument \u0027fair\u0027, by default that would be set to False, so we would use Murmur2, otherwise RoundRobin.\n\nThere is actually no other alternative, at least built in kafka, so I guess boolean value would do the trick.\n\nMy idea was to keep outer code clean of kafka.* imports, you know just to import this class, pass some flag and voila. Otherwise I would just add **kwargs here, set other defaults in it (async\u003dFalse etc) nad that would it be it. But again that misses the points of these defaults for every component that uses monasca_common.KafkaProducer, right ?","commit_id":"199ec31a0bbd35960d0e5e6f4c55fa8215421c2f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"37e28a83ffe5d0b2b572a2a864dd93421de83802","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            partitioner \u003d kafka.partitioner.RoundRobinPartitioner"},{"line_number":37,"context_line":"        else:"},{"line_number":38,"context_line":"            partitioner \u003d kafka.partitioner.Murmur2Partitioner"},{"line_number":39,"context_line":"        kwargs \u003d {\u0027partitioner\u0027: partitioner}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self._kafka \u003d kafka.client.KafkaClient(url)"},{"line_number":42,"context_line":"        self._producer \u003d kafka.producer.KeyedProducer("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_64bb3c28","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":31},"in_reply_to":"9a061dce_646ea130","updated":"2016-04-05 18:11:20.000000000","message":"Ok, so I will update this change with roundRobin boolean flag.","commit_id":"199ec31a0bbd35960d0e5e6f4c55fa8215421c2f"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"b4ba7f63e4b03f529befc8991094a3ffb3c18a77","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            partitioner \u003d kafka.partitioner.RoundRobinPartitioner"},{"line_number":37,"context_line":"        else:"},{"line_number":38,"context_line":"            partitioner \u003d kafka.partitioner.Murmur2Partitioner"},{"line_number":39,"context_line":"        kwargs \u003d {\u0027partitioner\u0027: partitioner}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self._kafka \u003d kafka.client.KafkaClient(url)"},{"line_number":42,"context_line":"        self._producer \u003d kafka.producer.KeyedProducer("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_646ea130","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":31},"in_reply_to":"9a061dce_bd9450e2","updated":"2016-04-05 16:48:53.000000000","message":"Rather than \u0027fair\u0027 why not \u0027roundRobin\u0027 so that we\u0027re explicit about what behaviour we\u0027re getting?","commit_id":"199ec31a0bbd35960d0e5e6f4c55fa8215421c2f"}]}