)]}'
{"java/monasca-common-hibernate/src/main/java/monasca/common/hibernate/db/MetricDefinitionDb.java":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"cd9db27113d20b054ac9f69ecbf530383cde7095","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    return this.sporadic;"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  public MetricDefinitionDb setSporadic(final Boolean isSporadic){"},{"line_number":89,"context_line":"    this.sporadic \u003d isSporadic;"},{"line_number":90,"context_line":"    return this;"},{"line_number":91,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":1,"id":"dab17558_74a3b400","line":88,"range":{"start_line":88,"start_character":64,"end_line":88,"end_character":66},"updated":"2016-05-10 20:33:39.000000000","message":"please, add a space after \u0027)\u0027","commit_id":"763cc9e45f40bcc05a99a45df5b1c4184ba7f61c"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"4346f8e8f863aa30e40c0b561b704fa1328c19cd","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    return this.sporadic;"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  public MetricDefinitionDb setSporadic(final Boolean isSporadic){"},{"line_number":89,"context_line":"    this.sporadic \u003d isSporadic;"},{"line_number":90,"context_line":"    return this;"},{"line_number":91,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":1,"id":"dab17558_0595bd85","line":88,"range":{"start_line":88,"start_character":64,"end_line":88,"end_character":66},"in_reply_to":"dab17558_74a3b400","updated":"2016-05-11 09:04:18.000000000","message":"Done","commit_id":"763cc9e45f40bcc05a99a45df5b1c4184ba7f61c"},{"author":{"_account_id":19861,"name":"Igor Natanael","email":"igornsa@lsd.ufcg.edu.br","username":"igorn"},"change_message_id":"402dfec8fa49831625763fff91ee928fec5e95b7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    return this.sporadic;"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  public MetricDefinitionDb setSporadic(final Boolean isSporadic) {"},{"line_number":89,"context_line":"    this.sporadic \u003d isSporadic;"},{"line_number":90,"context_line":"    return this;"},{"line_number":91,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":2,"id":"dab17558_c93d7e2c","line":88,"range":{"start_line":88,"start_character":28,"end_line":88,"end_character":39},"updated":"2016-05-11 14:16:57.000000000","message":"I believe this will be more organized if you move this method to be alongside the others setters up there.","commit_id":"6f6c03f398e07dbc7a6a6a202f82ffdbf9723286"}],"java/monasca-common-model/src/main/java/monasca/common/model/metric/Metric.java":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"cd9db27113d20b054ac9f69ecbf530383cde7095","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   * Returns the MetricDefinition."},{"line_number":65,"context_line":"   */"},{"line_number":66,"context_line":"  public MetricDefinition definition() {"},{"line_number":67,"context_line":"    if (definition \u003d\u003d null){"},{"line_number":68,"context_line":"      this.definition \u003d new MetricDefinition(name, dimensions, sporadic);"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    return definition;"}],"source_content_type":"text/x-java","patch_set":1,"id":"dab17558_b4223c50","line":67,"range":{"start_line":67,"start_character":26,"end_line":67,"end_character":28},"updated":"2016-05-10 20:33:39.000000000","message":"please, add a space character after \u0027)\u0027","commit_id":"763cc9e45f40bcc05a99a45df5b1c4184ba7f61c"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"4346f8e8f863aa30e40c0b561b704fa1328c19cd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   * Returns the MetricDefinition."},{"line_number":65,"context_line":"   */"},{"line_number":66,"context_line":"  public MetricDefinition definition() {"},{"line_number":67,"context_line":"    if (definition \u003d\u003d null){"},{"line_number":68,"context_line":"      this.definition \u003d new MetricDefinition(name, dimensions, sporadic);"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    return definition;"}],"source_content_type":"text/x-java","patch_set":1,"id":"dab17558_05dc9d71","line":67,"range":{"start_line":67,"start_character":26,"end_line":67,"end_character":28},"in_reply_to":"dab17558_b4223c50","updated":"2016-05-11 09:04:18.000000000","message":"Done","commit_id":"763cc9e45f40bcc05a99a45df5b1c4184ba7f61c"}],"java/monasca-common-model/src/main/java/monasca/common/model/metric/MetricDefinition.java":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"cd9db27113d20b054ac9f69ecbf530383cde7095","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return false;"},{"line_number":80,"context_line":"    } else if (!name.equals(other.name))"},{"line_number":81,"context_line":"      return false;"},{"line_number":82,"context_line":"    if(this.sporadic !\u003d ((MetricDefinition) obj).sporadic){"},{"line_number":83,"context_line":"      return false;"},{"line_number":84,"context_line":"    }"},{"line_number":85,"context_line":"    return true;"}],"source_content_type":"text/x-java","patch_set":1,"id":"dab17558_d44420b8","line":82,"range":{"start_line":82,"start_character":57,"end_line":82,"end_character":59},"updated":"2016-05-10 20:33:39.000000000","message":"please, add a character space after \u0027)\u0027","commit_id":"763cc9e45f40bcc05a99a45df5b1c4184ba7f61c"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"4346f8e8f863aa30e40c0b561b704fa1328c19cd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return false;"},{"line_number":80,"context_line":"    } else if (!name.equals(other.name))"},{"line_number":81,"context_line":"      return false;"},{"line_number":82,"context_line":"    if(this.sporadic !\u003d ((MetricDefinition) obj).sporadic){"},{"line_number":83,"context_line":"      return false;"},{"line_number":84,"context_line":"    }"},{"line_number":85,"context_line":"    return true;"}],"source_content_type":"text/x-java","patch_set":1,"id":"dab17558_a53af196","line":82,"range":{"start_line":82,"start_character":57,"end_line":82,"end_character":59},"in_reply_to":"dab17558_d44420b8","updated":"2016-05-11 09:04:18.000000000","message":"Done","commit_id":"763cc9e45f40bcc05a99a45df5b1c4184ba7f61c"}],"java/monasca-common-model/src/test/java/monasca/common/model/metric/MetricsTest.java":[{"author":{"_account_id":15359,"name":"Erickson Filipe Guedes dos Santos","email":"erickson@lsd.ufcg.edu.br","username":"ericksonfilipe"},"change_message_id":"cd9db27113d20b054ac9f69ecbf530383cde7095","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    final Metric m2 \u003d Metrics.fromJson(Metrics.toJson(m1).getBytes(\"UTF-8\"));"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    assertEquals("},{"line_number":164,"context_line":"        m1.isSporadic(),"},{"line_number":165,"context_line":"        m2.isSporadic()"},{"line_number":166,"context_line":"    );"}],"source_content_type":"text/x-java","patch_set":1,"id":"dab17558_9fd3d103","line":163,"range":{"start_line":163,"start_character":4,"end_line":163,"end_character":16},"updated":"2016-05-10 20:33:39.000000000","message":"Just a suggestion:\n\nI believe a better assert here would be to create m2 with the same values but not being sporadic and test if m2 is equal to m1.\n\nOr, insted of removing this assertEquals, you may use m2.setSporadic(false) and then have the assertNotEquals.","commit_id":"763cc9e45f40bcc05a99a45df5b1c4184ba7f61c"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"4346f8e8f863aa30e40c0b561b704fa1328c19cd","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    final Metric m2 \u003d Metrics.fromJson(Metrics.toJson(m1).getBytes(\"UTF-8\"));"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    assertEquals("},{"line_number":164,"context_line":"        m1.isSporadic(),"},{"line_number":165,"context_line":"        m2.isSporadic()"},{"line_number":166,"context_line":"    );"}],"source_content_type":"text/x-java","patch_set":1,"id":"dab17558_65c80975","line":163,"range":{"start_line":163,"start_character":4,"end_line":163,"end_character":16},"in_reply_to":"dab17558_9fd3d103","updated":"2016-05-11 09:04:18.000000000","message":"Well, this actually is about serialization, so as you can see above second metric is created from json body of the first one. So the case is to verify if sporadic\u003dtrue, which is not default value, was serialized and deserialized.","commit_id":"763cc9e45f40bcc05a99a45df5b1c4184ba7f61c"}]}