)]}'
{"monasca_common/kafka/consumer.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"98a7090fbddfba49da1963de7bb4ff152ffbccfc","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"DEFAULT_KAFKA_CONSUMER_ITER_TIMEOUT \u003d 5"},{"line_number":48,"context_line":"DEFAULT_KAFKA_FETCH_SIZE \u003d 1048576"},{"line_number":49,"context_line":"DEFAULT_COMMIT_TIMEOUT \u003d 30"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class KafkaConsumer(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_8dabe788","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":22},"updated":"2016-05-14 19:00:17.000000000","message":"Naming these variables DEFAULT_ makes sense to me if we have the ability to override what they\u0027re assigned to.  fetch_size and commit_timeout both have that ability now but iter_timeout does not.\n\nIf we\u0027re going to give the impression that these pieces are configurable I\u0027d prefer to see an keyword argument to _create_kafka_consumer that allows you to override the iter_timeout variable.","commit_id":"dfed0bbae3a635247b66b4bc52de139c9b346f10"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"827128a4b91ec229530d6fd99022120089593260","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"DEFAULT_KAFKA_CONSUMER_ITER_TIMEOUT \u003d 5"},{"line_number":48,"context_line":"DEFAULT_KAFKA_FETCH_SIZE \u003d 1048576"},{"line_number":49,"context_line":"DEFAULT_COMMIT_TIMEOUT \u003d 30"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class KafkaConsumer(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_4e80878b","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":22},"in_reply_to":"dab17558_8dabe788","updated":"2016-05-17 07:12:02.000000000","message":"Thanks. Good point. I\u0027ll lose the DEFAULT_ prefix when the value is not configurable from outside.","commit_id":"dfed0bbae3a635247b66b4bc52de139c9b346f10"}],"monasca_common/kafka/producer.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"8df005b08a51f61246a0ada257f46df12b8b921c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_KAFKA_PRODUCER_ACK_TIMEOUT \u003d 2000"},{"line_number":24,"context_line":"SECOND \u003d 1000"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class KafkaProducer(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_dacad5a0","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":6},"updated":"2016-05-13 20:44:28.000000000","message":"I\u0027d prefer\n  \n ONE_SECOND","commit_id":"2ba2b135078698b1764465fad8364360b6043e54"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"8374eb82feed9b79410b98253c421f2996ba84c3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_KAFKA_PRODUCER_ACK_TIMEOUT \u003d 2000"},{"line_number":24,"context_line":"SECOND \u003d 1000"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class KafkaProducer(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_e78bb466","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":6},"in_reply_to":"dab17558_dacad5a0","updated":"2016-05-14 12:47:30.000000000","message":"Done","commit_id":"2ba2b135078698b1764465fad8364360b6043e54"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"d5e2a9eca8356019d8b574ea68aadfe2839dfbc6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_KAFKA_PRODUCER_ACK_TIMEOUT \u003d 2000"},{"line_number":24,"context_line":"ONE_SECOND \u003d 1000"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class KafkaProducer(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_a7208cb1","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":10},"updated":"2016-05-14 14:27:01.000000000","message":"I don\u0027t agree with this name.  This value is used to convert a timestamp to milliseconds.  It has nothing to do with seconds and the constant name makes the code that uses it misleading.  We\u0027re not multiplying anything by one second we\u0027re multiplying by 1000 milliseconds.\n\nI\u0027d prefer not to have a constant for this as I think \"timestamp * 1000\" is clear and it\u0027s not something we should be changing.\n\nIf you want to add more clarity a to_milliseconds function may be preferable but that seems like a lot of overhead for a common bit of code.","commit_id":"5434697c566b427a712f912f775e85f2334194d7"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"6297241045ac6cfcc5ed6f94d90f881ccdff8ee5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_KAFKA_PRODUCER_ACK_TIMEOUT \u003d 2000"},{"line_number":24,"context_line":"ONE_SECOND \u003d 1000"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class KafkaProducer(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_2dd3db60","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":10},"in_reply_to":"dab17558_a7208cb1","updated":"2016-05-14 18:11:40.000000000","message":"You make a good point. I wasn\u0027t totally sure what to name it at first. MILISECONDS_IN_A_SECOND would be about right, but that\u0027s a bit ugly.\nSince there is almost no chance that its value will change, I am okay with using 1000 in the code, so I reset the original expression.","commit_id":"5434697c566b427a712f912f775e85f2334194d7"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"98a7090fbddfba49da1963de7bb4ff152ffbccfc","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_KAFKA_PRODUCER_ACK_TIMEOUT \u003d 2000"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class KafkaProducer(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_6dae8399","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":34},"updated":"2016-05-14 19:00:17.000000000","message":"Same comment here as in the consumer.","commit_id":"dfed0bbae3a635247b66b4bc52de139c9b346f10"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"827128a4b91ec229530d6fd99022120089593260","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"log \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DEFAULT_KAFKA_PRODUCER_ACK_TIMEOUT \u003d 2000"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class KafkaProducer(object):"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_8e4c2f9f","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":34},"in_reply_to":"dab17558_6dae8399","updated":"2016-05-17 07:12:02.000000000","message":"Done","commit_id":"dfed0bbae3a635247b66b4bc52de139c9b346f10"}]}