)]}'
{"java/monasca-common-middleware/src/main/java/monasca/common/middleware/TokenCache.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"a9976792a5b189dab538b8969d3a4caf91dbdeee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (c) 2014,2016 Hewlett Packard Enterprise Development LP"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":2,"id":"9ad45d7e_50b5302f","line":2,"range":{"start_line":2,"start_character":13,"end_line":2,"end_character":14},"updated":"2016-08-09 15:21:34.000000000","message":"(c) goes in the front","commit_id":"760e8157ff3e5ea63b7945771c4064a4fb09787e"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"1ba94d1b810b8282f3cc7291b0a550ed909c81be","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            value \u003d client.validateTokenForServiceEndpointV3(key);"},{"line_number":50,"context_line":"          } catch (ClientProtocolException e) {"},{"line_number":51,"context_line":"            factory.discard(client);"},{"line_number":52,"context_line":"            logger.warn(\"Validate token failed with ClientProtocolException. Discarding AuthClient connection from pool to create a new connection.\");"},{"line_number":53,"context_line":"            discarded \u003d true;"},{"line_number":54,"context_line":"            throw e;"},{"line_number":55,"context_line":"          } finally {"}],"source_content_type":"text/x-java","patch_set":3,"id":"9ad45d7e_2a83e805","line":52,"range":{"start_line":52,"start_character":24,"end_line":52,"end_character":148},"updated":"2016-08-09 16:09:20.000000000","message":"Would be useful to log some details on the Exception for later debugging","commit_id":"b9d1eda56eefc59a9bce94347aa6f054aac39fec"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"77685eaaf58bd2acf14b668b4725da443690004d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            value \u003d client.validateTokenForServiceEndpointV3(key);"},{"line_number":50,"context_line":"          } catch (ClientProtocolException e) {"},{"line_number":51,"context_line":"            factory.discard(client);"},{"line_number":52,"context_line":"            logger.warn(\"Validate token failed with ClientProtocolException. Discarding AuthClient connection from pool to create a new connection.\");"},{"line_number":53,"context_line":"            discarded \u003d true;"},{"line_number":54,"context_line":"            throw e;"},{"line_number":55,"context_line":"          } finally {"}],"source_content_type":"text/x-java","patch_set":3,"id":"9ad45d7e_831c7fc2","line":52,"range":{"start_line":52,"start_character":24,"end_line":52,"end_character":148},"in_reply_to":"9ad45d7e_2a83e805","updated":"2016-08-09 16:59:56.000000000","message":"When i rethrow the exception, it is already being logged as an Error by the TokenExceptionHandler.  I could do it here as well.","commit_id":"b9d1eda56eefc59a9bce94347aa6f054aac39fec"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"e4a0178083afcebc6fb78d719daebfa9f025b30e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            value \u003d client.validateTokenForServiceEndpointV3(key);"},{"line_number":50,"context_line":"          } catch (ClientProtocolException e) {"},{"line_number":51,"context_line":"            factory.discard(client);"},{"line_number":52,"context_line":"            logger.warn(\"Validate token failed with ClientProtocolException. Discarding AuthClient connection from pool to create a new connection.\");"},{"line_number":53,"context_line":"            discarded \u003d true;"},{"line_number":54,"context_line":"            throw e;"},{"line_number":55,"context_line":"          } finally {"}],"source_content_type":"text/x-java","patch_set":3,"id":"9ad45d7e_8b4e516d","line":52,"range":{"start_line":52,"start_character":24,"end_line":52,"end_character":148},"in_reply_to":"9ad45d7e_831c7fc2","updated":"2016-08-09 18:33:12.000000000","message":"No, the handling in TokenExceptionHandler is sufficient","commit_id":"b9d1eda56eefc59a9bce94347aa6f054aac39fec"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6d11cd2f1c1fa6f40ab4d007b02d9bac6df39d62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * (c) Copyright 2014,2016 Hewlett Packard Enterprise Development LP"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":4,"id":"1ac06dbe_ea73c34b","line":2,"range":{"start_line":2,"start_character":4,"end_line":2,"end_character":5},"updated":"2016-08-19 18:51:02.000000000","message":"This is supposed to be a capital C","commit_id":"46c2a29d6a5fefc8ae5c8490ad935c1714421cdc"}]}