)]}'
{"docker/Dockerfile":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"af3b73bb45bfe103411f7ec99bdee91f99e43dd4","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                    -o \\( -type f -a \\( -name \u0027*.pyc\u0027 -o -name \u0027*.pyo\u0027 \\) \\) \\"},{"line_number":130,"context_line":"                \\) -exec rm -rf \u0027{}\u0027 +"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"ONBUILD HEALTHCHECK --interval\u003d5s --timeout\u003d2s \\"},{"line_number":133,"context_line":"                   CMD python3 health_check.py || exit 1"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"ENTRYPOINT [\"/sbin/tini\", \"-s\", \"--\"]"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"5f7c97a3_eba827db","line":132,"updated":"2018-07-25 12:55:35.000000000","message":"Why do we need this? Could you add motivation in commit message or story?\n\nThese periods are applicable to all child images, right? Are they reasonable in all cases? Could we just use default values (30s)?","commit_id":"cf77c5f25fa8afa95a1328f5d523d7e15f4e000e"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"9b949c2c7282f47623bbf8e9509e82a83f7f9d85","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                    -o \\( -type f -a \\( -name \u0027*.pyc\u0027 -o -name \u0027*.pyo\u0027 \\) \\) \\"},{"line_number":130,"context_line":"                \\) -exec rm -rf \u0027{}\u0027 +"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"ONBUILD HEALTHCHECK --interval\u003d5s --timeout\u003d2s \\"},{"line_number":133,"context_line":"                   CMD python3 health_check.py || exit 1"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"ENTRYPOINT [\"/sbin/tini\", \"-s\", \"--\"]"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"5f7c97a3_63a66557","line":132,"in_reply_to":"5f7c97a3_2e094ddb","updated":"2018-07-26 12:05:34.000000000","message":"Done","commit_id":"cf77c5f25fa8afa95a1328f5d523d7e15f4e000e"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"ce29c3247c6fad462484524aed3db48574156ca4","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                    -o \\( -type f -a \\( -name \u0027*.pyc\u0027 -o -name \u0027*.pyo\u0027 \\) \\) \\"},{"line_number":130,"context_line":"                \\) -exec rm -rf \u0027{}\u0027 +"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"ONBUILD HEALTHCHECK --interval\u003d5s --timeout\u003d2s \\"},{"line_number":133,"context_line":"                   CMD python3 health_check.py || exit 1"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"ENTRYPOINT [\"/sbin/tini\", \"-s\", \"--\"]"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"5f7c97a3_2e094ddb","line":132,"in_reply_to":"5f7c97a3_abed4fb9","updated":"2018-07-25 13:51:31.000000000","message":"Fine, please add motivation to the commit message.","commit_id":"cf77c5f25fa8afa95a1328f5d523d7e15f4e000e"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"9c59f49835b5f7b7b2a3442eba22561fdbb8cd2c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                    -o \\( -type f -a \\( -name \u0027*.pyc\u0027 -o -name \u0027*.pyo\u0027 \\) \\) \\"},{"line_number":130,"context_line":"                \\) -exec rm -rf \u0027{}\u0027 +"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"ONBUILD HEALTHCHECK --interval\u003d5s --timeout\u003d2s \\"},{"line_number":133,"context_line":"                   CMD python3 health_check.py || exit 1"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"ENTRYPOINT [\"/sbin/tini\", \"-s\", \"--\"]"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"5f7c97a3_abed4fb9","line":132,"in_reply_to":"5f7c97a3_eba827db","updated":"2018-07-25 13:12:01.000000000","message":"5 min that I added previously was copy/paste from official docs. When I started reading more about health checks most real world examples was using around 5s for interval. By default docker will show if service is unhealthy after 3 intervals return error. So in previous timing service would be taken out of poll (by e.g. docker swarm) after 15 min. For all this time it would be returning errors for any communication to it. Now it will be removed from poll of running services after 15 seconds. Much better.\n\nRegarding timeout more examples was using something shorter. For all services we are using I think that if anything respond longer than 2 seconds then something is wrong with this service. Monasca is not web service but back-end service that should have high throughput.","commit_id":"cf77c5f25fa8afa95a1328f5d523d7e15f4e000e"}]}