)]}'
{"docker/Dockerfile":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"b5a2bc680a49b91d50fdc5f5e894ee45bb4da787","unresolved":false,"context_lines":[{"line_number":44,"context_line":"ONBUILD ARG REPO_VERSION"},{"line_number":45,"context_line":"ONBUILD ARG GIT_COMMIT"},{"line_number":46,"context_line":"ONBUILD ARG CONSTRAINTS_BRANCH"},{"line_number":47,"context_line":"ONBUILD ARG CONSTRAINTS_FILE\u003dhttp://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt"},{"line_number":48,"context_line":"ONBUILD ARG EXTRA_DEPS"},{"line_number":49,"context_line":"ONBUILD ARG COMMON_REPO\u003dhttps://git.openstack.org/openstack/monasca-common"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Build-time metadata as defined at"},{"line_number":52,"context_line":"# https://github.com/opencontainers/image-spec/blob/master/annotations.md"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"5f7c97a3_ce6c22d1","side":"PARENT","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":74},"updated":"2018-07-27 13:06:44.000000000","message":"I though that this allow us to set default values for them and user will be able to overwrite it if needed from child image Dockerfile.\nBut it\u0027s not working...\nIt\u0027s possible to overwrite them only with `docker build --build-agr`.\nSo I moved this default values to `example/build_image.sh`.\nYes, all child images need to update they implementations of this file. Sorry.\n\nBut with this user could provide all this data (if he want to) in child Dockerfile (without changing build_image.sh).","commit_id":"55dbc317ff74bf4815dfeab1166487c777573ef8"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"5c81b1ad5310f4b658136341c74bd31d1bc0922e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            git -C /monasca-common fetch origin \"$COMMON_VERSION\" \u0026\u0026 \\"},{"line_number":100,"context_line":"            git -C /monasca-common reset --hard FETCH_HEAD \u0026\u0026 \\"},{"line_number":101,"context_line":"            # When creating image from master, stable branch or commit use"},{"line_number":102,"context_line":"            # monasca-common from git repository in /monasca-common."},{"line_number":103,"context_line":"            [ ! \"$(git -C /app tag -l ${REPO_VERSION})\" ] \u0026\u0026 \\"},{"line_number":104,"context_line":"                sed -i \"s|monasca-common.*||\" \\"},{"line_number":105,"context_line":"                    /app/requirements.txt || true \u0026\u0026 \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"5f7c97a3_c26ef8fc","line":102,"range":{"start_line":102,"start_character":67,"end_line":102,"end_character":68},"updated":"2018-07-31 14:27:27.000000000","message":", otherwise use the version from upper-constraints.txt","commit_id":"da7ed749170fb23192a1a41ed21b3380a1dfcbb5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"6d8f87f873ab32342ecd41e51593b22eb9366505","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            git -C /monasca-common fetch origin \"$COMMON_VERSION\" \u0026\u0026 \\"},{"line_number":100,"context_line":"            git -C /monasca-common reset --hard FETCH_HEAD \u0026\u0026 \\"},{"line_number":101,"context_line":"            # When creating image from master, stable branch or commit use"},{"line_number":102,"context_line":"            # monasca-common from git repository in /monasca-common."},{"line_number":103,"context_line":"            [ ! \"$(git -C /app tag -l ${REPO_VERSION})\" ] \u0026\u0026 \\"},{"line_number":104,"context_line":"                sed -i \"s|monasca-common.*||\" \\"},{"line_number":105,"context_line":"                    /app/requirements.txt || true \u0026\u0026 \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"5f7c97a3_de6f8290","line":102,"range":{"start_line":102,"start_character":67,"end_line":102,"end_character":68},"in_reply_to":"5f7c97a3_c26ef8fc","updated":"2018-08-02 09:48:32.000000000","message":"Done","commit_id":"da7ed749170fb23192a1a41ed21b3380a1dfcbb5"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"5c81b1ad5310f4b658136341c74bd31d1bc0922e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                \"$COMMON_GIT_COMMIT\" \u003e\u003e /VERSIONS \u0026\u0026 \\"},{"line_number":135,"context_line":"            printf \"Constraints file: %s\\\\n\" \\"},{"line_number":136,"context_line":"                \"$CONSTRAINTS_FILE\"?h\u003d\"$CONSTRAINTS_BRANCH\" \u003e\u003e /VERSIONS \u0026\u0026 \\"},{"line_number":137,"context_line":"            # Clean after instalation."},{"line_number":138,"context_line":"            # apk del .build-deps \u0026\u0026 \\"},{"line_number":139,"context_line":"            # rm -rf \\"},{"line_number":140,"context_line":"            #     /app \\"},{"line_number":141,"context_line":"            #     /root/.cache/ \\"},{"line_number":142,"context_line":"            #     /monasca-common/java/ \\"},{"line_number":143,"context_line":"            #     /tmp/* \\"},{"line_number":144,"context_line":"            #     /var/cache/apk/* \\"},{"line_number":145,"context_line":"            #     /var/log/* \u0026\u0026 \\"},{"line_number":146,"context_line":"            # Remove all Python pyc and pyo files."},{"line_number":147,"context_line":"            find /usr/local -depth \\"},{"line_number":148,"context_line":"                \\( \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"5f7c97a3_f9ebaa0d","line":145,"range":{"start_line":137,"start_character":12,"end_line":145,"end_character":33},"updated":"2018-07-31 14:27:27.000000000","message":"Don\u0027t we need it anymore?","commit_id":"da7ed749170fb23192a1a41ed21b3380a1dfcbb5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"6d8f87f873ab32342ecd41e51593b22eb9366505","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                \"$COMMON_GIT_COMMIT\" \u003e\u003e /VERSIONS \u0026\u0026 \\"},{"line_number":135,"context_line":"            printf \"Constraints file: %s\\\\n\" \\"},{"line_number":136,"context_line":"                \"$CONSTRAINTS_FILE\"?h\u003d\"$CONSTRAINTS_BRANCH\" \u003e\u003e /VERSIONS \u0026\u0026 \\"},{"line_number":137,"context_line":"            # Clean after instalation."},{"line_number":138,"context_line":"            # apk del .build-deps \u0026\u0026 \\"},{"line_number":139,"context_line":"            # rm -rf \\"},{"line_number":140,"context_line":"            #     /app \\"},{"line_number":141,"context_line":"            #     /root/.cache/ \\"},{"line_number":142,"context_line":"            #     /monasca-common/java/ \\"},{"line_number":143,"context_line":"            #     /tmp/* \\"},{"line_number":144,"context_line":"            #     /var/cache/apk/* \\"},{"line_number":145,"context_line":"            #     /var/log/* \u0026\u0026 \\"},{"line_number":146,"context_line":"            # Remove all Python pyc and pyo files."},{"line_number":147,"context_line":"            find /usr/local -depth \\"},{"line_number":148,"context_line":"                \\( \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"5f7c97a3_3e0a36cf","line":145,"range":{"start_line":137,"start_character":12,"end_line":145,"end_character":33},"in_reply_to":"5f7c97a3_f9ebaa0d","updated":"2018-08-02 09:48:32.000000000","message":"Ugh, yes. I forgot to uncomment it after debugging.","commit_id":"da7ed749170fb23192a1a41ed21b3380a1dfcbb5"}],"docker/example/build_image.sh":[{"author":{"_account_id":16253,"name":"Christian Brandstetter","email":"christian.brandstetter@est.fujitsu.com","username":"christianB"},"change_message_id":"91a4f72cb81882de09f86b7d400837a2a3fca909","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -x  # Print each script step."},{"line_number":20,"context_line":"set -eo pipefail  # Exit the script if any statement returns error."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# This script is used for building Docker image with proper labels."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Example usage:"},{"line_number":25,"context_line":"# $ ./build_image.sh \u003crepository_version\u003e \u003cupper_constains_branch\u003e"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_5d3d0f8b","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":67},"updated":"2018-07-30 06:54:08.000000000","message":"please add description for monasca-common","commit_id":"da7ed749170fb23192a1a41ed21b3380a1dfcbb5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"6d8f87f873ab32342ecd41e51593b22eb9366505","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -x  # Print each script step."},{"line_number":20,"context_line":"set -eo pipefail  # Exit the script if any statement returns error."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# This script is used for building Docker image with proper labels."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Example usage:"},{"line_number":25,"context_line":"# $ ./build_image.sh \u003crepository_version\u003e \u003cupper_constains_branch\u003e"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_decb0270","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":67},"in_reply_to":"5f7c97a3_5d3d0f8b","updated":"2018-08-02 09:48:32.000000000","message":"I\u0027m not sure what to write here so only added short info. If you have better idea I\u0027m open to change it.","commit_id":"da7ed749170fb23192a1a41ed21b3380a1dfcbb5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"d0682e6fdb05864d43c99f71baa136ef900bf7b7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -x  # Print each script step."},{"line_number":20,"context_line":"set -eo pipefail  # Exit the script if any statement returns error."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# This script is used for building Docker image with proper labels."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Example usage:"},{"line_number":25,"context_line":"# $ ./build_image.sh \u003crepository_version\u003e \u003cupper_constains_branch\u003e"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_45437f13","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":67},"in_reply_to":"5f7c97a3_77753196","updated":"2018-08-03 12:30:03.000000000","message":"With this comment I found bug in handling of docker labels (and probably installing) in case we want to build child image from tag. Now it don\u0027t save proper data and making it save it properly will make it even more confusing.","commit_id":"da7ed749170fb23192a1a41ed21b3380a1dfcbb5"},{"author":{"_account_id":16253,"name":"Christian Brandstetter","email":"christian.brandstetter@est.fujitsu.com","username":"christianB"},"change_message_id":"955ab3a9951297fb8534b0b86e24f232e3f0dd2e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -x  # Print each script step."},{"line_number":20,"context_line":"set -eo pipefail  # Exit the script if any statement returns error."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# This script is used for building Docker image with proper labels."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Example usage:"},{"line_number":25,"context_line":"# $ ./build_image.sh \u003crepository_version\u003e \u003cupper_constains_branch\u003e"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5f7c97a3_77753196","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":67},"in_reply_to":"5f7c97a3_decb0270","updated":"2018-08-02 11:54:18.000000000","message":"# Example usage:\n# $ ./build_image.sh \u003crepository_version\u003e \u003cupper_constains_branch\u003e\n\nwell, here we have to handle two repositories:\n- monasca-common repo\n- child repo\n\nI would expect something like that:\n# Example usage:\n# $ ./build_image.sh \u003cbase_repo_version\u003e \u003cchild_repo_version\u003e \u003cupper_constains_branch\u003e\nOk, monasca-common is handled tricky (maybe too tricky?) with \"upper_constains_branch\"...so I guess this is worth some comment...\n\nmaybe like that:\n# Example usage:\n# $ ./build_image.sh \u003crepository_version\u003e \u003cupper_constains_branch\u003e\n#\n# child: \"repository_version\" of child repository. Image can be build with:\n#       - version tag, e.g. 2.5.0\n#       - Gerrit patch set, e.g. refs/changes/51/558751/1\n#       - branch, e.g. stable/queens\n#\n# base: monasca-common will be taken from \"upper_constains_branch\" file.\n#       File will be adapted to build monasca-common library with:\n#       - version tag, e.g. 2.5.0\n#       - Gerrit patch set, e.g. refs/changes/51/558751/1\n#       - branch, e.g. stable/queens\n#\n...","commit_id":"da7ed749170fb23192a1a41ed21b3380a1dfcbb5"}]}