)]}'
{"monasca_common/confluent_kafka/consumer.py":[{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"a3b0dfc043975299b0052291a1b0c0d1a961e8bb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self._last_commit \u003d datetime.datetime.now()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        while True:"},{"line_number":66,"context_line":"            message \u003d self._consumer.poll(5)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            if message is None:"},{"line_number":69,"context_line":"                time.sleep(0.1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_1e8f5fcd","line":66,"updated":"2019-02-28 11:42:29.000000000","message":"Magic number. In my opinion is better to describe such number. For example\n_consumer.poll(timeout\u003d5)","commit_id":"832e86357e919753a1863169ecf7d0898857ee92"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"65543c77e7e70699f248c117722a8c9eca8f6b28","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self._last_commit \u003d datetime.datetime.now()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        while True:"},{"line_number":66,"context_line":"            message \u003d self._consumer.poll(5)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            if message is None:"},{"line_number":69,"context_line":"                time.sleep(0.1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_32d61751","line":66,"in_reply_to":"9fdfeff1_1e8f5fcd","updated":"2019-02-28 11:50:33.000000000","message":"Good point.","commit_id":"832e86357e919753a1863169ecf7d0898857ee92"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"ead61ee398dec567de97274cb9f56f211ac86a9e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            if self._commit_callback:"},{"line_number":78,"context_line":"                time_now \u003d datetime.datetime.now()"},{"line_number":79,"context_line":"                time_delta \u003d time_now - self._last_commit"},{"line_number":80,"context_line":"                if time_delta.total_seconds() \u003e self._max_commit_interval:"},{"line_number":81,"context_line":"                    self._commit_callback()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def commit(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_bc53b615","line":80,"range":{"start_line":80,"start_character":48,"end_line":80,"end_character":73},"updated":"2019-02-28 15:27:51.000000000","message":"Being pedantic since I think time_delta.total_seconds() is fractional, time_delta.total_seconds() could return 29.999 and then this goes round another loop and the commit_callback runs after max_commit_interval seconds, especially if self._consumer.poll() blocks for a few seconds. I suppose we could subtract the max delay, or I could stop bike shedding :)","commit_id":"c542d908f1d05790c38d910508110dbab70938bd"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"7b05c13bd12fbd10b84ad37d3ef33e0cc2a8336b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            if self._commit_callback:"},{"line_number":78,"context_line":"                time_now \u003d datetime.datetime.now()"},{"line_number":79,"context_line":"                time_delta \u003d time_now - self._last_commit"},{"line_number":80,"context_line":"                if time_delta.total_seconds() \u003e self._max_commit_interval:"},{"line_number":81,"context_line":"                    self._commit_callback()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def commit(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_374cc1c6","line":80,"range":{"start_line":80,"start_character":48,"end_line":80,"end_character":73},"in_reply_to":"9fdfeff1_bc53b615","updated":"2019-02-28 16:05:49.000000000","message":"Yes, you\u0027re right that the variable name and argument documentation are not quite consistent with that logic. The logic though is the same as in the old wrapper. I have renamed the variable from `commit_timeout` which was somewhat confusing to `max_commit_interval` which is not perfect either as you\u0027ve found out.","commit_id":"c542d908f1d05790c38d910508110dbab70938bd"}],"monasca_common/tests/test_confluent_kafka.py":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"ab981c6d3946001058fc3dcdf3982bd348984aba","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def setUp(self, mock_confluent_consumer):"},{"line_number":102,"context_line":"        super(TestConfluentKafkaConsumer, self).setUp()"},{"line_number":103,"context_line":"        self.mock_confluent_consumer \u003d mock_confluent_consumer"},{"line_number":104,"context_line":"        self.consumer \u003d consumer.KafkaConsumer([\u0027fake_serer1\u0027,"},{"line_number":105,"context_line":"                                                \u0027fake_server2\u0027],"},{"line_number":106,"context_line":"                                               \u0027fake_group\u0027,"},{"line_number":107,"context_line":"                                               FAKE_KAFKA_TOPIC, 128,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_7e3a2b34","line":104,"range":{"start_line":104,"start_character":54,"end_line":104,"end_character":59},"updated":"2019-02-28 11:33:41.000000000","message":"server","commit_id":"832e86357e919753a1863169ecf7d0898857ee92"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"65543c77e7e70699f248c117722a8c9eca8f6b28","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def setUp(self, mock_confluent_consumer):"},{"line_number":102,"context_line":"        super(TestConfluentKafkaConsumer, self).setUp()"},{"line_number":103,"context_line":"        self.mock_confluent_consumer \u003d mock_confluent_consumer"},{"line_number":104,"context_line":"        self.consumer \u003d consumer.KafkaConsumer([\u0027fake_serer1\u0027,"},{"line_number":105,"context_line":"                                                \u0027fake_server2\u0027],"},{"line_number":106,"context_line":"                                               \u0027fake_group\u0027,"},{"line_number":107,"context_line":"                                               FAKE_KAFKA_TOPIC, 128,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_92dd8371","line":104,"range":{"start_line":104,"start_character":54,"end_line":104,"end_character":59},"in_reply_to":"9fdfeff1_7e3a2b34","updated":"2019-02-28 11:50:33.000000000","message":"Done","commit_id":"832e86357e919753a1863169ecf7d0898857ee92"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"ab981c6d3946001058fc3dcdf3982bd348984aba","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_kafka_consumer_init(self):"},{"line_number":125,"context_line":"        expected_config \u003d {\u0027group.id\u0027: \u0027fake_group\u0027,"},{"line_number":126,"context_line":"                           \u0027bootstrap.servers\u0027: [\u0027fake_serer1\u0027,"},{"line_number":127,"context_line":"                                                 \u0027fake_server2\u0027],"},{"line_number":128,"context_line":"                           \u0027fetch.min.bytes\u0027: 128,"},{"line_number":129,"context_line":"                           \u0027client.id\u0027: \u0027test_client\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_7e230b06","line":126,"range":{"start_line":126,"start_character":55,"end_line":126,"end_character":60},"updated":"2019-02-28 11:33:41.000000000","message":"server","commit_id":"832e86357e919753a1863169ecf7d0898857ee92"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"65543c77e7e70699f248c117722a8c9eca8f6b28","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_kafka_consumer_init(self):"},{"line_number":125,"context_line":"        expected_config \u003d {\u0027group.id\u0027: \u0027fake_group\u0027,"},{"line_number":126,"context_line":"                           \u0027bootstrap.servers\u0027: [\u0027fake_serer1\u0027,"},{"line_number":127,"context_line":"                                                 \u0027fake_server2\u0027],"},{"line_number":128,"context_line":"                           \u0027fetch.min.bytes\u0027: 128,"},{"line_number":129,"context_line":"                           \u0027client.id\u0027: \u0027test_client\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b2d8c77e","line":126,"range":{"start_line":126,"start_character":55,"end_line":126,"end_character":60},"in_reply_to":"9fdfeff1_7e230b06","updated":"2019-02-28 11:50:33.000000000","message":"Done","commit_id":"832e86357e919753a1863169ecf7d0898857ee92"}]}
