)]}'
{".zuul.yaml":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"f2f17ecd1b78cfd939a5a6ae331a56da1afcf10c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      - ^doc/.*$"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- job:"},{"line_number":52,"context_line":"    name: build-monasca-common-docker-service-image"},{"line_number":53,"context_line":"    run: playbooks/docker_build_service.yml"},{"line_number":54,"context_line":"    required-projects:"},{"line_number":55,"context_line":"      - openstack/monasca-common"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_675ad2f2","line":52,"range":{"start_line":52,"start_character":10,"end_line":52,"end_character":51},"updated":"2019-04-08 14:41:34.000000000","message":"I think `build-monasca-docker-image` would fit better the guidance rules.\nIn particular I find using `monasca-common` misleading as the job is used in other components to build e.g. monasca-api image.","commit_id":"5885d6b06ff6689673239e08a60526e2c3d68d45"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"03103374af6ce6f87ae476fb79e23ee654729489","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      - ^doc/.*$"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- job:"},{"line_number":52,"context_line":"    name: build-monasca-common-docker-service-image"},{"line_number":53,"context_line":"    run: playbooks/docker_build_service.yml"},{"line_number":54,"context_line":"    required-projects:"},{"line_number":55,"context_line":"      - openstack/monasca-common"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_e38ea42c","line":52,"range":{"start_line":52,"start_character":10,"end_line":52,"end_character":51},"in_reply_to":"5fc1f717_3897fb47","updated":"2019-04-09 07:57:20.000000000","message":"Most of OpenStack projects have simpler repository structure than Monasca. I assume the cited sentence refers to something like: `gate-tempest-dsvm-neutron-full-ssh` should be renamed to `tempest-neutron-full-ssh`. The goal of the guidance is to make the naming intuitive and consistent.\n\nI would agree with your point if we had individual jobs for every component like `build-monasca-api-docker-image`, `build-monasca-persister-docker-image` etc. In our case we have a job which has really nothing to do with `monasca-common` repo apart from the fact that it lives there.","commit_id":"5885d6b06ff6689673239e08a60526e2c3d68d45"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"726f0000bed13e983de8fd65e293356aa8f9ccdf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      - ^doc/.*$"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- job:"},{"line_number":52,"context_line":"    name: build-monasca-common-docker-service-image"},{"line_number":53,"context_line":"    run: playbooks/docker_build_service.yml"},{"line_number":54,"context_line":"    required-projects:"},{"line_number":55,"context_line":"      - openstack/monasca-common"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_3897fb47","line":52,"range":{"start_line":52,"start_character":10,"end_line":52,"end_character":51},"in_reply_to":"5fc1f717_675ad2f2","updated":"2019-04-09 06:42:17.000000000","message":"What about this point?\n\n`Remove the {repository} from the name, it is not needed anymore, __unless__ the job is defined in a specific repo`\n\nIt\u0027s possible that I got it in reverse way.","commit_id":"5885d6b06ff6689673239e08a60526e2c3d68d45"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"11bd01c31ea4270cfaaecbe74fce1e35219544d3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      - ^doc/.*$"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- job:"},{"line_number":52,"context_line":"    name: build-monasca-common-docker-service-image"},{"line_number":53,"context_line":"    run: playbooks/docker_build_service.yml"},{"line_number":54,"context_line":"    required-projects:"},{"line_number":55,"context_line":"      - openstack/monasca-common"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5fc1f717_9eab7786","line":52,"range":{"start_line":52,"start_character":10,"end_line":52,"end_character":51},"in_reply_to":"5fc1f717_e38ea42c","updated":"2019-04-09 08:49:04.000000000","message":"Good point. Fixed.","commit_id":"5885d6b06ff6689673239e08a60526e2c3d68d45"}]}
