)]}'
{"monasca_common/confluent_kafka/consumer.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2e4cb05fbcc171ac1521966b9a584f75a1b74854","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        consumer_config \u003d {\u0027bootstrap.servers\u0027: bootstrap_servers,"},{"line_number":50,"context_line":"                           \u0027group.id\u0027: group_id,"},{"line_number":51,"context_line":"                           \u0027session.timeout.ms\u0027: timeout,"},{"line_number":52,"context_line":"                           \u0027fetch.min.bytes\u0027: fetch_min_bytes,"},{"line_number":53,"context_line":"                           \u0027client.id\u0027: client_id,"},{"line_number":54,"context_line":"                           \u0027enable.auto.commit\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_83436daf","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":35},"updated":"2019-07-29 10:45:56.000000000","message":"I\u0027m not entirely sure we will have the same issue with the new client. I have a fuzzy memory that this issue is related to the current Kafka client not supporting heart beats because the fork is old. The Confluent client should support them.","commit_id":"b5f44839bb7cba3a7ec6a0ca73aefa3b40d18a8d"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"45a5948c082b6e601a78a7dcee4ab8a77fb81185","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        consumer_config \u003d {\u0027bootstrap.servers\u0027: bootstrap_servers,"},{"line_number":50,"context_line":"                           \u0027group.id\u0027: group_id,"},{"line_number":51,"context_line":"                           \u0027session.timeout.ms\u0027: timeout,"},{"line_number":52,"context_line":"                           \u0027fetch.min.bytes\u0027: fetch_min_bytes,"},{"line_number":53,"context_line":"                           \u0027client.id\u0027: client_id,"},{"line_number":54,"context_line":"                           \u0027enable.auto.commit\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_59af97e2","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":35},"in_reply_to":"7faddb67_83436daf","updated":"2019-07-30 10:28:15.000000000","message":"Doug, you\u0027re probably right. The problem might not occur with the new client at all. Please also note that the proposed configuration options control different things: socket timeout in kafka-python and group session timeout in confluent-kafka.\n\nStill, the new configuration option is categorized as highly important [1]. Also the default value is kept the same as in the library. I think it\u0027s good to add.\n\n[1] https://github.com/edenhill/librdkafka/blob/master/CONFIGURATION.md","commit_id":"b5f44839bb7cba3a7ec6a0ca73aefa3b40d18a8d"}],"monasca_common/kafka/consumer.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"80d8a3031a5d29309755e3861e079a56343d85f0","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self._zookeeper_url \u003d zookeeper_url"},{"line_number":93,"context_line":"        self._zookeeper_path \u003d zookeeper_path"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self._kafka \u003d kafka_client.KafkaClient(kafka_url, timeout)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        self._consumer \u003d self._create_kafka_consumer()"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_90ef4ee8","line":95,"updated":"2019-07-26 08:36:52.000000000","message":"I think you want `timeout\u003dtimeout` here, otherwise you will set the client_id.","commit_id":"03900d11934f0abb3d2ecc409cdfd9bdc084c350"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1a0713e47dc23829b8837da42d1f68f31b2e08c0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                 repartition_callback\u003dNone,"},{"line_number":55,"context_line":"                 commit_callback\u003dNone,"},{"line_number":56,"context_line":"                 commit_timeout\u003d30,"},{"line_number":57,"context_line":"                 timeout\u003dDEFAULT_SOCKET_TIMEOUT_SECONDS, ):"},{"line_number":58,"context_line":"        \"\"\"Init"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"             kafka_url            - Kafka location"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8bab9f73","line":57,"range":{"start_line":57,"start_character":55,"end_line":57,"end_character":56},"updated":"2019-07-26 10:03:07.000000000","message":"nit: If we are going to leave this comma in, the bracket could go on the next line if pep8 allows it.","commit_id":"d7811cc57e1a1de62fc900ce82231103cb3eeff1"}]}