)]}'
{"monasca_log_api/tests/test_service.py":[{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"f636375dcf5d6454416f066dd1c9dcab3803c4f8","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        meta \u003d {\u0027tenantId\u0027: tenant_id, \u0027region\u0027: none}"},{"line_number":322,"context_line":"        expected_envelope \u003d {"},{"line_number":323,"context_line":"            \u0027log\u0027: expected_log,"},{"line_number":324,"context_line":"            \u0027creation_time\u0027: str(datetime.datetime.utcnow()),"},{"line_number":325,"context_line":"            \u0027meta\u0027: meta"},{"line_number":326,"context_line":"        }"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_f96e1d2e","line":324,"updated":"2015-11-18 02:16:54.000000000","message":"Other Monasca projects use ISO8601 format.\nISO8601 uses T delimiter between date and time.\nBut str function uses \u0027 \u0027 delimiter between date and time.\nIs there datetime format spec?","commit_id":"ca9dc0fe67b3fe286e0dc9b9af0373be01d9df89"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"0efb082cfc714413e39117e65c93e51a57f2ff76","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        meta \u003d {\u0027tenantId\u0027: tenant_id, \u0027region\u0027: none}"},{"line_number":322,"context_line":"        expected_envelope \u003d {"},{"line_number":323,"context_line":"            \u0027log\u0027: expected_log,"},{"line_number":324,"context_line":"            \u0027creation_time\u0027: str(datetime.datetime.utcnow()),"},{"line_number":325,"context_line":"            \u0027meta\u0027: meta"},{"line_number":326,"context_line":"        }"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_b84cef9e","line":324,"in_reply_to":"ba8a016a_2bff6768","updated":"2015-11-18 15:26:41.000000000","message":"Timestamp sounds consistent with monasca-api. I see an example of the timestamp from monasca-api sources: https://github.com/openstack/monasca-api/blob/master/monasca_api/v2/reference/helpers.py#L226","commit_id":"ca9dc0fe67b3fe286e0dc9b9af0373be01d9df89"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"9539bd450e168412591eaa8830eef21a8c4617dd","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        meta \u003d {\u0027tenantId\u0027: tenant_id, \u0027region\u0027: none}"},{"line_number":322,"context_line":"        expected_envelope \u003d {"},{"line_number":323,"context_line":"            \u0027log\u0027: expected_log,"},{"line_number":324,"context_line":"            \u0027creation_time\u0027: str(datetime.datetime.utcnow()),"},{"line_number":325,"context_line":"            \u0027meta\u0027: meta"},{"line_number":326,"context_line":"        }"},{"line_number":327,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_2bff6768","line":324,"in_reply_to":"ba8a016a_f96e1d2e","updated":"2015-11-18 06:05:38.000000000","message":"Honestly, that should be a timestamp. Sorry for misunderstanding, this is a fresh implementation and I will begin to write proper documentation, honestly I am now writing that. That should be something like this more or less. I believe there\u0027s a plenty of documentation somewhere out there as how to implement this _datetime_to_timestamp method :). \n\n  def new_log_envelope(self, log_object, tenant_id):\n        utc_now \u003d datetime.datetime.utcnow()\n\n        return {\n            \u0027log\u0027: log_object,\n            \u0027creation_time\u0027: _datetime_to_timestamp(utc_now),\n            \u0027meta\u0027: self._create_meta_info(tenant_id)\n        }","commit_id":"ca9dc0fe67b3fe286e0dc9b9af0373be01d9df89"}],"monasca_log_api/v1/common/log_publisher.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"a3e4860b4ff33a876cb0ae16aee46966217683d5","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        key \u003d self._build_key(message[\u0027meta\u0027][\u0027tenantId\u0027], message[\u0027log\u0027])"},{"line_number":87,"context_line":"        if \u0027creation_time\u0027 in message:"},{"line_number":88,"context_line":"            message[\u0027creation_time\u0027] \u003d str(message[\u0027creation_time\u0027])"},{"line_number":89,"context_line":"        msg \u003d simplejson.dumps(message,"},{"line_number":90,"context_line":"                               sort_keys\u003dFalse,"},{"line_number":91,"context_line":"                               ensure_ascii\u003dFalse).encode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_4fcf777f","line":88,"updated":"2015-11-17 16:33:58.000000000","message":"Would it be better if the invoker of send_message did the appropriate conversion of creation_time to a string.\n\nSeems like testing for the existence of the field in the message could be eliminated if the invoker did the proper conversion.","commit_id":"b3707235b6212867a640f42827e58fb90a72e0b5"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"a1b4322af3cf4e616eccbe5f0502359ec392b431","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        key \u003d self._build_key(message[\u0027meta\u0027][\u0027tenantId\u0027], message[\u0027log\u0027])"},{"line_number":87,"context_line":"        if \u0027creation_time\u0027 in message:"},{"line_number":88,"context_line":"            message[\u0027creation_time\u0027] \u003d str(message[\u0027creation_time\u0027])"},{"line_number":89,"context_line":"        msg \u003d simplejson.dumps(message,"},{"line_number":90,"context_line":"                               sort_keys\u003dFalse,"},{"line_number":91,"context_line":"                               ensure_ascii\u003dFalse).encode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_c10c9b96","line":88,"in_reply_to":"ba8a016a_4fcf777f","updated":"2015-11-17 16:55:12.000000000","message":"Good point. The method \"new_log_envelope\" adds this field and if it sets this as a string, no need for this patching here. Will make that change.","commit_id":"b3707235b6212867a640f42827e58fb90a72e0b5"}]}
