)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"cf5162d0e98780b582454ee4ee9fc3f147196a1e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tomasz Trębski \u003ctomasz.trebski@ts.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-05 08:50:52 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unitification for v2 and v3 output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change ensures that logs published to kafka"},{"line_number":10,"context_line":"will share exact same structure."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_b19e5d54","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":13},"updated":"2016-04-05 06:54:56.000000000","message":"spelling","commit_id":"e7e936cd5d15c3dd16088fe10fb02018d81c6d11"}],"monasca_log_api/reference/common/log_publisher.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"b449bffa28e24177d8468b71c21941dd68979479","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            str_list.append(dims.get(\u0027component\u0027, \u0027\u0027))"},{"line_number":101,"context_line":"            str_list.append(dims.get(\u0027service\u0027, \u0027\u0027))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        return \u0027:\u0027.join(filter(None, str_list))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @staticmethod"},{"line_number":106,"context_line":"    def _is_message_valid(message):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_b0758a99","line":103,"range":{"start_line":103,"start_character":14,"end_line":103,"end_character":15},"updated":"2016-04-05 19:37:25.000000000","message":"This doesn\u0027t seem correct to me. Shouldn\u0027t we be appending any supplied dimensions, not adding the dimensions for component and service.","commit_id":"25e9de2148b6be28af0d4479b9a648eb56692e99"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"71c0d988308022d2095c841b40854e598465ad00","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            str_list.append(dims.get(\u0027component\u0027, \u0027\u0027))"},{"line_number":101,"context_line":"            str_list.append(dims.get(\u0027service\u0027, \u0027\u0027))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        return \u0027:\u0027.join(filter(None, str_list))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @staticmethod"},{"line_number":106,"context_line":"    def _is_message_valid(message):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_d36f63c3","line":103,"range":{"start_line":103,"start_character":14,"end_line":103,"end_character":15},"in_reply_to":"9a061dce_b0758a99","updated":"2016-04-05 21:52:36.000000000","message":"Well the main problems I see here, it that dimensions have basically no limit (well length of keys and values is limited). So following this trail length of the keys is also unlimited. \n\nThe \"bigger\" dimensions the longer process of computing the key is and afterwards fairly simple operation of selecting a partition based on it would also take longer. \n\nSo, I am not quite comfortable with using every supplied dimension. Still your comment is pretty much as valid as mine.\n\nSo the question, IMHO, is do we want to spend more time than it actually is needed to use every possible dimension to create a key for each message or simply use common dimensions to do that. \n\nBTW. Still, now when I am thinking of it, we could go with cache decorator for method that builds key ensuring that only at the beginning time spent on computation is longer.","commit_id":"25e9de2148b6be28af0d4479b9a648eb56692e99"}],"monasca_log_api/tests/test_v2_v3_compare.py":[{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"210a34ada40ba174d4d11ba40b3aef1f6b3394c3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                headers.X_APPLICATION_TYPE.name: component,"},{"line_number":76,"context_line":"                headers.X_TENANT_ID.name: tenant_id,"},{"line_number":77,"context_line":"                \u0027Content-Type\u0027: \u0027application/json\u0027,"},{"line_number":78,"context_line":"                \u0027Content-Length\u0027: \u0027100\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            },"},{"line_number":81,"context_line":"            body\u003djson.dumps(v2_body)"},{"line_number":82,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_048a69bf","line":79,"range":{"start_line":78,"start_character":39,"end_line":79,"end_character":0},"updated":"2016-04-05 07:33:15.000000000","message":"Blank line is needed?","commit_id":"e7e936cd5d15c3dd16088fe10fb02018d81c6d11"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c129e81da3f47dc19f4edfeb792e6b459593c13e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                headers.X_APPLICATION_TYPE.name: component,"},{"line_number":76,"context_line":"                headers.X_TENANT_ID.name: tenant_id,"},{"line_number":77,"context_line":"                \u0027Content-Type\u0027: \u0027application/json\u0027,"},{"line_number":78,"context_line":"                \u0027Content-Length\u0027: \u0027100\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            },"},{"line_number":81,"context_line":"            body\u003djson.dumps(v2_body)"},{"line_number":82,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_e23c8531","line":79,"range":{"start_line":78,"start_character":39,"end_line":79,"end_character":0},"in_reply_to":"9a061dce_048a69bf","updated":"2016-04-05 08:06:53.000000000","message":"Not at all, I was copying the lines and this empty line just was copied by mistake.","commit_id":"e7e936cd5d15c3dd16088fe10fb02018d81c6d11"}]}