)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"dffeecede40df6e390ba6c319ffb5859766aff81","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Similar to other openstack projects,"},{"line_number":10,"context_line":"monasca-log-api should provide informations"},{"line_number":11,"context_line":"about rquest\u0027s context in the log information."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is done by:"},{"line_number":14,"context_line":"* implementing custom Request that creates context (oslo.context)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a71b18c_84f119d0","line":11,"updated":"2016-12-09 05:26:09.000000000","message":"Typo: requests","commit_id":"d3472283f32d22b532c7a58ee9e2569c05962a33"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"dcb84221abe75d6106e5671b872baa22c8f3388a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Similar to other openstack projects,"},{"line_number":10,"context_line":"monasca-log-api should provide informations"},{"line_number":11,"context_line":"about rquest\u0027s context in the log information."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is done by:"},{"line_number":14,"context_line":"* implementing custom Request that creates context (oslo.context)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a71b18c_3afe9538","line":11,"in_reply_to":"3a71b18c_84f119d0","updated":"2016-12-09 09:56:27.000000000","message":"Done","commit_id":"d3472283f32d22b532c7a58ee9e2569c05962a33"}],"monasca_log_api/api/core/request.py":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"c6f066d39d918d983c6622d5b18c6e773cd6bdb4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from monasca_log_api.reference.common import validation"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"_TENANT_ID_PARAM \u003d \u0027tenant_id\u0027"},{"line_number":22,"context_line":"\"\"\"Name of the query-param pointing at project-id (tenant-id)\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class Request(falcon.Request):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_19da2fea","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":64},"updated":"2016-11-21 06:06:42.000000000","message":"docs should be before variable","commit_id":"00a609b6488ec54aed9f0d7461e03946858aed94"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"c6f066d39d918d983c6622d5b18c6e773cd6bdb4","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class Request(falcon.Request):"},{"line_number":26,"context_line":"    \"\"\"Variation os falcon.Request with context"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    Following class enhances :py:class:`falcon.Request` with"},{"line_number":29,"context_line":"    :py:class:`context.RequestContext`."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_99b47fd5","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":19},"updated":"2016-11-21 06:06:42.000000000","message":"f","commit_id":"00a609b6488ec54aed9f0d7461e03946858aed94"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"fe5178fff3c940681e31a4075cae72def21a86e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5a74a57a_f4426d3d","updated":"2016-11-25 04:23:13.000000000","message":"Should this file be in monasca-common so we can use it for the monasca-api too?","commit_id":"7feeee0b5b431298d612551b7e8c193d869c782e"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c7d09a0d0ed0d49591ce56c1b246b3120af8a71d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5a74a57a_582c2f02","in_reply_to":"5a74a57a_f4426d3d","updated":"2016-11-25 08:40:08.000000000","message":"Not really sure, I don\u0027t think that validation part is something that will be truly identical between monasca-api and monasca-log-api. Apart from that the rest of the implementation is really simple. \n\nI would have to check how validation looks there to see if that is really possible. Maybe first we could create similar oslo.context integration for log-api and later on figure out all similarities for both and have it refactored ?","commit_id":"7feeee0b5b431298d612551b7e8c193d869c782e"},{"author":{"_account_id":15178,"name":"Kamil Choroba","email":"kamil.choroba@est.fujitsu.com","username":"kchoroba"},"change_message_id":"2e1807e12acdb43b48c3bd994447858e5a916ef4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        :raises Exception: if any of the validation fails"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        if content_types:"},{"line_number":52,"context_line":"            validation.validate_content_type(self, content_types)"},{"line_number":53,"context_line":"        validation.validate_payload_size(self)"},{"line_number":54,"context_line":"        validation.validate_cross_tenant("}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_6ec5658c","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":25},"updated":"2016-12-12 12:53:18.000000000","message":"Is it a valid request if content_types is None? Because the validate_content_type function raises a \u0027falcon.HTTPMissingHeader(\u0027Content-Type\u0027)\u0027 Exception if content_type is None. But in this case we will never come to this point.","commit_id":"70cd061d9922e26cd13d488cbc77d06a805385bc"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"2f3e27db42cdeebc0eb768a06f4215366caf12e5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        :raises Exception: if any of the validation fails"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        if content_types:"},{"line_number":52,"context_line":"            validation.validate_content_type(self, content_types)"},{"line_number":53,"context_line":"        validation.validate_payload_size(self)"},{"line_number":54,"context_line":"        validation.validate_cross_tenant("}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_ab20eff8","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":25},"in_reply_to":"3a71b18c_6ec5658c","updated":"2016-12-12 22:15:28.000000000","message":"Well, actually content_types here comes from the resource that calls validation method but I get your point that should be enforced to be defined.","commit_id":"70cd061d9922e26cd13d488cbc77d06a805385bc"}],"monasca_log_api/reference/common/validation.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"fe5178fff3c940681e31a4075cae72def21a86e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5a74a57a_74757d96","updated":"2016-11-25 04:23:13.000000000","message":"Should this file be in monasca-common so we can use it for the monasca-api too?","commit_id":"7feeee0b5b431298d612551b7e8c193d869c782e"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"c7d09a0d0ed0d49591ce56c1b246b3120af8a71d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5a74a57a_b810e3a9","in_reply_to":"5a74a57a_74757d96","updated":"2016-11-25 08:40:08.000000000","message":"See my other comment about that part.","commit_id":"7feeee0b5b431298d612551b7e8c193d869c782e"}],"monasca_log_api/reference/v3/logs.py":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"c6f066d39d918d983c6622d5b18c6e773cd6bdb4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from monasca_log_api.api import exceptions"},{"line_number":20,"context_line":"from monasca_log_api.api import logs_api"},{"line_number":21,"context_line":"from monasca_log_api.monitoring import metrics"},{"line_number":22,"context_line":"from monasca_log_api.reference.common import validation"},{"line_number":23,"context_line":"from monasca_log_api.reference.v3.common import bulk_processor"},{"line_number":24,"context_line":"from monasca_log_api.reference.v3.common import helpers"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_f98653da","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":55},"updated":"2016-11-21 06:06:42.000000000","message":"Also could be removed.","commit_id":"00a609b6488ec54aed9f0d7461e03946858aed94"}]}
