)]}'
{"monasca_log_api/common/repositories/logs_repository.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"5de6f925f0f3d47d55ba58ded5d9ab1a005a122f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        super(LogsRepository, self).__init__()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @abc.abstractmethod"},{"line_number":30,"context_line":"    def list_logs(self, tenant_id, dimensions, start_time, end_time, offset,"},{"line_number":31,"context_line":"                  limit, sort_by):"},{"line_number":32,"context_line":"        \"\"\"Obtain log listing based on simple criteria of dimension values."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_ce4dfb73","line":30,"updated":"2017-03-18 20:51:24.000000000","message":"Maybe we should mention those defaults from the spec here ?","commit_id":"f9b6be7ddafaff66a3115fbb167a095df6a58566"},{"author":{"_account_id":24533,"name":"Steve Simpson","email":"steve@stackhpc.com","username":"stevejims"},"change_message_id":"828e9863d94d8ca5c12ed0a3ee82b85825e128a4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        super(LogsRepository, self).__init__()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @abc.abstractmethod"},{"line_number":30,"context_line":"    def list_logs(self, tenant_id, dimensions, start_time, end_time, offset,"},{"line_number":31,"context_line":"                  limit, sort_by):"},{"line_number":32,"context_line":"        \"\"\"Obtain log listing based on simple criteria of dimension values."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_b1d3ae5e","line":30,"in_reply_to":"1a1ced50_ce4dfb73","updated":"2017-03-20 09:43:48.000000000","message":"Good idea - I\u0027ll add some wording in.\n\nI\u0027ve actually made a mistake here - I wanted the \u0027limit\u0027 parameter to be explicit at this level, and have the default enforced at the HTTP API layer. I\u0027ll make the change and see what you think.","commit_id":"f9b6be7ddafaff66a3115fbb167a095df6a58566"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"b6bb4213533cce5484d4b5ab2b5f820092aee964","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import collections"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Dimension \u003d collections.namedtuple(\u0027Dimension\u0027, \u0027name values\u0027)"},{"line_number":20,"context_line":"SortBy \u003d collections.namedtuple(\u0027SortBy\u0027, \u0027field direction\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_66cdf95c","line":19,"updated":"2017-03-20 11:39:36.000000000","message":"A little bit of docs ? And maybe...hmm...maybe it would be better to have this in some sort of common module ? Just a thought, btw.","commit_id":"afef32ff1c6f73e498302b9699d030f8d2555c03"},{"author":{"_account_id":24533,"name":"Steve Simpson","email":"steve@stackhpc.com","username":"stevejims"},"change_message_id":"561e7a428c20624780c0cdad0bbbb0d5890042d5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import collections"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Dimension \u003d collections.namedtuple(\u0027Dimension\u0027, \u0027name values\u0027)"},{"line_number":20,"context_line":"SortBy \u003d collections.namedtuple(\u0027SortBy\u0027, \u0027field direction\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_ff0c0896","line":19,"in_reply_to":"1a1ced50_66cdf95c","updated":"2017-03-20 15:03:09.000000000","message":"Added some docs.\n\nSure where did you have in mind? Something like\n\nmonasca_log_api/common/repositories/types.py\n\n?","commit_id":"afef32ff1c6f73e498302b9699d030f8d2555c03"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"a55ecf11eb2a04d1f28abd9577dcc29d5e542451","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":20,"context_line":"class LogsRepository(object):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def __init__(self):"},{"line_number":23,"context_line":"        super(LogsRepository, self).__init__()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_55386fef","line":20,"updated":"2017-03-21 11:43:48.000000000","message":"Damn, sorry for that. I thought that after we add db package, this one will land in\n\n  monasca_log_api/db/repo\n\nDo you think we can move it to there ?","commit_id":"ad250e82b22fbfd6449eeb05271271ffac0bf53c"}],"monasca_log_api/db/repo/logs_repository.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ddc0602e5bfe079777c3019bb163be9d3221cc11","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        super(LogsRepository, self).__init__()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @abc.abstractmethod"},{"line_number":26,"context_line":"    def list_logs(self, tenant_id, dimensions, start_time, end_time, offset,"},{"line_number":27,"context_line":"                  limit, sort_by):"},{"line_number":28,"context_line":"        \"\"\"Obtain log listing based on simple criteria of dimension values."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_7645bf42","line":26,"updated":"2017-03-28 10:42:33.000000000","message":"I still think that we ought to consider using context here to store that, however I\u0027d need to see how other projects are doing that precisely. \n\nI mean, we\u0027re in point where we can do something in neat and elegant way aligning monasca-log-api with other openstack projects thus making it more predictable - I\u0027d try and purse that.","commit_id":"631439408e7e3b3f0e8957e7ccade1a9ad32f3e9"}]}