)]}'
{"etc/monasca/log-api-config.conf":[{"author":{"_account_id":15178,"name":"Kamil Choroba","email":"kamil.choroba@est.fujitsu.com","username":"kchoroba"},"change_message_id":"beb51661b8ceb001fc0ea87437ea9ab9235953c3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"path \u003d /v2.0/log,/v3.0/logs"},{"line_number":60,"context_line":"default_roles \u003d user,domainuser,domainadmin,monasca-user"},{"line_number":61,"context_line":"agent_roles \u003d monasca-agent"},{"line_number":62,"context_line":"delegate_roles \u003d admin"}],"source_content_type":"text/plain","patch_set":5,"id":"7ffa3b31_c4c9c478","line":62,"range":{"start_line":62,"start_character":17,"end_line":62,"end_character":22},"updated":"2017-04-18 11:16:02.000000000","message":"Shouldn\u0027t we stick to the default role name which is also used for monasca-agent and libvirt monitoring? \"monitoring-delegate\". Or we need to change the documentation: https://github.com/openstack/monasca-log-api/blob/master/documentation/monasca-log-api-spec.md","commit_id":"dcd8ac3690aa5410181a89f493ba0eca8036454e"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"1b138ad8938a6e639a105ffe08d9ab5eae7cbaca","unresolved":false,"context_lines":[{"line_number":59,"context_line":"path \u003d /v2.0/log,/v3.0/logs"},{"line_number":60,"context_line":"default_roles \u003d user,domainuser,domainadmin,monasca-user"},{"line_number":61,"context_line":"agent_roles \u003d monasca-agent"},{"line_number":62,"context_line":"delegate_roles \u003d admin"}],"source_content_type":"text/plain","patch_set":5,"id":"7ffa3b31_18738fb3","line":62,"range":{"start_line":62,"start_character":17,"end_line":62,"end_character":22},"in_reply_to":"7ffa3b31_c4c9c478","updated":"2017-04-18 11:38:09.000000000","message":"I have based this new config option on the one available in monasca-api. The documentation (at least for Python) seems to be not up to date in that aspect.\n\nFor this change I have change the documentation of tenant_id query parameter.","commit_id":"dcd8ac3690aa5410181a89f493ba0eca8036454e"}],"monasca_log_api/middleware/role_middleware.py":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"671bc6b7872f15e69172290ecfda63b703676734","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cfg.ListOpt(name\u003d\u0027delegate_roles\u0027,"},{"line_number":36,"context_line":"                default\u003d[\u0027admin\u0027],"},{"line_number":37,"context_line":"                help\u003d(\u0027Roles that are allowed to POST logs on \u0027"},{"line_number":38,"context_line":"                      \u0027behalf of another tenant\u0027))"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":"role_m_group \u003d cfg.OptGroup(name\u003d\u0027roles_middleware\u0027, title\u003d\u0027roles_middleware\u0027)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5ff73747_9c102e59","line":38,"range":{"start_line":38,"start_character":42,"end_line":38,"end_character":48},"updated":"2017-04-29 15:52:27.000000000","message":"I think it\u0027s better to replace from tenant to project :)","commit_id":"ba2726a8fb5d96df1f5bc092cd9c16ccb47dd348"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"3ac0da7ef01f13e9aa6f51d283d9d791d2e6b32d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cfg.ListOpt(name\u003d\u0027delegate_roles\u0027,"},{"line_number":36,"context_line":"                default\u003d[\u0027admin\u0027],"},{"line_number":37,"context_line":"                help\u003d(\u0027Roles that are allowed to POST logs on \u0027"},{"line_number":38,"context_line":"                      \u0027behalf of another tenant\u0027))"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":"role_m_group \u003d cfg.OptGroup(name\u003d\u0027roles_middleware\u0027, title\u003d\u0027roles_middleware\u0027)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_544c70c6","line":38,"range":{"start_line":38,"start_character":42,"end_line":38,"end_character":48},"in_reply_to":"3f044301_89f6658f","updated":"2017-05-04 17:42:26.000000000","message":"You know, to be honest...debating here over this little chunk is kind of weird. This is an help string after all, that\u0027ll be visible in the configuration file only if oslo-generate-config is used. \n\n@Witek, can we, in the good faith for future, agree with Yushiro and resolve all other points of this discussion later ?","commit_id":"ba2726a8fb5d96df1f5bc092cd9c16ccb47dd348"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"1212c3ba3cf81eb201c927f220560aa2aff86114","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cfg.ListOpt(name\u003d\u0027delegate_roles\u0027,"},{"line_number":36,"context_line":"                default\u003d[\u0027admin\u0027],"},{"line_number":37,"context_line":"                help\u003d(\u0027Roles that are allowed to POST logs on \u0027"},{"line_number":38,"context_line":"                      \u0027behalf of another tenant\u0027))"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":"role_m_group \u003d cfg.OptGroup(name\u003d\u0027roles_middleware\u0027, title\u003d\u0027roles_middleware\u0027)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_89f6658f","line":38,"range":{"start_line":38,"start_character":42,"end_line":38,"end_character":48},"in_reply_to":"3f044301_abd000cb","updated":"2017-05-04 17:16:06.000000000","message":"Still it is deprecated, the fact it is there doesn\u0027t mean anything here IMHO. Mainly because here we have configuration options and in API we have query params which are action data - couldn\u0027t put those further apart.\n\nFor me this is kind of wrong that API itself will move further with tenant while it is deprecated. We ought to have project_id there and propose changes for monasca-api which deprecate usage of tenant-id. \n\nI understand there\u0027s a time pressure, however we shouldn\u0027t keep on using old, historical so to say, names when introducing new functionality, which is kind of what we\u0027re trying to do here (with minor remark that this patching). \n\nLet\u0027s use project_id here in monasca-log-api to close that topic and rework other monasca projects to deprecate tenant-id. That will be fairly simple operation to just add new param which will deprecate the old one.\n\nFYI: I know I introduced deprecated tenant-id and I at the moment I am not particularly proud of not thinking about all I wrote back then. Having that said, I would really love finally removing that historical debt from monasca components.","commit_id":"ba2726a8fb5d96df1f5bc092cd9c16ccb47dd348"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"44bd4c56e60151f80dcfa858e30d11a050c6661b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cfg.ListOpt(name\u003d\u0027delegate_roles\u0027,"},{"line_number":36,"context_line":"                default\u003d[\u0027admin\u0027],"},{"line_number":37,"context_line":"                help\u003d(\u0027Roles that are allowed to POST logs on \u0027"},{"line_number":38,"context_line":"                      \u0027behalf of another tenant\u0027))"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":"role_m_group \u003d cfg.OptGroup(name\u003d\u0027roles_middleware\u0027, title\u003d\u0027roles_middleware\u0027)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5ff73747_f43de7c3","line":38,"range":{"start_line":38,"start_character":42,"end_line":38,"end_character":48},"in_reply_to":"5ff73747_7964304a","updated":"2017-05-02 08:28:36.000000000","message":"I agree with Yushiro, tenant is depracated and it shouldn\u0027t be used because it complicates. \n\nYou should instead change monasca-api to use project.","commit_id":"ba2726a8fb5d96df1f5bc092cd9c16ccb47dd348"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"cbdd9502569e46c223545608a95f5231905e5a32","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cfg.ListOpt(name\u003d\u0027delegate_roles\u0027,"},{"line_number":36,"context_line":"                default\u003d[\u0027admin\u0027],"},{"line_number":37,"context_line":"                help\u003d(\u0027Roles that are allowed to POST logs on \u0027"},{"line_number":38,"context_line":"                      \u0027behalf of another tenant\u0027))"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":"role_m_group \u003d cfg.OptGroup(name\u003d\u0027roles_middleware\u0027, title\u003d\u0027roles_middleware\u0027)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5ff73747_7964304a","line":38,"range":{"start_line":38,"start_character":42,"end_line":38,"end_character":48},"in_reply_to":"5ff73747_9c102e59","updated":"2017-05-02 08:13:51.000000000","message":"Tenant and project mean basically the same and I wanted to keep consistent naming with monasca-api.","commit_id":"ba2726a8fb5d96df1f5bc092cd9c16ccb47dd348"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"e734ffe18eae623e684a8baf859e05eb3d9683e8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    cfg.ListOpt(name\u003d\u0027delegate_roles\u0027,"},{"line_number":36,"context_line":"                default\u003d[\u0027admin\u0027],"},{"line_number":37,"context_line":"                help\u003d(\u0027Roles that are allowed to POST logs on \u0027"},{"line_number":38,"context_line":"                      \u0027behalf of another tenant\u0027))"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":"role_m_group \u003d cfg.OptGroup(name\u003d\u0027roles_middleware\u0027, title\u003d\u0027roles_middleware\u0027)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_abd000cb","line":38,"range":{"start_line":38,"start_character":42,"end_line":38,"end_character":48},"in_reply_to":"5ff73747_f43de7c3","updated":"2017-05-04 13:31:10.000000000","message":"I don\u0027t know. \u0027tenant_id\u0027 is the name of the query parameter in the API.","commit_id":"ba2726a8fb5d96df1f5bc092cd9c16ccb47dd348"}]}