)]}'
{"monasca_log_api/tests/test_request.py":[{"author":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"change_message_id":"96adb43dbf52119ef5046d72ac32c0e554acfebe","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from falcon import testing"},{"line_number":16,"context_line":"from unittest.mock import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from monasca_log_api.app.base import request"},{"line_number":19,"context_line":"from monasca_log_api.app.base import validation"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_3eea9fab","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":30},"updated":"2020-06-10 12:59:30.000000000","message":"It should be:\nfrom unittest.mock import patch\n\nAnd then change in the code \u0027mock.patch.*\u0027 with \u0027patch.*\u0027","commit_id":"f95af311e8cb39aafe9353527ca008a1dd8fc2f6"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"37214d874eacb77d54b58f90ea98a405db09756e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from falcon import testing"},{"line_number":16,"context_line":"from unittest.mock import patch"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from monasca_log_api.app.base import request"},{"line_number":19,"context_line":"from monasca_log_api.app.base import validation"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e43091a1","line":16,"updated":"2020-06-10 16:04:22.000000000","message":"Nit, it\u0027s a good practice to import modules and not functions. In that case it would mean:\n\n  from unittest import mock\n\nAlso, as we use the standard library now the import should go to the first group of imports [1].\n\n[1] https://www.python.org/dev/peps/pep-0008/#id23","commit_id":"dc6dab4565b46cb39e1883c149e1d8420369bcc9"},{"author":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"change_message_id":"6962d45f41ae47bb7a755047d2b0dc923aeba6d5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from falcon import testing"},{"line_number":16,"context_line":"from unittest.mock import patch"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from monasca_log_api.app.base import request"},{"line_number":19,"context_line":"from monasca_log_api.app.base import validation"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_a934e24b","line":16,"in_reply_to":"ff570b3c_e43091a1","updated":"2020-06-15 13:36:29.000000000","message":"Done, thanks for the tip.\nHervé, thanks for the initial patch sets.","commit_id":"dc6dab4565b46cb39e1883c149e1d8420369bcc9"}]}