)]}'
{"monasca_notification/processors/notification_processor.py":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"b77890a93440ded1ade34486e2460e6d36659561","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        try:"},{"line_number":185,"context_line":"            result \u003d requests.post(url\u003durl,"},{"line_number":186,"context_line":"                                   data\u003djson.dumps(body),"},{"line_number":187,"context_line":"                                   headers\u003dheaders,"},{"line_number":188,"context_line":"                                   timeout\u003dself.pagerduty_config[\u0027timeout\u0027])"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1a8048bf","line":186,"updated":"2014-12-19 18:00:04.000000000","message":"is this unicode capable?","commit_id":"25b8ebbfd819a60186598008ad93b402cf5bea4f"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"5c8b8cc4b13b6fd9bd986733a332d94116cfcab2","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        try:"},{"line_number":185,"context_line":"            result \u003d requests.post(url\u003durl,"},{"line_number":186,"context_line":"                                   data\u003djson.dumps(body),"},{"line_number":187,"context_line":"                                   headers\u003dheaders,"},{"line_number":188,"context_line":"                                   timeout\u003dself.pagerduty_config[\u0027timeout\u0027])"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3ae6e4b0","line":186,"in_reply_to":"3a961159_1a8048bf","updated":"2014-12-19 18:21:33.000000000","message":"Probably not but I haven\u0027t done any other work to make the notification system unicode aware yet.  I plan to hit this, and all the other places, in one go.","commit_id":"25b8ebbfd819a60186598008ad93b402cf5bea4f"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"14e6ecda1ac4192139aaca6778cbb9b5cdd42ff8","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            if result.status_code in valid_http_codes:"},{"line_number":192,"context_line":"                return notification"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"            log.error(\"Error with pagerduty request. key\u003d\u003c%s\u003e response\u003d%s\""},{"line_number":195,"context_line":"                      % (notification.address, result.status_code))"},{"line_number":196,"context_line":"        except:"},{"line_number":197,"context_line":"            log.error(\"Exception on pagerduty request. key\u003d\u003c%s\u003e exception\u003d%s\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_1dd01fc8","line":194,"updated":"2014-12-22 16:08:58.000000000","message":"FWIW one of the checking libraries or another typically doesn\u0027t like a raw except and will tell you to do except exception. We must have that ignored now but might as well make new code match that expectation.\n\nAlso there is a nice log.exception method that handles formatting of the exception message for you, not a necessity but is a time saver.","commit_id":"13f2cf07e0867b926e861523f32c30c0a69f5a80"}],"tests/test_notification_processor.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"8aebf15e79a8d0eab0944376568fe2859485da97","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        self.processor.terminate()"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def test_pagerduty_201(self):"},{"line_number":405,"context_line":"        \"\"\"pagerduty 201"},{"line_number":406,"context_line":"        \"\"\""},{"line_number":407,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_66537617","line":404,"updated":"2014-12-19 19:44:39.000000000","message":"These methods seem to have a lot of duplicated code in them. Can you refactor that part out so it is easier to see what varies in each one?","commit_id":"fdd1635272d1700db6fcddedc50cbbec1ec70882"}]}