)]}'
{"monasca_notification/processors/alarm_processor.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"6606e424b65ad60290e5fd4678958aaf065ef7da","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                               JOIN notification_method as nm ON aa.action_id \u003d nm.id"},{"line_number":112,"context_line":"                               WHERE aa.alarm_definition_id \u003d %s and aa.alarm_state \u003d %s\"\"\","},{"line_number":113,"context_line":"                            [alarm[\u0027alarmDefinitionId\u0027], alarm[\u0027newState\u0027]])"},{"line_number":114,"context_line":"        except MySQLdb.Error:"},{"line_number":115,"context_line":"            raise"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        return [Notification(row[1].lower(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_7817df51","line":114,"updated":"2015-05-12 22:41:42.000000000","message":"No point in having a try block if you don\u0027t catch anything.","commit_id":"81b00b7648056b7cde838beec1624d013cc80621"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"6606e424b65ad60290e5fd4678958aaf065ef7da","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            log.debug(\u0027MySQL Error.  Attempting reconnect\u0027)"},{"line_number":155,"context_line":"            self._connect_to_mysql()"},{"line_number":156,"context_line":"            notifications \u003d self._build_notification(partition, offset, alarm)"},{"line_number":157,"context_line":"        except Exception:"},{"line_number":158,"context_line":"            log.exception(\"\")"},{"line_number":159,"context_line":"            raise"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_983bb3eb","line":157,"updated":"2015-05-12 22:41:42.000000000","message":"If you are not adding any message and just raising it again no need to catch here just let it go.","commit_id":"81b00b7648056b7cde838beec1624d013cc80621"}],"monasca_notification/processors/kafka_consumer.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"6606e424b65ad60290e5fd4678958aaf065ef7da","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                        log.error(\"Kafka OffsetOutOfRange.  Jumping to head.\")"},{"line_number":139,"context_line":"                        self._consumer.seek(0, 0)"},{"line_number":140,"context_line":"                    except Exception as ex:"},{"line_number":141,"context_line":"                        log.exception(\"Kafka Exception: {}\".format(ex))"},{"line_number":142,"context_line":"                        raise"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"                elif set_partitioner.allocating:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_f8a74f4d","line":141,"updated":"2015-05-12 22:41:42.000000000","message":"The point of log.exception is that you don\u0027t have to add the exception into the message it nicely formats it for you.\nhttps://docs.python.org/2/library/logging.html#logger-objects","commit_id":"81b00b7648056b7cde838beec1624d013cc80621"}]}