)]}'
{"monasca_notification/types/email_notifier.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"a4c93db6a53d1d44d5eba7ace6ab133e48da435b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            dimap \u003d metric[\u0027dimensions\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            if \u0027hostname\u0027 in dimap:"},{"line_number":53,"context_line":"                if not dimap[\u0027hostname\u0027] in hostname:"},{"line_number":54,"context_line":"                    hostname.append(dimap[\u0027hostname\u0027])"},{"line_number":55,"context_line":"            if \u0027target_host\u0027 in dimap:"},{"line_number":56,"context_line":"                if not dimap[\u0027target_host\u0027] in targethost:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_554cd56f","line":53,"updated":"2015-07-13 19:48:51.000000000","message":"Minor point but I think both of these would be a bit easier to read as an if with an \u0027and\u0027 rather than nested ifs.","commit_id":"ac5cfbc31c642c77a3fd5b1986e207195368eda8"},{"author":{"_account_id":12149,"name":"Dexter Fryar","email":"dexter.fryar@protonmail.com","username":"dlfryar"},"change_message_id":"05b6c8f778c5d03349714fc3e931321a014243b2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            dimap \u003d metric[\u0027dimensions\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            if \u0027hostname\u0027 in dimap:"},{"line_number":53,"context_line":"                if not dimap[\u0027hostname\u0027] in hostname:"},{"line_number":54,"context_line":"                    hostname.append(dimap[\u0027hostname\u0027])"},{"line_number":55,"context_line":"            if \u0027target_host\u0027 in dimap:"},{"line_number":56,"context_line":"                if not dimap[\u0027target_host\u0027] in targethost:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_b569a127","line":53,"in_reply_to":"9a41bdd9_554cd56f","updated":"2015-07-13 20:05:08.000000000","message":"Done","commit_id":"ac5cfbc31c642c77a3fd5b1986e207195368eda8"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"1026c580d5e1e3cb226331a506320e3b8807c17c","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            if \u0027hostname\u0027 in dimap and not \\"},{"line_number":53,"context_line":"                            dimap[\u0027hostname\u0027] in hostname:"},{"line_number":54,"context_line":"                    hostname.append(dimap[\u0027hostname\u0027])"},{"line_number":55,"context_line":"            if \u0027target_host\u0027 in dimap and not \\"},{"line_number":56,"context_line":"                            dimap[\u0027target_host\u0027] in targethost:"},{"line_number":57,"context_line":"                    targethost.append(dimap[\u0027target_host\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_154bad88","line":54,"updated":"2015-07-13 20:11:54.000000000","message":"This looks good but it\u0027s probably going to fail pep8 because of the indentation.  Would it be more normal to use parenthesis to do the line wrapping instead of the \\?","commit_id":"39319dd2aa0fadf1252b06a2da61081f18cb7050"},{"author":{"_account_id":12149,"name":"Dexter Fryar","email":"dexter.fryar@protonmail.com","username":"dlfryar"},"change_message_id":"3821b3f4b1f780f547169a9e9a40a4b716a008e3","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            if \u0027hostname\u0027 in dimap and not \\"},{"line_number":53,"context_line":"                            dimap[\u0027hostname\u0027] in hostname:"},{"line_number":54,"context_line":"                    hostname.append(dimap[\u0027hostname\u0027])"},{"line_number":55,"context_line":"            if \u0027target_host\u0027 in dimap and not \\"},{"line_number":56,"context_line":"                            dimap[\u0027target_host\u0027] in targethost:"},{"line_number":57,"context_line":"                    targethost.append(dimap[\u0027target_host\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_28cbf81f","line":54,"in_reply_to":"9a41bdd9_154bad88","updated":"2015-07-13 20:38:32.000000000","message":"Done","commit_id":"39319dd2aa0fadf1252b06a2da61081f18cb7050"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"13699e72957c9071bb89b5cccb99ff48ce14eaa3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            dimap \u003d metric[\u0027dimensions\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            if \u0027hostname\u0027 in dimap and not dimap[\u0027hostname\u0027] in hostname:"},{"line_number":53,"context_line":"                    hostname.append(dimap[\u0027hostname\u0027])"},{"line_number":54,"context_line":"            if \u0027target_host\u0027 in dimap and not dimap[\u0027target_host\u0027] in targethost:"},{"line_number":55,"context_line":"                    targethost.append(dimap[\u0027target_host\u0027])"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_6b733a16","line":53,"updated":"2015-07-13 21:01:49.000000000","message":"Is it just this view or is this indented too far now?","commit_id":"64e9ea92ecc185b6e92b342da5c1e02f1015e5a0"},{"author":{"_account_id":12149,"name":"Dexter Fryar","email":"dexter.fryar@protonmail.com","username":"dlfryar"},"change_message_id":"67ca9d4eacfe6ea9ceb388bf05361030d393ff41","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            dimap \u003d metric[\u0027dimensions\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            if \u0027hostname\u0027 in dimap and not dimap[\u0027hostname\u0027] in hostname:"},{"line_number":53,"context_line":"                    hostname.append(dimap[\u0027hostname\u0027])"},{"line_number":54,"context_line":"            if \u0027target_host\u0027 in dimap and not dimap[\u0027target_host\u0027] in targethost:"},{"line_number":55,"context_line":"                    targethost.append(dimap[\u0027target_host\u0027])"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_4b30b601","line":53,"in_reply_to":"9a41bdd9_6b733a16","updated":"2015-07-13 21:06:23.000000000","message":"Argh yes, good catch.","commit_id":"64e9ea92ecc185b6e92b342da5c1e02f1015e5a0"}]}