)]}'
{"monasca_notification/main.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"97efe3a57d4bfdaccddccae9c5a22b35015f5642","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    log.info(\u0027Received signal %s, beginning graceful shutdown.\u0027 % signum)"},{"line_number":51,"context_line":"    exiting \u003d True"},{"line_number":52,"context_line":"    wait_for_exit \u003d True"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    for process in processors:"},{"line_number":55,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_8a8e5d77","line":52,"range":{"start_line":52,"start_character":4,"end_line":52,"end_character":17},"updated":"2016-02-05 23:08:48.000000000","message":"wait_for_exit is set to True, should this be False\n\nSeems like you only want to wait in the case the you have a process that you are going to terminate.","commit_id":"acca69ba0f75e89fa0d8013e0f2688c7c65df78f"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"97efe3a57d4bfdaccddccae9c5a22b35015f5642","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            if process.is_alive():"},{"line_number":57,"context_line":"                process.terminate()  # Sends sigterm which any processes after a notification is sent attempt to handle"},{"line_number":58,"context_line":"                wait_for_exit \u003d True"},{"line_number":59,"context_line":"        except Exception:"},{"line_number":60,"context_line":"            pass"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_eadcb174","line":58,"range":{"start_line":58,"start_character":16,"end_line":58,"end_character":29},"updated":"2016-02-05 23:08:48.000000000","message":"Then wait_for_exist is set to True again","commit_id":"acca69ba0f75e89fa0d8013e0f2688c7c65df78f"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"97efe3a57d4bfdaccddccae9c5a22b35015f5642","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            pass"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # wait for a couple seconds to give the subprocesses a chance to shut down correctly."},{"line_number":63,"context_line":"    if wait_for_exit:"},{"line_number":64,"context_line":"        time.sleep(2)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # Kill everything, that didn\u0027t already die"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_4a0705ca","line":63,"range":{"start_line":63,"start_character":7,"end_line":63,"end_character":20},"updated":"2016-02-05 23:08:48.000000000","message":"Looks like no matter what path is taken, wait_for_exit \u003d True\n\nShoul","commit_id":"acca69ba0f75e89fa0d8013e0f2688c7c65df78f"}]}