)]}'
{"monasca_notification/common/repositories/mysql/mysql_repo.py":[{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"75edfa680771ea079398367b5b2f41555f275e97","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self._mysql \u003d None"},{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            self._mysql \u003d pymysql.connect(host\u003dself._mysql_host,"},{"line_number":46,"context_line":"                                          port\u003dself._mysql_port,"},{"line_number":47,"context_line":"                                          user\u003dself._mysql_user,"},{"line_number":48,"context_line":"                                          passwd\u003dunicode(self._mysql_passwd).encode(\u0027utf-8\u0027),"},{"line_number":49,"context_line":"                                          db\u003dself._mysql_dbname,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_ae06c3cb","line":46,"updated":"2016-03-02 15:35:42.000000000","message":"Is this going to work correctly when self._mysql_port is None? (i.e. the entry is not in the config file)\n\nLooking at the pymysql source, the default value for the port argument is 3306 (see https://github.com/PyMySQL/PyMySQL/blob/master/pymysql/connections.py#L530) - so passing in port\u003dNone will override that, and presumably the connection will fail...","commit_id":"f2ee1789993f4ff7be44a8cc844bf9d470ec6bda"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"7a65b3138ea22f91762582d2fdd300bcd185c871","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            # set it to the default value."},{"line_number":37,"context_line":"            #"},{"line_number":38,"context_line":"            self._mysql_port \u003d 3306"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self._mysql_host \u003d config[\u0027mysql\u0027][\u0027host\u0027]"},{"line_number":41,"context_line":"        self._mysql_user \u003d config[\u0027mysql\u0027][\u0027user\u0027]"},{"line_number":42,"context_line":"        self._mysql_passwd \u003d config[\u0027mysql\u0027][\u0027passwd\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_9f6b0cf1","line":39,"updated":"2016-03-03 02:53:19.000000000","message":"you might consider \nconfig[\u0027mysql\u0027].get(\u0027port\u0027, 3306)\nas a more concise way to say this.  Also, do you want / need to ensure it is an int?","commit_id":"f333f92709fa40f6bb519980df7f347231a6b666"}]}