)]}'
{"monasca_notification/common/utils.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"b195b50377d016bb82fb2352d6f21879af476b1b","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_statsd_client(config, dimensions\u003dNone):"},{"line_number":76,"context_line":"    if \u0027statsd\u0027 in config:"},{"line_number":77,"context_line":"        connection \u003d monascastatsd.Connection(host\u003dconfig[\u0027statsd\u0027].get(\u0027host\u0027, \u0027localhost\u0027),"},{"line_number":78,"context_line":"                                              port\u003dconfig[\u0027statsd\u0027].get(\u0027port\u0027, 8125))"},{"line_number":79,"context_line":"    else:"},{"line_number":80,"context_line":"        connection \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_2bf2dc6f","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":18},"updated":"2016-10-05 20:01:50.000000000","message":"I was wondering if it would be better to add a port keyword to the statsd client object?  This method seemed oddly cumbersome when I was reading the statsd code earlier.  I think it would be easier in general if people could just specify the port as part of the client.","commit_id":"79790a2b06195b0b13547c445fdb77c4d266bd6a"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"f3dfe8fde8e7628016b118bbb6a70522f4d533d7","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_statsd_client(config, dimensions\u003dNone):"},{"line_number":76,"context_line":"    if \u0027statsd\u0027 in config:"},{"line_number":77,"context_line":"        connection \u003d monascastatsd.Connection(host\u003dconfig[\u0027statsd\u0027].get(\u0027host\u0027, \u0027localhost\u0027),"},{"line_number":78,"context_line":"                                              port\u003dconfig[\u0027statsd\u0027].get(\u0027port\u0027, 8125))"},{"line_number":79,"context_line":"    else:"},{"line_number":80,"context_line":"        connection \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_517d0d1b","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":18},"in_reply_to":"1a95cdbc_2bf2dc6f","updated":"2016-10-06 06:10:43.000000000","message":"I agree, it would be better to specify those parameters: port and hosts as a part of the Client() not Connection().\nThere is a change for monasca-statsd with cleaning client.py.\nIt think those changes can be done there:\nhttps://review.openstack.org/#/c/356434/","commit_id":"79790a2b06195b0b13547c445fdb77c4d266bd6a"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"2394afbb8740d77d9b9a7c6b718f892f84438355","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        return stored_notification"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def get_statsd_client(config, dimensions\u003dNone):"},{"line_number":76,"context_line":"    client \u003d None"},{"line_number":77,"context_line":"    if \u0027statsd\u0027 in config:"},{"line_number":78,"context_line":"        client \u003d monascastatsd.Client(name\u003d\u0027monasca\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_005d35ec","line":75,"updated":"2016-11-30 05:11:09.000000000","message":"Is this unit-tested ? I think it should be.\n\nAlso from what I saw, usage of this method, I think we can safely assume that if dimensions would be None here we could assing it with BaseProcessor dimensions ? Or would it be hard because of something I didn\u0027t see ?","commit_id":"97a08a0a54abeae634f477b34b748bcea62aefe8"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"dcd0824664375b71d430882aee86e3fa4484c70b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        client \u003d monascastatsd.Client(name\u003d\u0027monasca\u0027,"},{"line_number":85,"context_line":"                                      host\u003dconfig[\u0027statsd\u0027].get(\u0027host\u0027, \u0027localhost\u0027),"},{"line_number":86,"context_line":"                                      port\u003dconfig[\u0027statsd\u0027].get(\u0027port\u0027, 8125),"},{"line_number":87,"context_line":"                                      dimensions\u003ddimensions)"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        client \u003d monascastatsd.Client(name\u003d\u0027monasca\u0027,"},{"line_number":90,"context_line":"                                      dimensions\u003ddimensions)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_3fca22a2","line":87,"range":{"start_line":87,"start_character":49,"end_line":87,"end_character":59},"updated":"2016-11-30 21:23:59.000000000","message":"instead of doing dimensions \u003d local_dims, you can use local_dims directly here.","commit_id":"c24f3340f6167a59e39a3dfd9dfcf27a4b4ff4f8"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"2e60863fa79ddeecb1ed80a9b2b933d013166998","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        client \u003d monascastatsd.Client(name\u003d\u0027monasca\u0027,"},{"line_number":85,"context_line":"                                      host\u003dconfig[\u0027statsd\u0027].get(\u0027host\u0027, \u0027localhost\u0027),"},{"line_number":86,"context_line":"                                      port\u003dconfig[\u0027statsd\u0027].get(\u0027port\u0027, 8125),"},{"line_number":87,"context_line":"                                      dimensions\u003ddimensions)"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        client \u003d monascastatsd.Client(name\u003d\u0027monasca\u0027,"},{"line_number":90,"context_line":"                                      dimensions\u003ddimensions)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_ea28d887","line":87,"range":{"start_line":87,"start_character":49,"end_line":87,"end_character":59},"in_reply_to":"5a74a57a_3fca22a2","updated":"2016-12-01 05:37:41.000000000","message":"Done","commit_id":"c24f3340f6167a59e39a3dfd9dfcf27a4b4ff4f8"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"dcd0824664375b71d430882aee86e3fa4484c70b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                                      dimensions\u003ddimensions)"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        client \u003d monascastatsd.Client(name\u003d\u0027monasca\u0027,"},{"line_number":90,"context_line":"                                      dimensions\u003ddimensions)"},{"line_number":91,"context_line":"    return client"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_5fcd1eb6","line":90,"range":{"start_line":90,"start_character":49,"end_line":90,"end_character":59},"updated":"2016-11-30 21:23:59.000000000","message":"same here","commit_id":"c24f3340f6167a59e39a3dfd9dfcf27a4b4ff4f8"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"2e60863fa79ddeecb1ed80a9b2b933d013166998","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                                      dimensions\u003ddimensions)"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        client \u003d monascastatsd.Client(name\u003d\u0027monasca\u0027,"},{"line_number":90,"context_line":"                                      dimensions\u003ddimensions)"},{"line_number":91,"context_line":"    return client"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_0a20b49a","line":90,"range":{"start_line":90,"start_character":49,"end_line":90,"end_character":59},"in_reply_to":"5a74a57a_5fcd1eb6","updated":"2016-12-01 05:37:41.000000000","message":"Done","commit_id":"c24f3340f6167a59e39a3dfd9dfcf27a4b4ff4f8"}],"monasca_notification/notification_engine.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"9b2c12e47e423886e84c46e07e108a54b0646739","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self._topics[\u0027notification_topic\u0027] \u003d config[\u0027kafka\u0027][\u0027notification_topic\u0027]"},{"line_number":33,"context_line":"        self._topics[\u0027retry_topic\u0027] \u003d config[\u0027kafka\u0027][\u0027notification_retry_topic\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        connection \u003d monascastatsd.Connection(host\u003dconfig[\u0027statsd\u0027][\u0027host\u0027],"},{"line_number":36,"context_line":"                                              port\u003dconfig[\u0027statsd\u0027][\u0027port\u0027])"},{"line_number":37,"context_line":"        self._statsd \u003d monascastatsd.Client(name\u003d\u0027monasca\u0027,"},{"line_number":38,"context_line":"                                            connection\u003dconnection,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_726eb5ca","line":35,"updated":"2016-10-05 11:02:14.000000000","message":"code right now got repeated all over again.\nmove creating client into utils of some kind, there should be something like this and reuse this method to get statsd client.","commit_id":"56a495f6829625f86db9d5fade8411972ad0b271"},{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"ffed78c2e912561fabdc7419a652dd9e17a757c2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self._topics[\u0027notification_topic\u0027] \u003d config[\u0027kafka\u0027][\u0027notification_topic\u0027]"},{"line_number":33,"context_line":"        self._topics[\u0027retry_topic\u0027] \u003d config[\u0027kafka\u0027][\u0027notification_retry_topic\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        connection \u003d monascastatsd.Connection(host\u003dconfig[\u0027statsd\u0027][\u0027host\u0027],"},{"line_number":36,"context_line":"                                              port\u003dconfig[\u0027statsd\u0027][\u0027port\u0027])"},{"line_number":37,"context_line":"        self._statsd \u003d monascastatsd.Client(name\u003d\u0027monasca\u0027,"},{"line_number":38,"context_line":"                                            connection\u003dconnection,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_1121ee4d","line":35,"in_reply_to":"1a95cdbc_726eb5ca","updated":"2016-10-05 11:43:10.000000000","message":"Done","commit_id":"56a495f6829625f86db9d5fade8411972ad0b271"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"e2dc93a59025864f779ab403625f11aa0023336a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from monasca_common.kafka.consumer import KafkaConsumer"},{"line_number":20,"context_line":"from monasca_common.kafka.producer import KafkaProducer"},{"line_number":21,"context_line":"from monasca_notification.common.utils import get_statsd_client"},{"line_number":22,"context_line":"from processors.alarm_processor import AlarmProcessor"},{"line_number":23,"context_line":"from processors.base import BaseProcessor"},{"line_number":24,"context_line":"from processors.notification_processor import NotificationProcessor"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_75de836e","line":21,"updated":"2016-10-05 18:59:10.000000000","message":"I know that code above imports specific type from the module but the rules of pep say that you should import modules. \n\nI don\u0027t remember if there\u0027s a change for that or if you\u0027d be willing to have that changed in another change, but just to keep in mind I\u0027d have this code followed by the pep.","commit_id":"79790a2b06195b0b13547c445fdb77c4d266bd6a"}]}