)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"20f4bcbc9ef58bc48a09d231ab36cfe883fdf165","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notification to Jira in custom description"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes possible to send notification to Jira"},{"line_number":10,"context_line":"in custom description (e.g. AlarmID)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib7f9a438a27f29b17967c31922391d76f8f0092f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_c7334ef6","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":36},"updated":"2017-07-20 06:57:11.000000000","message":"Is this a new feature or bug?","commit_id":"6c1298082b31743fa08937d18c575572cf2a3caa"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"a5b1ea54b9ebdc8b4ac6605c5402fe621972cd5a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notification to Jira in custom description"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes possible to send notification to Jira"},{"line_number":10,"context_line":"in custom description (e.g. AlarmID)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib7f9a438a27f29b17967c31922391d76f8f0092f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_5cf14c01","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":36},"in_reply_to":"1f1a1f67_0dc4c591","updated":"2017-07-20 10:10:12.000000000","message":"+1","commit_id":"6c1298082b31743fa08937d18c575572cf2a3caa"},{"author":{"_account_id":17981,"name":"Haruki Yamanashi","email":"h.yamanashi@jp.fujitsu.com","username":"Haruki"},"change_message_id":"26c056cacb747278278fbab02a705560c27420a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notification to Jira in custom description"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes possible to send notification to Jira"},{"line_number":10,"context_line":"in custom description (e.g. AlarmID)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib7f9a438a27f29b17967c31922391d76f8f0092f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_0dc4c591","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":36},"in_reply_to":"1f1a1f67_c2c33c38","updated":"2017-07-20 08:21:55.000000000","message":"So, is it better to change commit message which includes word \u0027fix\u0027 or like that?","commit_id":"6c1298082b31743fa08937d18c575572cf2a3caa"},{"author":{"_account_id":17981,"name":"Haruki Yamanashi","email":"h.yamanashi@jp.fujitsu.com","username":"Haruki"},"change_message_id":"cf05bd1f870082d3137316ad8672c7bee4f70f64","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notification to Jira in custom description"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes possible to send notification to Jira"},{"line_number":10,"context_line":"in custom description (e.g. AlarmID)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib7f9a438a27f29b17967c31922391d76f8f0092f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f1a1f67_c2c33c38","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":36},"in_reply_to":"1f1a1f67_c7334ef6","updated":"2017-07-20 08:16:20.000000000","message":"From the source code point of view, I think this is a bug.\n\nBecause custom description is defined in following.\nhttps://github.com/openstack/monasca-notification/blob/master/monasca_notification/plugins/jira_notifier.py#L110-L113\n\nBut actually, description is hard-coded with \u0027Monasca alaram\u0027.\nhttps://github.com/openstack/monasca-notification/blob/master/monasca_notification/plugins/jira_notifier.py#L186\n\nI think \u0027Monasca alaram\u0027 is default description and it should can be changed.","commit_id":"6c1298082b31743fa08937d18c575572cf2a3caa"}],"monasca_notification/plugins/jira_notifier.py":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"20f4bcbc9ef58bc48a09d231ab36cfe883fdf165","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                                                              notification.state,"},{"line_number":135,"context_line":"                                                              notification.alarm_id)"},{"line_number":136,"context_line":"        jira_fields[\"comments\"] \u003d \"{code}%s{code}\" % (json.dumps(body, indent\u003d3))"},{"line_number":137,"context_line":"        jira_fields[\"description\"] \u003d \u0027Monasca alaram\u0027"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        return jira_fields"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_277322b4","line":137,"range":{"start_line":137,"start_character":46,"end_line":137,"end_character":52},"updated":"2017-07-20 06:57:11.000000000","message":"alarm\n\nIn addition, is this description hard-coded?","commit_id":"6c1298082b31743fa08937d18c575572cf2a3caa"},{"author":{"_account_id":17981,"name":"Haruki Yamanashi","email":"h.yamanashi@jp.fujitsu.com","username":"Haruki"},"change_message_id":"02b0204598a4788ec57acdcec336bc49d7fac343","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                                                              notification.state,"},{"line_number":135,"context_line":"                                                              notification.alarm_id)"},{"line_number":136,"context_line":"        jira_fields[\"comments\"] \u003d \"{code}%s{code}\" % (json.dumps(body, indent\u003d3))"},{"line_number":137,"context_line":"        jira_fields[\"description\"] \u003d \u0027Monasca alaram\u0027"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        return jira_fields"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_cda92d25","line":137,"range":{"start_line":137,"start_character":46,"end_line":137,"end_character":52},"in_reply_to":"1f1a1f67_277322b4","updated":"2017-07-20 08:41:55.000000000","message":"I think hard-coded description as default is OK because Jira user can simply see that the issue is created by Monasca from this default description.","commit_id":"6c1298082b31743fa08937d18c575572cf2a3caa"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"a5b1ea54b9ebdc8b4ac6605c5402fe621972cd5a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                                                              notification.state,"},{"line_number":135,"context_line":"                                                              notification.alarm_id)"},{"line_number":136,"context_line":"        jira_fields[\"comments\"] \u003d \"{code}%s{code}\" % (json.dumps(body, indent\u003d3))"},{"line_number":137,"context_line":"        jira_fields[\"description\"] \u003d \u0027Monasca alaram\u0027"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        return jira_fields"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_dc6b1c83","line":137,"range":{"start_line":137,"start_character":46,"end_line":137,"end_character":52},"in_reply_to":"1f1a1f67_cda92d25","updated":"2017-07-20 10:10:12.000000000","message":"I understood that was default value.","commit_id":"6c1298082b31743fa08937d18c575572cf2a3caa"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"bd0915a121838a1e59c885ac757d24de4a398f8c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            self._log.debug(\"Found an existing issue {} for this notification\".format(issue))"},{"line_number":203,"context_line":"            current_state \u003d issue.fields.status.name"},{"line_number":204,"context_line":"            if current_state.lower() in [\"resolved\", \"closed\"]:"},{"line_number":205,"context_line":"                # Open the issue"},{"line_number":206,"context_line":"                transitions \u003d jira_obj.transitions(issue)"},{"line_number":207,"context_line":"                allowed_transistions \u003d [(t[\u0027id\u0027], t[\u0027name\u0027]) for t in transitions if \"reopen\" in t[\u0027name\u0027].lower()]"},{"line_number":208,"context_line":"                if allowed_transistions:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_575554c5","line":205,"range":{"start_line":205,"start_character":15,"end_line":205,"end_character":32},"updated":"2017-07-26 05:14:42.000000000","message":"Unrelated change","commit_id":"a9600f7c93ea899ad4610357d94db22cb08af43b"},{"author":{"_account_id":17981,"name":"Haruki Yamanashi","email":"h.yamanashi@jp.fujitsu.com","username":"Haruki"},"change_message_id":"cb7c5b3e78dcff8afc06bf55f691a95acb8975dd","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            self._log.debug(\"Found an existing issue {} for this notification\".format(issue))"},{"line_number":203,"context_line":"            current_state \u003d issue.fields.status.name"},{"line_number":204,"context_line":"            if current_state.lower() in [\"resolved\", \"closed\"]:"},{"line_number":205,"context_line":"                # Open the issue"},{"line_number":206,"context_line":"                transitions \u003d jira_obj.transitions(issue)"},{"line_number":207,"context_line":"                allowed_transistions \u003d [(t[\u0027id\u0027], t[\u0027name\u0027]) for t in transitions if \"reopen\" in t[\u0027name\u0027].lower()]"},{"line_number":208,"context_line":"                if allowed_transistions:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_37c1b02f","line":205,"range":{"start_line":205,"start_character":15,"end_line":205,"end_character":32},"in_reply_to":"ff346bd7_575554c5","updated":"2017-07-26 05:25:54.000000000","message":"OK, I will fix this in the other patch.","commit_id":"a9600f7c93ea899ad4610357d94db22cb08af43b"}],"tests/test_jira_notification.py":[{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"25b957866b9843c51c4565d5617eee433886d62a","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def issue(component\u003dTrue, custom_config\u003dFalse):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    issue \u003d {\u0027fields\u0027: {\u0027description\u0027: \u0027Monasca alaram\u0027,"},{"line_number":45,"context_line":"                        \u0027issuetype\u0027: {\u0027name\u0027: \u0027Bug\u0027},"},{"line_number":46,"context_line":"                        \u0027project\u0027: {\u0027key\u0027: \u0027MyProject\u0027},"},{"line_number":47,"context_line":"                        \u0027summary\u0027: \u0027Monasca alarm for alarm_defintion test Alarm status \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_e7f40a8a","line":44,"range":{"start_line":44,"start_character":48,"end_line":44,"end_character":54},"updated":"2017-07-20 07:14:56.000000000","message":"typo. should be alarm","commit_id":"6c1298082b31743fa08937d18c575572cf2a3caa"},{"author":{"_account_id":17981,"name":"Haruki Yamanashi","email":"h.yamanashi@jp.fujitsu.com","username":"Haruki"},"change_message_id":"a00c2ea01cc8ad2dfae414bd268e5da1669d2249","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def issue(component\u003dTrue, custom_config\u003dFalse):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    issue \u003d {\u0027fields\u0027: {\u0027description\u0027: \u0027Monasca alaram\u0027,"},{"line_number":45,"context_line":"                        \u0027issuetype\u0027: {\u0027name\u0027: \u0027Bug\u0027},"},{"line_number":46,"context_line":"                        \u0027project\u0027: {\u0027key\u0027: \u0027MyProject\u0027},"},{"line_number":47,"context_line":"                        \u0027summary\u0027: \u0027Monasca alarm for alarm_defintion test Alarm status \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_ad02710a","line":44,"range":{"start_line":44,"start_character":48,"end_line":44,"end_character":54},"in_reply_to":"1f1a1f67_e7f40a8a","updated":"2017-07-20 08:44:28.000000000","message":"Done","commit_id":"6c1298082b31743fa08937d18c575572cf2a3caa"}]}