)]}'
{"README.md":[{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Notification Engine"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This engine reads alarms from Kafka and then notifies the customer using their configured notification method."},{"line_number":11,"context_line":"Multiple notification and retry engines can run in parallel up to one per available Kafka partition.  Zookeeper"},{"line_number":12,"context_line":"is used to negotiate access to the Kafka partitions whenever a new process joins or leaves the working set."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_a96b8aee","line":10,"range":{"start_line":10,"start_character":73,"end_line":10,"end_character":78},"updated":"2018-05-15 13:36:30.000000000","message":"the","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Notification Engine"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This engine reads alarms from Kafka and then notifies the customer using their configured notification method."},{"line_number":11,"context_line":"Multiple notification and retry engines can run in parallel up to one per available Kafka partition.  Zookeeper"},{"line_number":12,"context_line":"is used to negotiate access to the Kafka partitions whenever a new process joins or leaves the working set."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_8e89dd75","line":10,"range":{"start_line":10,"start_character":73,"end_line":10,"end_character":78},"in_reply_to":"5f7c97a3_a96b8aee","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Notification Engine"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This engine reads alarms from Kafka and then notifies the customer using their configured notification method."},{"line_number":11,"context_line":"Multiple notification and retry engines can run in parallel up to one per available Kafka partition.  Zookeeper"},{"line_number":12,"context_line":"is used to negotiate access to the Kafka partitions whenever a new process joins or leaves the working set."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Architecture"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_e94e6295","line":11,"range":{"start_line":11,"start_character":100,"end_line":11,"end_character":102},"updated":"2018-05-15 13:36:30.000000000","message":"#remove blank","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Notification Engine"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This engine reads alarms from Kafka and then notifies the customer using their configured notification method."},{"line_number":11,"context_line":"Multiple notification and retry engines can run in parallel up to one per available Kafka partition.  Zookeeper"},{"line_number":12,"context_line":"is used to negotiate access to the Kafka partitions whenever a new process joins or leaves the working set."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Architecture"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_89748ed0","line":11,"range":{"start_line":11,"start_character":51,"end_line":11,"end_character":59},"updated":"2018-05-15 13:36:30.000000000","message":"parallel,","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Notification Engine"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This engine reads alarms from Kafka and then notifies the customer using their configured notification method."},{"line_number":11,"context_line":"Multiple notification and retry engines can run in parallel up to one per available Kafka partition.  Zookeeper"},{"line_number":12,"context_line":"is used to negotiate access to the Kafka partitions whenever a new process joins or leaves the working set."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Architecture"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_2e7c4970","line":11,"range":{"start_line":11,"start_character":51,"end_line":11,"end_character":59},"in_reply_to":"5f7c97a3_89748ed0","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Notification Engine"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This engine reads alarms from Kafka and then notifies the customer using their configured notification method."},{"line_number":11,"context_line":"Multiple notification and retry engines can run in parallel up to one per available Kafka partition.  Zookeeper"},{"line_number":12,"context_line":"is used to negotiate access to the Kafka partitions whenever a new process joins or leaves the working set."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Architecture"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_4e7f4565","line":11,"range":{"start_line":11,"start_character":100,"end_line":11,"end_character":102},"in_reply_to":"5f7c97a3_e94e6295","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Architecture"},{"line_number":15,"context_line":"The notification engine generates notifications using the following steps:"},{"line_number":16,"context_line":"1. Reads Alarms from Kafka, with no auto commit. -"},{"line_number":17,"context_line":"   monasca_common.kafka.KafkaConsumer class"},{"line_number":18,"context_line":"2. Determine notification type for an alarm. Done by reading from mysql. - AlarmProcessor class"},{"line_number":19,"context_line":"3. Send Notification. - NotificationProcessor class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_2958da53","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":15},"updated":"2018-05-15 13:36:30.000000000","message":"Read alarms","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Architecture"},{"line_number":15,"context_line":"The notification engine generates notifications using the following steps:"},{"line_number":16,"context_line":"1. Reads Alarms from Kafka, with no auto commit. -"},{"line_number":17,"context_line":"   monasca_common.kafka.KafkaConsumer class"},{"line_number":18,"context_line":"2. Determine notification type for an alarm. Done by reading from mysql. - AlarmProcessor class"},{"line_number":19,"context_line":"3. Send Notification. - NotificationProcessor class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_ee9971c3","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":15},"in_reply_to":"5f7c97a3_2958da53","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"1. Reads Alarms from Kafka, with no auto commit. -"},{"line_number":17,"context_line":"   monasca_common.kafka.KafkaConsumer class"},{"line_number":18,"context_line":"2. Determine notification type for an alarm. Done by reading from mysql. - AlarmProcessor class"},{"line_number":19,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":20,"context_line":"4. Successful notifications are added to a sent notification topic. - NotificationEngine class"},{"line_number":21,"context_line":"5. Failed notifications are added to a retry topic. - NotificationEngine class"},{"line_number":22,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_e933c212","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":20},"updated":"2018-05-15 13:36:30.000000000","message":"notification","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":16,"context_line":"1. Reads Alarms from Kafka, with no auto commit. -"},{"line_number":17,"context_line":"   monasca_common.kafka.KafkaConsumer class"},{"line_number":18,"context_line":"2. Determine notification type for an alarm. Done by reading from mysql. - AlarmProcessor class"},{"line_number":19,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":20,"context_line":"4. Successful notifications are added to a sent notification topic. - NotificationEngine class"},{"line_number":21,"context_line":"5. Failed notifications are added to a retry topic. - NotificationEngine class"},{"line_number":22,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_0e95cd86","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":20},"in_reply_to":"5f7c97a3_e933c212","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   monasca_common.kafka.KafkaConsumer class"},{"line_number":18,"context_line":"2. Determine notification type for an alarm. Done by reading from mysql. - AlarmProcessor class"},{"line_number":19,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":20,"context_line":"4. Successful notifications are added to a sent notification topic. - NotificationEngine class"},{"line_number":21,"context_line":"5. Failed notifications are added to a retry topic. - NotificationEngine class"},{"line_number":22,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_89224eb8","line":20,"range":{"start_line":20,"start_character":3,"end_line":20,"end_character":37},"updated":"2018-05-15 13:36:30.000000000","message":"Add successful notifications","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   monasca_common.kafka.KafkaConsumer class"},{"line_number":18,"context_line":"2. Determine notification type for an alarm. Done by reading from mysql. - AlarmProcessor class"},{"line_number":19,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":20,"context_line":"4. Successful notifications are added to a sent notification topic. - NotificationEngine class"},{"line_number":21,"context_line":"5. Failed notifications are added to a retry topic. - NotificationEngine class"},{"line_number":22,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_ae8ff972","line":20,"range":{"start_line":20,"start_character":3,"end_line":20,"end_character":37},"in_reply_to":"5f7c97a3_89224eb8","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"2. Determine notification type for an alarm. Done by reading from mysql. - AlarmProcessor class"},{"line_number":19,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":20,"context_line":"4. Successful notifications are added to a sent notification topic. - NotificationEngine class"},{"line_number":21,"context_line":"5. Failed notifications are added to a retry topic. - NotificationEngine class"},{"line_number":22,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The notification engine uses three Kafka topics:"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_e91c2279","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":33},"updated":"2018-05-15 13:36:30.000000000","message":"Add failed notifications","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":18,"context_line":"2. Determine notification type for an alarm. Done by reading from mysql. - AlarmProcessor class"},{"line_number":19,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":20,"context_line":"4. Successful notifications are added to a sent notification topic. - NotificationEngine class"},{"line_number":21,"context_line":"5. Failed notifications are added to a retry topic. - NotificationEngine class"},{"line_number":22,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The notification engine uses three Kafka topics:"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_ce8a7562","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":33},"in_reply_to":"5f7c97a3_e91c2279","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"The notification engine uses three Kafka topics:"},{"line_number":25,"context_line":"1. alarm_topic: Alarms inbound to the notification engine."},{"line_number":26,"context_line":"2. notification_topic: Successfully sent notifications."},{"line_number":27,"context_line":"3. notification_retry_topic: Unsuccessful notifications."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"A retry engine runs in parallel with the notification engine and gives any"},{"line_number":30,"context_line":"failed notification a configurable number of extra chances at succeess."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_69101258","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":41},"updated":"2018-05-15 13:36:30.000000000","message":"Failed","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":24,"context_line":"The notification engine uses three Kafka topics:"},{"line_number":25,"context_line":"1. alarm_topic: Alarms inbound to the notification engine."},{"line_number":26,"context_line":"2. notification_topic: Successfully sent notifications."},{"line_number":27,"context_line":"3. notification_retry_topic: Unsuccessful notifications."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"A retry engine runs in parallel with the notification engine and gives any"},{"line_number":30,"context_line":"failed notification a configurable number of extra chances at succeess."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_6eeb2112","line":27,"range":{"start_line":27,"start_character":29,"end_line":27,"end_character":41},"in_reply_to":"5f7c97a3_69101258","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"3. notification_retry_topic: Unsuccessful notifications."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"A retry engine runs in parallel with the notification engine and gives any"},{"line_number":30,"context_line":"failed notification a configurable number of extra chances at succeess."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The retry engine generates notifications using the following steps:"},{"line_number":33,"context_line":"1. Reads Notification json data from Kafka, with no auto commit. - KafkaConsumer class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_d1047017","line":30,"range":{"start_line":30,"start_character":62,"end_line":30,"end_character":70},"updated":"2018-05-15 13:36:30.000000000","message":"success","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":27,"context_line":"3. notification_retry_topic: Unsuccessful notifications."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"A retry engine runs in parallel with the notification engine and gives any"},{"line_number":30,"context_line":"failed notification a configurable number of extra chances at succeess."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The retry engine generates notifications using the following steps:"},{"line_number":33,"context_line":"1. Reads Notification json data from Kafka, with no auto commit. - KafkaConsumer class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_8eeebd1f","line":30,"range":{"start_line":30,"start_character":62,"end_line":30,"end_character":70},"in_reply_to":"5f7c97a3_d1047017","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"failed notification a configurable number of extra chances at succeess."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The retry engine generates notifications using the following steps:"},{"line_number":33,"context_line":"1. Reads Notification json data from Kafka, with no auto commit. - KafkaConsumer class"},{"line_number":34,"context_line":"2. Rebuild the notification that failed. - RetryEngine class"},{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_3115a440","line":33,"range":{"start_line":33,"start_character":3,"end_line":33,"end_character":21},"updated":"2018-05-15 13:36:30.000000000","message":"Read notification","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":30,"context_line":"failed notification a configurable number of extra chances at succeess."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The retry engine generates notifications using the following steps:"},{"line_number":33,"context_line":"1. Reads Notification json data from Kafka, with no auto commit. - KafkaConsumer class"},{"line_number":34,"context_line":"2. Rebuild the notification that failed. - RetryEngine class"},{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_2ef1a901","line":33,"range":{"start_line":33,"start_character":3,"end_line":33,"end_character":21},"in_reply_to":"5f7c97a3_3115a440","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"The retry engine generates notifications using the following steps:"},{"line_number":33,"context_line":"1. Reads Notification json data from Kafka, with no auto commit. - KafkaConsumer class"},{"line_number":34,"context_line":"2. Rebuild the notification that failed. - RetryEngine class"},{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_d12d5095","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":20},"updated":"2018-05-15 13:36:30.000000000","message":"notification","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":32,"context_line":"The retry engine generates notifications using the following steps:"},{"line_number":33,"context_line":"1. Reads Notification json data from Kafka, with no auto commit. - KafkaConsumer class"},{"line_number":34,"context_line":"2. Rebuild the notification that failed. - RetryEngine class"},{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_4ef425f1","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":20},"in_reply_to":"5f7c97a3_d12d5095","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"1. Reads Notification json data from Kafka, with no auto commit. - KafkaConsumer class"},{"line_number":34,"context_line":"2. Rebuild the notification that failed. - RetryEngine class"},{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"},{"line_number":39,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_112f4888","line":36,"range":{"start_line":36,"start_character":3,"end_line":36,"end_character":36},"updated":"2018-05-15 13:36:30.000000000","message":"Add successful notifications","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":33,"context_line":"1. Reads Notification json data from Kafka, with no auto commit. - KafkaConsumer class"},{"line_number":34,"context_line":"2. Rebuild the notification that failed. - RetryEngine class"},{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"},{"line_number":39,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_aee4d93c","line":36,"range":{"start_line":36,"start_character":3,"end_line":36,"end_character":36},"in_reply_to":"5f7c97a3_112f4888","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"2. Rebuild the notification that failed. - RetryEngine class"},{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"},{"line_number":39,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_31436444","line":37,"range":{"start_line":37,"start_character":3,"end_line":37,"end_character":67},"updated":"2018-05-15 13:36:30.000000000","message":"Add failed notifications that have not hit the retry limit","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":34,"context_line":"2. Rebuild the notification that failed. - RetryEngine class"},{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"},{"line_number":39,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_6ed48148","line":37,"range":{"start_line":37,"start_character":3,"end_line":37,"end_character":67},"in_reply_to":"5f7c97a3_31436444","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"},{"line_number":39,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The retry engine uses two Kafka topics:"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_11442846","line":38,"range":{"start_line":38,"start_character":3,"end_line":38,"end_character":67},"updated":"2018-05-15 13:36:30.000000000","message":"Discard failed notifications that have hit the retry limit","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":35,"context_line":"3. Send Notification. - NotificationProcessor class"},{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"},{"line_number":39,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The retry engine uses two Kafka topics:"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_8ed79d4b","line":38,"range":{"start_line":38,"start_character":3,"end_line":38,"end_character":67},"in_reply_to":"5f7c97a3_11442846","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"},{"line_number":39,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The retry engine uses two Kafka topics:"},{"line_number":42,"context_line":"1. notification_retry_topic: Notifications that need to be retried."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_d17b1089","line":39,"range":{"start_line":39,"start_character":20,"end_line":39,"end_character":25},"updated":"2018-05-15 13:36:30.000000000","message":"Kafka.","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":36,"context_line":"4. Successful notifictions are added to a sent notification topic. - RetryEngine class"},{"line_number":37,"context_line":"5. Failed notifications that have not hit the retry limit are added back to the retry topic. - RetryEngine class"},{"line_number":38,"context_line":"6. Failed notifications that have hit the retry limit are discarded. - RetryEngine class"},{"line_number":39,"context_line":"6. Commit offset to Kafka - KafkaConsumer class"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The retry engine uses two Kafka topics:"},{"line_number":42,"context_line":"1. notification_retry_topic: Notifications that need to be retried."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_2eca09a0","line":39,"range":{"start_line":39,"start_character":20,"end_line":39,"end_character":25},"in_reply_to":"5f7c97a3_d17b1089","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"2. notification_topic: Successfully sent notifications."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"## Fault Tolerance"},{"line_number":46,"context_line":"When reading from the alarm topic no committing is done. The committing is done only after processing. This allows"},{"line_number":47,"context_line":"the processing to continue even though some notifications can be slow. In the event of a catastrophic failure some"},{"line_number":48,"context_line":"notifications could be sent but the alarms not yet acknowledged. This is an acceptable failure mode, better to send a"},{"line_number":49,"context_line":"notification twice than not at all."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_31b12448","line":46,"range":{"start_line":46,"start_character":28,"end_line":46,"end_character":33},"updated":"2018-05-15 13:36:30.000000000","message":"topic,","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":43,"context_line":"2. notification_topic: Successfully sent notifications."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"## Fault Tolerance"},{"line_number":46,"context_line":"When reading from the alarm topic no committing is done. The committing is done only after processing. This allows"},{"line_number":47,"context_line":"the processing to continue even though some notifications can be slow. In the event of a catastrophic failure some"},{"line_number":48,"context_line":"notifications could be sent but the alarms not yet acknowledged. This is an acceptable failure mode, better to send a"},{"line_number":49,"context_line":"notification twice than not at all."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_4ecd05b5","line":46,"range":{"start_line":46,"start_character":28,"end_line":46,"end_character":33},"in_reply_to":"5f7c97a3_31b12448","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"## Fault Tolerance"},{"line_number":46,"context_line":"When reading from the alarm topic no committing is done. The committing is done only after processing. This allows"},{"line_number":47,"context_line":"the processing to continue even though some notifications can be slow. In the event of a catastrophic failure some"},{"line_number":48,"context_line":"notifications could be sent but the alarms not yet acknowledged. This is an acceptable failure mode, better to send a"},{"line_number":49,"context_line":"notification twice than not at all."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_b1869465","line":47,"range":{"start_line":47,"start_character":58,"end_line":47,"end_character":64},"updated":"2018-05-15 13:36:30.000000000","message":"are ? not sure","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"## Fault Tolerance"},{"line_number":46,"context_line":"When reading from the alarm topic no committing is done. The committing is done only after processing. This allows"},{"line_number":47,"context_line":"the processing to continue even though some notifications can be slow. In the event of a catastrophic failure some"},{"line_number":48,"context_line":"notifications could be sent but the alarms not yet acknowledged. This is an acceptable failure mode, better to send a"},{"line_number":49,"context_line":"notification twice than not at all."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_0ec38d8a","line":47,"range":{"start_line":47,"start_character":58,"end_line":47,"end_character":64},"in_reply_to":"5f7c97a3_b1869465","updated":"2018-05-16 09:42:52.000000000","message":"left as is","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"## Fault Tolerance"},{"line_number":46,"context_line":"When reading from the alarm topic no committing is done. The committing is done only after processing. This allows"},{"line_number":47,"context_line":"the processing to continue even though some notifications can be slow. In the event of a catastrophic failure some"},{"line_number":48,"context_line":"notifications could be sent but the alarms not yet acknowledged. This is an acceptable failure mode, better to send a"},{"line_number":49,"context_line":"notification twice than not at all."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The general process when a major error is encountered is to exit the daemon which should allow the other processes to"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_f18f2c72","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"updated":"2018-05-15 13:36:30.000000000","message":"have not yet been","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":45,"context_line":"## Fault Tolerance"},{"line_number":46,"context_line":"When reading from the alarm topic no committing is done. The committing is done only after processing. This allows"},{"line_number":47,"context_line":"the processing to continue even though some notifications can be slow. In the event of a catastrophic failure some"},{"line_number":48,"context_line":"notifications could be sent but the alarms not yet acknowledged. This is an acceptable failure mode, better to send a"},{"line_number":49,"context_line":"notification twice than not at all."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The general process when a major error is encountered is to exit the daemon which should allow the other processes to"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_aebdb902","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"in_reply_to":"5f7c97a3_f18f2c72","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"notification twice than not at all."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The general process when a major error is encountered is to exit the daemon which should allow the other processes to"},{"line_number":52,"context_line":"renegotiate access to the Kafka partitions.  It is also assumed the notification engine will be run by a process"},{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_71f1dc00","line":52,"range":{"start_line":52,"start_character":64,"end_line":52,"end_character":67},"updated":"2018-05-15 13:36:30.000000000","message":"that the","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":49,"context_line":"notification twice than not at all."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The general process when a major error is encountered is to exit the daemon which should allow the other processes to"},{"line_number":52,"context_line":"renegotiate access to the Kafka partitions.  It is also assumed the notification engine will be run by a process"},{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_ceb83512","line":52,"range":{"start_line":52,"start_character":64,"end_line":52,"end_character":67},"in_reply_to":"5f7c97a3_71f1dc00","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The general process when a major error is encountered is to exit the daemon which should allow the other processes to"},{"line_number":52,"context_line":"renegotiate access to the Kafka partitions.  It is also assumed the notification engine will be run by a process"},{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_51daa077","line":53,"range":{"start_line":53,"start_character":55,"end_line":53,"end_character":63},"updated":"2018-05-15 13:36:30.000000000","message":"In this way,","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"The general process when a major error is encountered is to exit the daemon which should allow the other processes to"},{"line_number":52,"context_line":"renegotiate access to the Kafka partitions.  It is also assumed the notification engine will be run by a process"},{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_6e39e1a1","line":53,"range":{"start_line":53,"start_character":55,"end_line":53,"end_character":63},"in_reply_to":"5f7c97a3_51daa077","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_31c844a4","line":56,"range":{"start_line":56,"start_character":67,"end_line":56,"end_character":70},"updated":"2018-05-15 13:36:30.000000000","message":"a set","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_71ca3ca1","line":56,"range":{"start_line":56,"start_character":29,"end_line":56,"end_character":35},"updated":"2018-05-15 13:36:30.000000000","message":"errors,","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_11b98813","line":56,"range":{"start_line":56,"start_character":45,"end_line":56,"end_character":49},"updated":"2018-05-15 13:36:30.000000000","message":"the risk","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_4e42e510","line":56,"range":{"start_line":56,"start_character":45,"end_line":56,"end_character":49},"in_reply_to":"5f7c97a3_11b98813","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_ae5299dc","line":56,"range":{"start_line":56,"start_character":67,"end_line":56,"end_character":70},"in_reply_to":"5f7c97a3_31c844a4","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":53,"context_line":"supervisor which will restart it in case of a failure. This way any errors which are not easy to recover from are"},{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_6e6241b0","line":56,"range":{"start_line":56,"start_character":29,"end_line":56,"end_character":35},"in_reply_to":"5f7c97a3_71ca3ca1","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."},{"line_number":60,"context_line":"- An alarm TTL is utilized. Any alarm older than the TTL is not processed."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_b139b4a4","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":4},"updated":"2018-05-15 13:36:30.000000000","message":"are sent","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":54,"context_line":"automatically handled by the service restarting and the active daemon switching to another instance."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."},{"line_number":60,"context_line":"- An alarm TTL is utilized. Any alarm older than the TTL is not processed."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_8e655db7","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":4},"in_reply_to":"5f7c97a3_b139b4a4","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."},{"line_number":60,"context_line":"- An alarm TTL is utilized. Any alarm older than the TTL is not processed."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Operation"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_f152ccdd","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":31},"updated":"2018-05-15 13:36:30.000000000","message":"for","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Though this should cover all errors there is risk that an alarm or set of alarms can be processed and notifications"},{"line_number":57,"context_line":"sent out multiple times. To minimize this risk a number of techniques are used:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- Timeouts are implemented with all notification types."},{"line_number":60,"context_line":"- An alarm TTL is utilized. Any alarm older than the TTL is not processed."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Operation"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_2e58c9f7","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":31},"in_reply_to":"5f7c97a3_f152ccdd","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"```"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"## Monitoring"},{"line_number":72,"context_line":"statsd is incorporated into the daemon and will send all stats to statsd server launched by monasca-agent."},{"line_number":73,"context_line":"Default host and port points at **localhost:8125**."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Counters"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_3124c45d","line":72,"range":{"start_line":72,"start_character":63,"end_line":72,"end_character":65},"updated":"2018-05-15 13:36:30.000000000","message":"to the","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":69,"context_line":"```"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"## Monitoring"},{"line_number":72,"context_line":"statsd is incorporated into the daemon and will send all stats to statsd server launched by monasca-agent."},{"line_number":73,"context_line":"Default host and port points at **localhost:8125**."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- Counters"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_4e5bc5f4","line":72,"range":{"start_line":72,"start_character":63,"end_line":72,"end_character":65},"in_reply_to":"5f7c97a3_3124c45d","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16323,"name":"Silke Herrmann","email":"silke.herrmann@est.fujitsu.com","username":"herrmann"},"change_message_id":"93627f4cd6fdf0c3bdc4e58205048d656a09f4eb","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    - SendNotificationTime"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Future Considerations"},{"line_number":92,"context_line":"- More extensive load testing is needed"},{"line_number":93,"context_line":"  - How fast is the mysql db? How much load do we put on it. Initially I think it makes most sense to read notification"},{"line_number":94,"context_line":"    details for each alarm but eventually I may want to cache that info."},{"line_number":95,"context_line":"  - How expensive are commits to Kafka for every message we read?  Should we commit every N messages?"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_31e924e5","line":92,"range":{"start_line":92,"start_character":33,"end_line":92,"end_character":39},"updated":"2018-05-15 13:36:30.000000000","message":"needed:","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    - SendNotificationTime"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Future Considerations"},{"line_number":92,"context_line":"- More extensive load testing is needed"},{"line_number":93,"context_line":"  - How fast is the mysql db? How much load do we put on it. Initially I think it makes most sense to read notification"},{"line_number":94,"context_line":"    details for each alarm but eventually I may want to cache that info."},{"line_number":95,"context_line":"  - How expensive are commits to Kafka for every message we read?  Should we commit every N messages?"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_ae6b7982","line":92,"range":{"start_line":92,"start_character":33,"end_line":92,"end_character":39},"in_reply_to":"5f7c97a3_31e924e5","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"change_message_id":"0234838c52b8c77ac59c953539c9e050518656b0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    http server.  Is that fast enough?"},{"line_number":99,"context_line":"  - Are we putting too much load on Kafka at ~200 commits per second?"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# License"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_b0944538","line":101,"updated":"2018-05-15 20:41:19.000000000","message":"Do we need this license? I think we can remove it.","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"3f7ca16c88acdf815df268e3bfeb335373eea982","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    http server.  Is that fast enough?"},{"line_number":99,"context_line":"  - Are we putting too much load on Kafka at ~200 commits per second?"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# License"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"5f7c97a3_ce66f5bb","line":101,"in_reply_to":"5f7c97a3_b0944538","updated":"2018-05-16 09:42:52.000000000","message":"Done","commit_id":"ab955fb268e07319e234547a512c8acaa7d8aef7"},{"author":{"_account_id":27191,"name":"Denis Poisson","email":"denis.poisson@ts.fujitsu.com","username":"denis.poisson"},"change_message_id":"035bbed1853c5293fd23621debf8ff5c04f05f02","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"## Monitoring"},{"line_number":80,"context_line":"StatsD is incorporated into the daemon and will send all stats to the StatsD"},{"line_number":81,"context_line":"server launched by monasca-agent. Default host and port points at"},{"line_number":82,"context_line":"**localhost:8125**."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"- Counters"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"5f7c97a3_b4c3cc37","line":81,"range":{"start_line":81,"start_character":63,"end_line":81,"end_character":65},"updated":"2018-05-16 12:06:55.000000000","message":"\u0027points to\u0027 is better here (indication of direction, not aggressive gesture)","commit_id":"0a48c157c83671ec1610bd37518fd537224e14c3"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"985b6af03bb73be71e35150108473e88790ba2a0","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"## Monitoring"},{"line_number":80,"context_line":"StatsD is incorporated into the daemon and will send all stats to the StatsD"},{"line_number":81,"context_line":"server launched by monasca-agent. Default host and port points at"},{"line_number":82,"context_line":"**localhost:8125**."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"- Counters"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"5f7c97a3_8e868bba","line":81,"range":{"start_line":81,"start_character":63,"end_line":81,"end_character":65},"in_reply_to":"5f7c97a3_b4c3cc37","updated":"2018-06-05 12:47:46.000000000","message":"Done","commit_id":"0a48c157c83671ec1610bd37518fd537224e14c3"}]}
