)]}'
{"docker/Dockerfile":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"16b31e05f3c6ce5152923645c825087c6a8121d1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG DOCKER_IMAGE\u003dmonasca-notification"},{"line_number":2,"context_line":"ARG APP_REPO\u003dhttps://git.openstack.org/openstack/monasca-notification"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Branch, tag or git hash to build from."}],"source_content_type":"text/x-dockerfile","patch_set":8,"id":"3f79a3b5_781be07e","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":37},"updated":"2018-10-04 13:59:55.000000000","message":"Running ./build_image.sh results with the image named `monasca-notification:master`. Shouldn\u0027t that be `monasca/notification:master` to keep the existing naming?","commit_id":"56d81e9d78bcd744fdf18040caaab971f730d99b"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"741b13fb193c4d1df22b89a550301289c859f448","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ARG DOCKER_IMAGE\u003dmonasca-notification"},{"line_number":2,"context_line":"ARG APP_REPO\u003dhttps://git.openstack.org/openstack/monasca-notification"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Branch, tag or git hash to build from."}],"source_content_type":"text/x-dockerfile","patch_set":8,"id":"3f79a3b5_6ddea83d","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":37},"in_reply_to":"3f79a3b5_781be07e","updated":"2018-10-05 13:43:47.000000000","message":"Done","commit_id":"56d81e9d78bcd744fdf18040caaab971f730d99b"}],"docker/README.rst":[{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"9f7eef5532ed847b72e8268323a10670b0d06e1f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"See https://github.com/openstack/monasca-common/tree/master/docker/README.rst"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Building Monasca notification image (child)"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_82610214","line":12,"range":{"start_line":12,"start_character":37,"end_line":12,"end_character":42},"updated":"2018-09-19 07:38:45.000000000","message":"Child word is unnecessary.","commit_id":"75baf74afad9859d5688591f0c6e238e223bb3eb"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"852fc6bc732dedcde7e9db3af32e6665d02d93b5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"See https://github.com/openstack/monasca-common/tree/master/docker/README.rst"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Building Monasca notification image (child)"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_bb68b6f3","line":12,"range":{"start_line":12,"start_character":37,"end_line":12,"end_character":42},"in_reply_to":"3f79a3b5_82610214","updated":"2018-09-20 11:51:40.000000000","message":"Done","commit_id":"75baf74afad9859d5688591f0c6e238e223bb3eb"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"9f7eef5532ed847b72e8268323a10670b0d06e1f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  Please read detailed build description inside the script."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Build arguments (child)"},{"line_number":36,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":"Arguments              Occurrence"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":"BASE_TAG               Dockerfile"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Environment variables (child)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_02b0928a","line":41,"range":{"start_line":35,"start_character":1,"end_line":41,"end_character":48},"updated":"2018-09-19 07:38:45.000000000","message":"I think we can remove this part","commit_id":"75baf74afad9859d5688591f0c6e238e223bb3eb"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"852fc6bc732dedcde7e9db3af32e6665d02d93b5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  Please read detailed build description inside the script."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Build arguments (child)"},{"line_number":36,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":"Arguments              Occurrence"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":"BASE_TAG               Dockerfile"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Environment variables (child)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_9b713ae1","line":41,"range":{"start_line":35,"start_character":1,"end_line":41,"end_character":48},"in_reply_to":"3f79a3b5_02b0928a","updated":"2018-09-20 11:51:40.000000000","message":"Done","commit_id":"75baf74afad9859d5688591f0c6e238e223bb3eb"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"16b31e05f3c6ce5152923645c825087c6a8121d1","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Building Monasca notification image"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Requirements from monasca-base image"},{"line_number":17,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_02fd9d39","line":14,"updated":"2018-10-04 13:59:55.000000000","message":"We could add here something like:\n\n  Example usage:\n   $ ./build_image.sh \u003crepository_version\u003e\u003cupper_constains_branch\u003e \u003ccommon_version\u003e","commit_id":"56d81e9d78bcd744fdf18040caaab971f730d99b"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"741b13fb193c4d1df22b89a550301289c859f448","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Building Monasca notification image"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Requirements from monasca-base image"},{"line_number":17,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_2de8b0dd","line":14,"in_reply_to":"3f79a3b5_02fd9d39","updated":"2018-10-05 13:43:47.000000000","message":"Done","commit_id":"56d81e9d78bcd744fdf18040caaab971f730d99b"}],"docker/health_check.py":[{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"9f7eef5532ed847b72e8268323a10670b0d06e1f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def main():"},{"line_number":22,"context_line":"    \"\"\"health check for Monasca-notification\"\"\""},{"line_number":23,"context_line":"    #TODO wait for health check endpoint ..."},{"line_number":24,"context_line":"    return 0"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_daa6ecac","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":44},"updated":"2018-09-19 07:38:45.000000000","message":"Pleas add simple check. We should have know is service is running","commit_id":"75baf74afad9859d5688591f0c6e238e223bb3eb"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"852fc6bc732dedcde7e9db3af32e6665d02d93b5","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def main():"},{"line_number":22,"context_line":"    \"\"\"health check for Monasca-notification\"\"\""},{"line_number":23,"context_line":"    #TODO wait for health check endpoint ..."},{"line_number":24,"context_line":"    return 0"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_be042415","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":44},"in_reply_to":"3f79a3b5_daa6ecac","updated":"2018-09-20 11:51:40.000000000","message":"If service is not running then Docker will take care of that so when service is down container will also exit and management tools (like Kubernetes, Docker Swarm etc.) need to take care of it.\nThis health check is for knowing if service is operational (not if is only up).","commit_id":"75baf74afad9859d5688591f0c6e238e223bb3eb"}]}