)]}'
{"monasca_notification/conf/kafka.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"26fc20e0b3febac17d5a2cc30037fccd8f44f349","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               help\u003d\u0027Maximum lag for topic that is acceptable by \u0027"},{"line_number":64,"context_line":"                    \u0027the monasca-notification. Notifications that are older \u0027"},{"line_number":65,"context_line":"                    \u0027than this offset are skipped.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(name\u003d\u0027legacy_kafka_client_enabled\u0027, default\u003dTrue,"},{"line_number":67,"context_line":"                required\u003dTrue, advanced\u003dTrue,"},{"line_number":68,"context_line":"                help\u003d\u0027Enable legacy Kafka client\u0027)"},{"line_number":69,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_24cd5c5c","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":65},"updated":"2019-08-06 17:05:47.000000000","message":"Are there any landmines lurking when setting this to False? For example, if I am using the legacy messaging version, can I just turn this off, or should we warn people that if you turn this off, you should update the messaging version in Kafka config? Can you end up with mixtures of message formats in Kafka? Which combinations do we support? Some hints in the help message could be useful.","commit_id":"84fe1fc914400d3f0deec2de067971118ea0df89"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"9caf39962e48fd75180e93c82362821596fbe710","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               help\u003d\u0027Maximum lag for topic that is acceptable by \u0027"},{"line_number":64,"context_line":"                    \u0027the monasca-notification. Notifications that are older \u0027"},{"line_number":65,"context_line":"                    \u0027than this offset are skipped.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(name\u003d\u0027legacy_kafka_client_enabled\u0027, default\u003dTrue,"},{"line_number":67,"context_line":"                required\u003dTrue, advanced\u003dTrue,"},{"line_number":68,"context_line":"                help\u003d\u0027Enable legacy Kafka client\u0027)"},{"line_number":69,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_9a2b3d94","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":65},"in_reply_to":"7faddb67_24cd5c5c","updated":"2019-08-07 10:28:38.000000000","message":"I\u0027ve tested changing the setting and restarting the service which worked perfectly fine.\n\nI\u0027ve added information about setting message format when using old client both to the help message and release note.","commit_id":"84fe1fc914400d3f0deec2de067971118ea0df89"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"314232c2970f26381ad9599faea2ab1eb95d2264","unresolved":false,"context_lines":[{"line_number":63,"context_line":"               help\u003d\u0027Maximum lag for topic that is acceptable by \u0027"},{"line_number":64,"context_line":"                    \u0027the monasca-notification. Notifications that are older \u0027"},{"line_number":65,"context_line":"                    \u0027than this offset are skipped.\u0027),"},{"line_number":66,"context_line":"    cfg.BoolOpt(name\u003d\u0027legacy_kafka_client_enabled\u0027, default\u003dTrue,"},{"line_number":67,"context_line":"                required\u003dTrue, advanced\u003dTrue,"},{"line_number":68,"context_line":"                help\u003d\u0027Enable legacy Kafka client\u0027)"},{"line_number":69,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_63da551e","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":65},"in_reply_to":"7faddb67_9a2b3d94","updated":"2019-08-07 15:21:36.000000000","message":"thanks","commit_id":"84fe1fc914400d3f0deec2de067971118ea0df89"}],"monasca_notification/kafka/client_factory.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"26fc20e0b3febac17d5a2cc30037fccd8f44f349","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_kafka_consumer(topic, zookeeper_path):"},{"line_number":24,"context_line":"    if CONF.kafka.legacy_kafka_client_enabled:"},{"line_number":25,"context_line":"        return legacy_kafka_consumer.LegacyKafkaConsumer("},{"line_number":26,"context_line":"            CONF.kafka.url,"},{"line_number":27,"context_line":"            \u0027,\u0027.join(CONF.zookeeper.url),"},{"line_number":28,"context_line":"            zookeeper_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_1f70ad71","line":25,"updated":"2019-08-06 17:05:47.000000000","message":"Any reason you didn\u0027t go with the singleton style approach like in the persister?","commit_id":"84fe1fc914400d3f0deec2de067971118ea0df89"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"9caf39962e48fd75180e93c82362821596fbe710","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_kafka_consumer(topic, zookeeper_path):"},{"line_number":24,"context_line":"    if CONF.kafka.legacy_kafka_client_enabled:"},{"line_number":25,"context_line":"        return legacy_kafka_consumer.LegacyKafkaConsumer("},{"line_number":26,"context_line":"            CONF.kafka.url,"},{"line_number":27,"context_line":"            \u0027,\u0027.join(CONF.zookeeper.url),"},{"line_number":28,"context_line":"            zookeeper_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_8ff0dd93","line":25,"in_reply_to":"7faddb67_1f70ad71","updated":"2019-08-07 10:28:38.000000000","message":"The reason for using singleton in persister was the ConfluentKafkaPersister.flush() static method which I used as the repartition callback.\n\nI could indeed enforce single instance of Consumer per worker here as well but I\u0027m not sure if it\u0027s worth it.","commit_id":"84fe1fc914400d3f0deec2de067971118ea0df89"}],"monasca_notification/kafka/legacy_kafka_message.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"26fc20e0b3febac17d5a2cc30037fccd8f44f349","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#  under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"class LegacyKafkaMessage(object):"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def __init__(self, raw_message):"},{"line_number":17,"context_line":"        self.m_partition \u003d raw_message[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_04614005","line":14,"updated":"2019-08-06 17:05:47.000000000","message":"If this was permanent I suppose that monasca-common is the place for it given that it is shared. Since it isn\u0027t permanent, I\u0027m fine with the duplicate.","commit_id":"84fe1fc914400d3f0deec2de067971118ea0df89"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"9caf39962e48fd75180e93c82362821596fbe710","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#  under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"class LegacyKafkaMessage(object):"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def __init__(self, raw_message):"},{"line_number":17,"context_line":"        self.m_partition \u003d raw_message[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_2f10c9a8","line":14,"in_reply_to":"7faddb67_04614005","updated":"2019-08-07 10:28:38.000000000","message":"I tried adding this to _monasca-common_ first [1] but had huge problems with testing as it would change the message format passed by the library.\n\n[1] https://review.opendev.org/#/q/topic:consumer_refactor","commit_id":"84fe1fc914400d3f0deec2de067971118ea0df89"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"314232c2970f26381ad9599faea2ab1eb95d2264","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#  under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"class LegacyKafkaMessage(object):"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    def __init__(self, raw_message):"},{"line_number":17,"context_line":"        self.m_partition \u003d raw_message[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_03cb614a","line":14,"in_reply_to":"7faddb67_2f10c9a8","updated":"2019-08-07 15:21:36.000000000","message":"No problem - not worth the effort for legacy code.","commit_id":"84fe1fc914400d3f0deec2de067971118ea0df89"}],"monasca_notification/notification_engine.py":[{"author":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"change_message_id":"3e6801bdb99286075ee57de788cc292b838bb2a2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import time"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from monasca_common.kafka import client_factory"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_ebb6ecd9","line":19,"updated":"2019-09-19 11:09:45.000000000","message":"My OCD forces me to highlight that this import should be moved down.","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"273d97c2fd4d7a86b4f782231f6a869cce62cd8b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import time"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from monasca_common.kafka import client_factory"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_92ff6400","line":19,"in_reply_to":"3fa7e38b_ebb6ecd9","updated":"2019-09-19 13:47:53.000000000","message":"Done","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"}],"monasca_notification/periodic_engine.py":[{"author":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"change_message_id":"3e6801bdb99286075ee57de788cc292b838bb2a2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import time"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from monasca_common.kafka import client_factory"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_8bcbb851","line":19,"updated":"2019-09-19 11:09:45.000000000","message":"This is hitting my OCD again. :-)","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"273d97c2fd4d7a86b4f782231f6a869cce62cd8b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import time"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from monasca_common.kafka import client_factory"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_b202a008","line":19,"in_reply_to":"3fa7e38b_8bcbb851","updated":"2019-09-19 13:47:53.000000000","message":"Done","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"},{"author":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"change_message_id":"3e6801bdb99286075ee57de788cc292b838bb2a2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            CONF.kafka.group,"},{"line_number":44,"context_line":"            self._topic_name,"},{"line_number":45,"context_line":"            CONF.zookeeper.url,"},{"line_number":46,"context_line":"            zookeeper_path,"},{"line_number":47,"context_line":"            CONF.kafka.legacy_kafka_client_enabled)"},{"line_number":48,"context_line":"        self._producer \u003d client_factory.get_kafka_producer("},{"line_number":49,"context_line":"            CONF.kafka.url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_cbe690e9","line":46,"updated":"2019-09-19 11:09:45.000000000","message":"Why do not use: CONF.zookeeper.periodic_path[period]?","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"273d97c2fd4d7a86b4f782231f6a869cce62cd8b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            CONF.kafka.group,"},{"line_number":44,"context_line":"            self._topic_name,"},{"line_number":45,"context_line":"            CONF.zookeeper.url,"},{"line_number":46,"context_line":"            zookeeper_path,"},{"line_number":47,"context_line":"            CONF.kafka.legacy_kafka_client_enabled)"},{"line_number":48,"context_line":"        self._producer \u003d client_factory.get_kafka_producer("},{"line_number":49,"context_line":"            CONF.kafka.url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_5209ec29","line":46,"in_reply_to":"3fa7e38b_cbe690e9","updated":"2019-09-19 13:47:53.000000000","message":"Done","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"}],"monasca_notification/retry_engine.py":[{"author":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"change_message_id":"3e6801bdb99286075ee57de788cc292b838bb2a2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import time"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from monasca_common.kafka import client_factory"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_cbff7065","line":19,"updated":"2019-09-19 11:09:45.000000000","message":"Please forgive me but ... this line should be moved.","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"273d97c2fd4d7a86b4f782231f6a869cce62cd8b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import time"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from monasca_common.kafka import client_factory"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_720c283b","line":19,"in_reply_to":"3fa7e38b_cbff7065","updated":"2019-09-19 13:47:53.000000000","message":"Done","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"}],"releasenotes/notes/add_legacy_kafka_client_enabled_option-11fdacc063e95ae2.yaml":[{"author":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"change_message_id":"3e6801bdb99286075ee57de788cc292b838bb2a2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration option `legacy_kafka_client_enabled` added to allow working"},{"line_number":5,"context_line":"    with both legacy kafka-python and new Confluent Kafka client. Please set"},{"line_number":6,"context_line":"    message format version for the Kafka brokers to 0.9.0.0 to avoid"},{"line_number":7,"context_line":"    performance issues until all consumers are upgraded."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_cb8210c9","line":5,"updated":"2019-09-19 11:09:45.000000000","message":"I\u0027d add that setting it to true enables kafka-python, and maybe the default value.","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"273d97c2fd4d7a86b4f782231f6a869cce62cd8b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration option `legacy_kafka_client_enabled` added to allow working"},{"line_number":5,"context_line":"    with both legacy kafka-python and new Confluent Kafka client. Please set"},{"line_number":6,"context_line":"    message format version for the Kafka brokers to 0.9.0.0 to avoid"},{"line_number":7,"context_line":"    performance issues until all consumers are upgraded."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_1213745e","line":5,"in_reply_to":"3fa7e38b_cb8210c9","updated":"2019-09-19 13:47:53.000000000","message":"Done","commit_id":"b7023654fe55f16bbd8604aa907d276a502168d9"}]}