)]}'
{"monasca_persister/persister.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"612a37866066a3a048c7c7fa7c3069f6e35d3165","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        except Exception:"},{"line_number":132,"context_line":"            pass"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    # Kill everything, that didn\u0027t already die"},{"line_number":135,"context_line":"    for child in multiprocessing.active_children():"},{"line_number":136,"context_line":"        LOG.debug(\u0027Killing pid %s\u0027 % child.pid)"},{"line_number":137,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_e28b9b66","line":134,"range":{"start_line":134,"start_character":4,"end_line":134,"end_character":46},"updated":"2016-01-29 15:50:50.000000000","message":"Maybe you should sleep a second or two if you successfully called any process.terminate(). The way you have it the child processes don\u0027t really get a chance to terminate before the SIGKILL","commit_id":"2e3b8d68dede75637d0206dbd196a71bf69b8599"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"21d18d2203fb093204c4ee519369e1234763e288","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        except Exception:"},{"line_number":140,"context_line":"            pass"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    sys.exit(signum)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def start_process(database_object, database_config, kafka_config):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_34d26ed3","line":142,"updated":"2016-01-29 06:31:48.000000000","message":"Talk to Craig about the signals we should be reporting as an error.  He had some concerns about how we were dealing with a shutdown in the notification engine but I don\u0027t remember exactly what they were.","commit_id":"2e3b8d68dede75637d0206dbd196a71bf69b8599"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b48803ee7c353f288fbcb4930144e745d5fa87a4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        except Exception:"},{"line_number":140,"context_line":"            pass"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    sys.exit(signum)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def start_process(database_object, database_config, kafka_config):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_2772257c","line":142,"in_reply_to":"7a5de9d1_34d26ed3","updated":"2016-01-29 15:35:56.000000000","message":"If this is called on a normal termination, then it should return 0. If not, systemctl gets confused and thinks it failed. You can see this stopping the current monasca-notification. SIGTERM is probably used to normally stop the persister","commit_id":"2e3b8d68dede75637d0206dbd196a71bf69b8599"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"612a37866066a3a048c7c7fa7c3069f6e35d3165","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    except Exception:"},{"line_number":222,"context_line":"        LOG.exception(\u0027Error! Exiting.\u0027)"},{"line_number":223,"context_line":"        for process in processors:"},{"line_number":224,"context_line":"            process.terminate()"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":227,"context_line":"    sys.exit(main())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_c26a1f81","line":224,"range":{"start_line":224,"start_character":12,"end_line":224,"end_character":31},"updated":"2016-01-29 15:50:50.000000000","message":"Maybe you should call clean_exit here? You don\u0027t do the SIGKILL in this case","commit_id":"2e3b8d68dede75637d0206dbd196a71bf69b8599"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"738f5a1ce8971426675525720486a2a595cb796e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"             |____|    \\___  \u003e__|  /____  \u003e__/____  \u003e |__|  \\___  \u003e__|"},{"line_number":166,"context_line":"                           \\/           \\/        \\/            \\/"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        \u0027\u0027\u0027)"},{"line_number":169,"context_line":"        for process in processors:"},{"line_number":170,"context_line":"            process.start()"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_915d9917","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":12},"updated":"2016-03-23 22:04:19.000000000","message":"I love ascii art as much as the next person but can we get something we can easily grep for in a log?","commit_id":"7c77ad3e442df0b02a84db4870fea3f151cbf61f"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"5aab43343813c7e8bc7411c0883c5405e0a92676","unresolved":false,"context_lines":[{"line_number":165,"context_line":"             |____|    \\___  \u003e__|  /____  \u003e__/____  \u003e |__|  \\___  \u003e__|"},{"line_number":166,"context_line":"                           \\/           \\/        \\/            \\/"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        \u0027\u0027\u0027)"},{"line_number":169,"context_line":"        for process in processors:"},{"line_number":170,"context_line":"            process.start()"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_daa2b398","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":12},"in_reply_to":"fa0719c6_915d9917","updated":"2016-03-30 20:22:04.000000000","message":"Look in the start_process above we log there that we are starting the process and the repository","commit_id":"7c77ad3e442df0b02a84db4870fea3f151cbf61f"}]}