)]}'
{"monasca_persister/repositories/utils.py":[{"author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"change_message_id":"f27c2ef919b279eb43833183aa60a70f5c74ecbc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    value_meta \u003d metric.get(\u0027value_meta\u0027, {})"},{"line_number":36,"context_line":"    if \u0027value_meta\u0027 is None:"},{"line_number":37,"context_line":"        # Ensure value_meta is a dict"},{"line_number":38,"context_line":"        value_meta \u003d {}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    return (metric.get(\u0027dimensions\u0027, {}), metric_name, region, tenant_id,"},{"line_number":41,"context_line":"            time_stamp, value, value_meta)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_7d64dfe4","side":"PARENT","line":38,"updated":"2019-04-25 15:05:45.000000000","message":"Are you sure we want to drop this check?  If None is stored for metric[\u0027value_meta\u0027] , get would still return None.","commit_id":"e5ed3be08d3f163750a16073aaada2bba419cb1a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"51c8d83194d28dd52e9a8d2abf91ecf195487833","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    value_meta \u003d metric.get(\u0027value_meta\u0027, {})"},{"line_number":36,"context_line":"    if \u0027value_meta\u0027 is None:"},{"line_number":37,"context_line":"        # Ensure value_meta is a dict"},{"line_number":38,"context_line":"        value_meta \u003d {}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    return (metric.get(\u0027dimensions\u0027, {}), metric_name, region, tenant_id,"},{"line_number":41,"context_line":"            time_stamp, value, value_meta)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_dd906b51","side":"PARENT","line":38,"in_reply_to":"ffb9cba7_7d64dfe4","updated":"2019-04-25 15:18:53.000000000","message":"Good point, the default empty dict above doesn\u0027t prevent this being None.","commit_id":"e5ed3be08d3f163750a16073aaada2bba419cb1a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"201f4e4949ce8d229890f38a69c0f8731b95c30b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    old_state \u003d alarm_transitioned[\u0027oldState\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # Key may not exist or value may be none, convert both to \"\""},{"line_number":54,"context_line":"    link \u003d alarm_transitioned.get(\u0027link\u0027, \"\")"},{"line_number":55,"context_line":"    link \u003d \"\" if link is None else link"},{"line_number":56,"context_line":"    # Key may not exist or value may be none, convert both to \"\""},{"line_number":57,"context_line":"    lifecycle_state \u003d alarm_transitioned.get(\u0027lifecycleState\u0027, \"\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_01c1f554","line":54,"range":{"start_line":54,"start_character":41,"end_line":54,"end_character":44},"updated":"2019-04-23 11:15:08.000000000","message":"nit: Remove this, and let it get set to \"\" below to make it a little easier to read?","commit_id":"d873f2cb744ced89e312818f3b698a23b352de53"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"201f4e4949ce8d229890f38a69c0f8731b95c30b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    link \u003d alarm_transitioned.get(\u0027link\u0027, \"\")"},{"line_number":55,"context_line":"    link \u003d \"\" if link is None else link"},{"line_number":56,"context_line":"    # Key may not exist or value may be none, convert both to \"\""},{"line_number":57,"context_line":"    lifecycle_state \u003d alarm_transitioned.get(\u0027lifecycleState\u0027, \"\")"},{"line_number":58,"context_line":"    lifecycle_state \u003d \"\" if lifecycle_state is None else lifecycle_state"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    state_change_reason \u003d alarm_transitioned[\u0027stateChangeReason\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffb9cba7_01a6d5c2","line":57,"range":{"start_line":57,"start_character":61,"end_line":57,"end_character":65},"updated":"2019-04-23 11:15:08.000000000","message":"Same comment as above","commit_id":"d873f2cb744ced89e312818f3b698a23b352de53"}]}
