)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"18fe91cc0529d538da7df976eedd888ccfaab7d9","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id58703a52bff134fdbb22eaac199a4036df0c0b5"},{"line_number":13,"context_line":"Story: 2001214"},{"line_number":14,"context_line":"Task: 5723"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f515b1d_fe5753c9","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":10},"updated":"2017-09-27 15:47:08.000000000","message":"nit: the task in monasca-specs repo should be referenced. 5725","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"}],"specs/queens/approved/service-domain-for-self-service-agent-users.rst":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"5a170401aca4d20b0c00ff309b68372b37a474b7","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"::"},{"line_number":230,"context_line":"    GET /v2.0/agent_users"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"This request lists agent users. It will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_6a3793e5","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":2},"updated":"2017-10-04 13:50:46.000000000","message":"extra empty line missing","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"7eafee1fc4b3edd8e8dcbdfded621441fb443047","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"::"},{"line_number":230,"context_line":"    GET /v2.0/agent_users"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"This request lists agent users. It will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_8552a366","line":229,"range":{"start_line":229,"start_character":0,"end_line":229,"end_character":2},"in_reply_to":"7f515b1d_6a3793e5","updated":"2017-10-11 15:32:52.000000000","message":"Done","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"5a170401aca4d20b0c00ff309b68372b37a474b7","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"::"},{"line_number":241,"context_line":"    GET /v2.0/agent_users/\u003cid\u003e"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"This request retrieves the database record for an agent user. It will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_8a3f6fb4","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":2},"updated":"2017-10-04 13:50:46.000000000","message":"extra empty line missing","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"7eafee1fc4b3edd8e8dcbdfded621441fb443047","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"::"},{"line_number":241,"context_line":"    GET /v2.0/agent_users/\u003cid\u003e"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"This request retrieves the database record for an agent user. It will"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_a5559f52","line":240,"range":{"start_line":240,"start_character":0,"end_line":240,"end_character":2},"in_reply_to":"7f515b1d_8a3f6fb4","updated":"2017-10-11 15:32:52.000000000","message":"Done","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"ad4662c18e52fca259e74fb0487c8a8d55c0ecf8","unresolved":false,"context_lines":[{"line_number":255,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"::"},{"line_number":258,"context_line":"    GET /v2.0/agent_user_config/\u003cid\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"This request retrieves the database record for an agent user and generates a"},{"line_number":261,"context_line":"pasteable configuration snippet for monasca-agent\u0027s `agent.yaml` configuration"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_eb3e5ab6","line":258,"updated":"2017-09-28 09:28:45.000000000","message":"One more thing: I\u0027m not sure whether we should really do configuration rendering in the API. Maybe this is better done in the client. Thoughts?","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"7eafee1fc4b3edd8e8dcbdfded621441fb443047","unresolved":false,"context_lines":[{"line_number":255,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"::"},{"line_number":258,"context_line":"    GET /v2.0/agent_user_config/\u003cid\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"This request retrieves the database record for an agent user and generates a"},{"line_number":261,"context_line":"pasteable configuration snippet for monasca-agent\u0027s `agent.yaml` configuration"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_c5a3fb4e","line":258,"in_reply_to":"5f4e5783_5a2b77ea","updated":"2017-10-11 15:32:52.000000000","message":"Since we do not store the password now (we only return it upon creation), generating configuration is rather pointless, so I just removed that operation.","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"4984fdaa8e5bc3d928fafeece3ec125f8c38d157","unresolved":false,"context_lines":[{"line_number":255,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"::"},{"line_number":258,"context_line":"    GET /v2.0/agent_user_config/\u003cid\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"This request retrieves the database record for an agent user and generates a"},{"line_number":261,"context_line":"pasteable configuration snippet for monasca-agent\u0027s `agent.yaml` configuration"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_5a2b77ea","line":258,"in_reply_to":"7f515b1d_700e6433","updated":"2017-10-11 07:16:33.000000000","message":"I agree with Nicolas that having configuration generation in API is nice to have. Another place where this functionality would fit well is monasca-setup which generates agent configuration anyway.\n\nWe may mark it as optional and decide later. I would suggest though to use a different URL:\n\n GET /v2.0/agent_users/\u003cid\u003e/config\n\nwhich is more RESTful.","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"a2fed5a5d17f8f310d7bfd1ca1ab6834fa127fb4","unresolved":false,"context_lines":[{"line_number":255,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"::"},{"line_number":258,"context_line":"    GET /v2.0/agent_user_config/\u003cid\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"This request retrieves the database record for an agent user and generates a"},{"line_number":261,"context_line":"pasteable configuration snippet for monasca-agent\u0027s `agent.yaml` configuration"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_6d578d04","line":258,"in_reply_to":"7f515b1d_ea50230d","updated":"2017-10-11 15:34:31.000000000","message":"Magnum passes the credentials directly into its clusters via Heat parameters. Definitely not something we can do here because we do not have a similarly direct communication channel to the agents :-)","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":26702,"name":"Nicolas Seyvet","email":"nseyvet@op5.com","username":"nseyvet"},"change_message_id":"ce9658296b4a23d617cdd76c7306881ededaa594","unresolved":false,"context_lines":[{"line_number":255,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"::"},{"line_number":258,"context_line":"    GET /v2.0/agent_user_config/\u003cid\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"This request retrieves the database record for an agent user and generates a"},{"line_number":261,"context_line":"pasteable configuration snippet for monasca-agent\u0027s `agent.yaml` configuration"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_700e6433","line":258,"in_reply_to":"7f515b1d_eb3e5ab6","updated":"2017-10-04 14:43:40.000000000","message":"Conceptually it is a promising feature.  Makes self-service usable.  \n\nMy understanding when reading the spec was that it would return a reference configuration file with the generated username and password (ie proper format and values for these known attributes) and, not that Monasca would store all the configuration options associated with that particular agent which remain a responsibility of the user deploying the agent.\n\nHow much was intended to be done via this API?","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"5a170401aca4d20b0c00ff309b68372b37a474b7","unresolved":false,"context_lines":[{"line_number":255,"context_line":"* Return `401` for unauthenticated users or users without any roles."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"::"},{"line_number":258,"context_line":"    GET /v2.0/agent_user_config/\u003cid\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"This request retrieves the database record for an agent user and generates a"},{"line_number":261,"context_line":"pasteable configuration snippet for monasca-agent\u0027s `agent.yaml` configuration"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_ea50230d","line":258,"in_reply_to":"7f515b1d_eb3e5ab6","updated":"2017-10-04 13:50:46.000000000","message":"How Magnum handles that?","commit_id":"8bef1d464aea6dc7254f68015fb13e57c13e63fe"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"1ef0260505c2534d89e90ab0a4840db8c69f4903","unresolved":false,"context_lines":[{"line_number":303,"context_line":"The following requests"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"::"},{"line_number":306,"context_line":"    POST /v2.0/logs"},{"line_number":307,"context_line":"    POST /v3.0/logs"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"...will need to be extended to not only check for the roles configured in"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f4e5783_fa60e334","line":306,"range":{"start_line":306,"start_character":4,"end_line":306,"end_character":19},"updated":"2017-10-11 07:21:14.000000000","message":"Is deprecated. Might be removed from here.","commit_id":"e821579b0eaba333dfd727c503b464edb4fe5acb"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"7eafee1fc4b3edd8e8dcbdfded621441fb443047","unresolved":false,"context_lines":[{"line_number":303,"context_line":"The following requests"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"::"},{"line_number":306,"context_line":"    POST /v2.0/logs"},{"line_number":307,"context_line":"    POST /v3.0/logs"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"...will need to be extended to not only check for the roles configured in"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f4e5783_e545d771","line":306,"range":{"start_line":306,"start_character":4,"end_line":306,"end_character":19},"in_reply_to":"5f4e5783_fa60e334","updated":"2017-10-11 15:32:52.000000000","message":"Done","commit_id":"e821579b0eaba333dfd727c503b464edb4fe5acb"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"1ef0260505c2534d89e90ab0a4840db8c69f4903","unresolved":false,"context_lines":[{"line_number":368,"context_line":"Performance Impact"},{"line_number":369,"context_line":"------------------"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"N/A"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"Other deployer impact"},{"line_number":374,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f4e5783_bad70bc0","line":371,"range":{"start_line":371,"start_character":0,"end_line":371,"end_character":3},"updated":"2017-10-11 07:21:14.000000000","message":"What is the performance impact?","commit_id":"e821579b0eaba333dfd727c503b464edb4fe5acb"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"7eafee1fc4b3edd8e8dcbdfded621441fb443047","unresolved":false,"context_lines":[{"line_number":368,"context_line":"Performance Impact"},{"line_number":369,"context_line":"------------------"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"N/A"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"Other deployer impact"},{"line_number":374,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5f4e5783_c53f7bd4","line":371,"range":{"start_line":371,"start_character":0,"end_line":371,"end_character":3},"in_reply_to":"5f4e5783_bad70bc0","updated":"2017-10-11 15:32:52.000000000","message":"Shouldn\u0027t be too big. I added a little something about possible impact now.","commit_id":"e821579b0eaba333dfd727c503b464edb4fe5acb"}],"specs/queens/service-domain-for-self-service-agent-users.rst":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"18fe91cc0529d538da7df976eedd888ccfaab7d9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"In order to send metrics and logs to Monasca the Monasca agent currently needs"},{"line_number":14,"context_line":"a Keystone user with a special Keystone role, usually `monasca-agent`. This is"},{"line_number":15,"context_line":"fine for infrastructure monitoring of an OpenStack cloud where the person"},{"line_number":16,"context_line":"interested in monitoring can usually create user accounts, too and where these"},{"line_number":17,"context_line":"account\u0027s credentials are stored on the cloud\u0027s compute nodes and controllers"},{"line_number":18,"context_line":"which should be well protected against breaches. Storing such credentials on"},{"line_number":19,"context_line":"public facing instances to be monitored by Monasca is a problem because these"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_9ef73fd4","line":16,"range":{"start_line":16,"start_character":59,"end_line":16,"end_character":66},"updated":"2017-09-27 15:47:08.000000000","message":"and","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"18fe91cc0529d538da7df976eedd888ccfaab7d9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"slightly lower but still problematic security risk:"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"If a user wants to monitor their instances, they need to pass the Keystone"},{"line_number":49,"context_line":"credentials of an OpenStack user with the monasca-user role into their"},{"line_number":50,"context_line":"instances. Like any OpenStack user with any role in a project, this user can"},{"line_number":51,"context_line":"access arbitrary OpenStack APIs and create/delete resources at will. While it"},{"line_number":52,"context_line":"would be possible to add global deny rules for the `monasca-agent` role to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_9ee5ff0b","line":49,"range":{"start_line":49,"start_character":42,"end_line":49,"end_character":54},"updated":"2017-09-27 15:47:08.000000000","message":"monasca-agent","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"18fe91cc0529d538da7df976eedd888ccfaab7d9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"* `user_name` (string): the agent user\u0027s user name"},{"line_number":141,"context_line":"* `creator_id` (string): the creating user\u0027s keystone user UUID"},{"line_number":142,"context_line":"* `creator_name` (string): the creating user\u0027s keystone user name"},{"line_number":143,"context_line":"* `password` (string): the agent user\u0027s password"},{"line_number":144,"context_line":"* `project_id` (string): the project the user can submit logs metrics for"},{"line_number":145,"context_line":"* `submit_metrics` (boolean): whether the user is allowed to submit metrics"},{"line_number":146,"context_line":"* `submit_logs` (boolean): whether the user is allowed to submit logs"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_9ed97ff4","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":48},"updated":"2017-09-27 15:47:08.000000000","message":"Probably can be saved in Keystone only.","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"da301ff398eeef38ae6c5e79ad9fe6d3f2d7784b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"* `user_name` (string): the agent user\u0027s user name"},{"line_number":141,"context_line":"* `creator_id` (string): the creating user\u0027s keystone user UUID"},{"line_number":142,"context_line":"* `creator_name` (string): the creating user\u0027s keystone user name"},{"line_number":143,"context_line":"* `password` (string): the agent user\u0027s password"},{"line_number":144,"context_line":"* `project_id` (string): the project the user can submit logs metrics for"},{"line_number":145,"context_line":"* `submit_metrics` (boolean): whether the user is allowed to submit metrics"},{"line_number":146,"context_line":"* `submit_logs` (boolean): whether the user is allowed to submit logs"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_30598134","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":48},"in_reply_to":"7f515b1d_37805bbf","updated":"2017-09-28 09:21:11.000000000","message":"Password:\n\nI already had a discussion with Witek about this, and as far as I am concerned it\u0027s not necessary to persist it in the database. It would be enough to include it in the response the user receives upon a successful POST to /v2.0/agent_users. If the user misplaces the password thus received later, tough luck. They can always create a new service user in that case. I adjusted the spec accordingly now.\n\nFields:\n\nNo, they are not strictly neccessary but somewhat useful:\n\n* the *_name fields are strictly window dressing. That information can easily be looked up from Keystone so we might as well do away with it. I\u0027m definitely ok with leaving them out.\n* creator_id: this one is for auditing. It allows an operator to see who created a given agent user.\n* `id`: I didn\u0027t feel comfortable stealing Keystone\u0027s primary key, but yes, technically that would be possible and probably better than a generated primary key of our own. I\u0027ll do that for now (we can always backtrack on it later).","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":26702,"name":"Nicolas Seyvet","email":"nseyvet@op5.com","username":"nseyvet"},"change_message_id":"e0f1910465f9e566909eabbd37275cd25afb9b6f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"* `user_name` (string): the agent user\u0027s user name"},{"line_number":141,"context_line":"* `creator_id` (string): the creating user\u0027s keystone user UUID"},{"line_number":142,"context_line":"* `creator_name` (string): the creating user\u0027s keystone user name"},{"line_number":143,"context_line":"* `password` (string): the agent user\u0027s password"},{"line_number":144,"context_line":"* `project_id` (string): the project the user can submit logs metrics for"},{"line_number":145,"context_line":"* `submit_metrics` (boolean): whether the user is allowed to submit metrics"},{"line_number":146,"context_line":"* `submit_logs` (boolean): whether the user is allowed to submit logs"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_37805bbf","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":48},"in_reply_to":"7f515b1d_9ed97ff4","updated":"2017-09-28 07:18:57.000000000","message":"I was wondering the same thing about the password.\nAnd also whether all these fields are necessary: creator_name, user_name and id. When would creator_name be used? Same question for user_name?\n\nAbout id: Agent user\u0027s keystone user UUID is unique (user_id field) and can be used as the PK of the table? Or can an agent user have multiple entries?  It seems to me it should be limited to 1.","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"038705023ef08d23fcc58cf10b713cc9087c1a38","unresolved":false,"context_lines":[{"line_number":143,"context_line":"* `password` (string): the agent user\u0027s password"},{"line_number":144,"context_line":"* `project_id` (string): the project the user can submit logs metrics for"},{"line_number":145,"context_line":"* `submit_metrics` (boolean): whether the user is allowed to submit metrics"},{"line_number":146,"context_line":"* `submit_logs` (boolean): whether the user is allowed to submit logs"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For this to work, monasca-log-api will need a database client implementation"},{"line_number":149,"context_line":"and the configuration options to go with that, of course."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_bda1f048","line":146,"updated":"2017-09-27 08:35:01.000000000","message":"To be fair it could always contact monasca-api, but once again having log-api does not necessarily mean that you have metric-api somewhere.","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"da301ff398eeef38ae6c5e79ad9fe6d3f2d7784b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"* `password` (string): the agent user\u0027s password"},{"line_number":144,"context_line":"* `project_id` (string): the project the user can submit logs metrics for"},{"line_number":145,"context_line":"* `submit_metrics` (boolean): whether the user is allowed to submit metrics"},{"line_number":146,"context_line":"* `submit_logs` (boolean): whether the user is allowed to submit logs"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For this to work, monasca-log-api will need a database client implementation"},{"line_number":149,"context_line":"and the configuration options to go with that, of course."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_90d39560","line":146,"in_reply_to":"7f515b1d_37e73baf","updated":"2017-09-28 09:21:11.000000000","message":"I could turn it into a map, I suppose. I\u0027d rather not turn it into a list because that won\u0027t be self describing. Also, these two are optional and default to True if not specified\n(agent users that can submit only logs or only metrics will probably be a bit of a fringe case after all). I mentioned that in the rest API call section further down, but I suppose it could be clarified somewhat (did that now).","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"da301ff398eeef38ae6c5e79ad9fe6d3f2d7784b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"* `password` (string): the agent user\u0027s password"},{"line_number":144,"context_line":"* `project_id` (string): the project the user can submit logs metrics for"},{"line_number":145,"context_line":"* `submit_metrics` (boolean): whether the user is allowed to submit metrics"},{"line_number":146,"context_line":"* `submit_logs` (boolean): whether the user is allowed to submit logs"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For this to work, monasca-log-api will need a database client implementation"},{"line_number":149,"context_line":"and the configuration options to go with that, of course."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_b0e0d127","line":146,"in_reply_to":"7f515b1d_bda1f048","updated":"2017-09-28 09:21:11.000000000","message":"Ah, good point. And another reason to definitely have this information in a database table shared between monasca-api and monasca-log-api for that will work just as well if only one of these is present).","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":26702,"name":"Nicolas Seyvet","email":"nseyvet@op5.com","username":"nseyvet"},"change_message_id":"e0f1910465f9e566909eabbd37275cd25afb9b6f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"* `password` (string): the agent user\u0027s password"},{"line_number":144,"context_line":"* `project_id` (string): the project the user can submit logs metrics for"},{"line_number":145,"context_line":"* `submit_metrics` (boolean): whether the user is allowed to submit metrics"},{"line_number":146,"context_line":"* `submit_logs` (boolean): whether the user is allowed to submit logs"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For this to work, monasca-log-api will need a database client implementation"},{"line_number":149,"context_line":"and the configuration options to go with that, of course."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_37e73baf","line":146,"in_reply_to":"7f515b1d_bda1f048","updated":"2017-09-28 07:18:57.000000000","message":"Could submit_metrics and submit_logs be transformed into a list rather than two fields? That would simplify the REST API calls.","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"18fe91cc0529d538da7df976eedd888ccfaab7d9","unresolved":false,"context_lines":[{"line_number":145,"context_line":"* `submit_metrics` (boolean): whether the user is allowed to submit metrics"},{"line_number":146,"context_line":"* `submit_logs` (boolean): whether the user is allowed to submit logs"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For this to work, monasca-log-api will need a database client implementation"},{"line_number":149,"context_line":"and the configuration options to go with that, of course."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"REST API impact"},{"line_number":152,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_7ee243a2","line":149,"range":{"start_line":148,"start_character":0,"end_line":149,"end_character":57},"updated":"2017-09-27 15:47:08.000000000","message":"Could be implemented in monasca-common","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"da301ff398eeef38ae6c5e79ad9fe6d3f2d7784b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"* `submit_metrics` (boolean): whether the user is allowed to submit metrics"},{"line_number":146,"context_line":"* `submit_logs` (boolean): whether the user is allowed to submit logs"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"For this to work, monasca-log-api will need a database client implementation"},{"line_number":149,"context_line":"and the configuration options to go with that, of course."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"REST API impact"},{"line_number":152,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_302aa12b","line":149,"range":{"start_line":148,"start_character":0,"end_line":149,"end_character":57},"in_reply_to":"7f515b1d_7ee243a2","updated":"2017-09-28 09:21:11.000000000","message":"Good point, thanks! I amended the paragraph accordingly.","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":26702,"name":"Nicolas Seyvet","email":"nseyvet@op5.com","username":"nseyvet"},"change_message_id":"e0f1910465f9e566909eabbd37275cd25afb9b6f","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      \"submit_metrics\": { \"type\": \"int\", \"required\": false },"},{"line_number":185,"context_line":"      \"submit_logs\": { \"type\": \"int\", \"required\": false }"},{"line_number":186,"context_line":"      }"},{"line_number":187,"context_line":"    }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"The parameters behave as follows:"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_97014f09","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":5},"updated":"2017-09-28 07:18:57.000000000","message":"Any reasons not to use boolean type?\n{  \n    type: \"map\",\n    required: \"true\",\n    \"mapping\":  {\n      \"password\": { \"type\": \"int\", \"required\": false },\n      \"allowed_roles\": { \n         \"submit_metrics\": { \"type\": \"boolean\", \"required\": false },\n          \"submit_logs\": { \"type\": \"boolean\", \"required\": false }\n      }      \n}\n\nNot sure about this but thinking that maybe make the roles into a list is more flexible.","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"833f901d6f9dc6320c695d7d4b76f1162fc5d9ce","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      \"submit_metrics\": { \"type\": \"int\", \"required\": false },"},{"line_number":185,"context_line":"      \"submit_logs\": { \"type\": \"int\", \"required\": false }"},{"line_number":186,"context_line":"      }"},{"line_number":187,"context_line":"    }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"The parameters behave as follows:"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_6038d53c","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":5},"in_reply_to":"7f515b1d_309bc166","updated":"2017-10-04 13:43:17.000000000","message":"We work currently on adding events API.","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"da301ff398eeef38ae6c5e79ad9fe6d3f2d7784b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      \"submit_metrics\": { \"type\": \"int\", \"required\": false },"},{"line_number":185,"context_line":"      \"submit_logs\": { \"type\": \"int\", \"required\": false }"},{"line_number":186,"context_line":"      }"},{"line_number":187,"context_line":"    }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"The parameters behave as follows:"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_309bc166","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":5},"in_reply_to":"7f515b1d_97014f09","updated":"2017-09-28 09:21:11.000000000","message":"Sorry, pasted this from a schema template where the fields where it. They definitely need to be boolean :-)\n\nAs for a list/map: yes, that would be more flexible, but do we need that flexibility? It would only be necessary if we add additional API services to control access to in the future. Are there any such plans?","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"038705023ef08d23fcc58cf10b713cc9087c1a38","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This request will"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"* Return `200` with a JSON formatted database record for the agent user in the"},{"line_number":206,"context_line":"  body if the request is successful."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Return `500` with an error message in the body if user creation fails."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_bd6fb0fa","line":205,"updated":"2017-09-27 08:35:01.000000000","message":"If I understand this spec correctly, the agent will store the password locally somehow and use it for further submissions ?","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":12542,"name":"Johannes Grassler","email":"jgr-launchpad@btw23.de","username":"jgrassler"},"change_message_id":"da301ff398eeef38ae6c5e79ad9fe6d3f2d7784b","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This request will"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"* Return `200` with a JSON formatted database record for the agent user in the"},{"line_number":206,"context_line":"  body if the request is successful."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Return `500` with an error message in the body if user creation fails."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_90def50e","line":205,"in_reply_to":"7f515b1d_9a161649","updated":"2017-09-28 09:21:11.000000000","message":"That is correct, yes. Essentially the users uses monasca-api as a proxy for creating a special purpose agent user to use in their monasca agents.","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"},{"author":{"_account_id":26702,"name":"Nicolas Seyvet","email":"nseyvet@op5.com","username":"nseyvet"},"change_message_id":"e0f1910465f9e566909eabbd37275cd25afb9b6f","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"This request will"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"* Return `200` with a JSON formatted database record for the agent user in the"},{"line_number":206,"context_line":"  body if the request is successful."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"* Return `500` with an error message in the body if user creation fails."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_9a161649","line":205,"in_reply_to":"7f515b1d_bd6fb0fa","updated":"2017-09-28 07:18:57.000000000","message":"Form discussion on Wednesday, I understood, it s the user that retrieves the password who is responsible for injecting the password in the agent(s).","commit_id":"4a053153b27f5b8bbbdd125e94e49715e715f3db"}]}
