)]}'
{"monascastatsd/common.py":[{"author":{"_account_id":14123,"name":"Stefano Canepa","email":"sc@linux.it","username":"sc"},"change_message_id":"66a830a86e17bdd1f860814592c8f2c7e2dc07a9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":21,"context_line":"#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":22,"context_line":"#   See the License for the specific language governing permissions and"},{"line_number":23,"context_line":"#   limitations under the License."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def update_dimensions(dimensions_base, dimensions):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_9348832f","line":23,"range":{"start_line":23,"start_character":1,"end_line":23,"end_character":4},"updated":"2016-08-19 21:10:31.000000000","message":"You entered license header twice ;-) Please specify who is licensing this code. Changes are small so would be the same as rest of the project IMHO.","commit_id":"cddabc29fb683411933baf461cadaf9ba0354681"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"f1ba5f3987550e6e943194f3190cae021a58b561","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":21,"context_line":"#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":22,"context_line":"#   See the License for the specific language governing permissions and"},{"line_number":23,"context_line":"#   limitations under the License."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def update_dimensions(dimensions_base, dimensions):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_251b3774","line":23,"range":{"start_line":23,"start_character":1,"end_line":23,"end_character":4},"in_reply_to":"1ac06dbe_9348832f","updated":"2016-08-20 12:43:52.000000000","message":"oops, I don\u0027t know how it got duplicated. :) Thanks.","commit_id":"cddabc29fb683411933baf461cadaf9ba0354681"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"d12fb7b37e4fc01e3a669472ef438e62fd30a246","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"#   you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"#   You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_012e3dfa","line":1,"updated":"2016-08-24 05:25:29.000000000","message":"No company copyright, similar to what HP/Fujitsu is doing ?","commit_id":"d77bdb2b218a8cd93281b810e09c8b7414bf10c9"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"50a53b1c3ac0b6a3dc0787a16a6f5dc834e2585c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"#   you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"#   You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_bc1aecc3","line":1,"in_reply_to":"1ac06dbe_012e3dfa","updated":"2016-08-24 06:07:52.000000000","message":"We don\u0027t yet have a policy for that at the company. So most of our contributors leave it like this.","commit_id":"d77bdb2b218a8cd93281b810e09c8b7414bf10c9"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f162d1994607c71ad47641e50773823ceebe3a47","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"#   you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"#   You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_579e3307","line":1,"in_reply_to":"1ac06dbe_bc1aecc3","updated":"2016-08-24 06:46:55.000000000","message":"Ok, I think that\u0027s ok if that\u0027s the case.","commit_id":"d77bdb2b218a8cd93281b810e09c8b7414bf10c9"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f162d1994607c71ad47641e50773823ceebe3a47","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def update_dimensions(dimensions_base, dimensions):"},{"line_number":15,"context_line":"    new_dimensions \u003d (dimensions_base or {}).copy()"},{"line_number":16,"context_line":"    new_dimensions.update(dimensions or {})"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_b217b543","line":14,"updated":"2016-08-24 06:46:55.000000000","message":"Why not:\n\n def update_dimensions(dimensions_base\u003dNone, dimensions\u003dNone):\n  # code here\n\nI think that\u0027s rather annoying issue in entire monasca-statsd that you are forced to specify arguments even if you don\u0027t need that. That;s not the problem with your code, I think, but overall problem in the statsd IMHO.\n\nI would propose to go with the function definition above.","commit_id":"d77bdb2b218a8cd93281b810e09c8b7414bf10c9"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"905565607aa071a1997792e04237be0efb4de6e0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   limitations under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def update_dimensions(dimensions_base, dimensions):"},{"line_number":15,"context_line":"    new_dimensions \u003d (dimensions_base or {}).copy()"},{"line_number":16,"context_line":"    new_dimensions.update(dimensions or {})"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_0d9e6cb8","line":14,"in_reply_to":"1ac06dbe_b217b543","updated":"2016-08-24 07:19:24.000000000","message":"Thanks. I\u0027ll change it.","commit_id":"d77bdb2b218a8cd93281b810e09c8b7414bf10c9"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f162d1994607c71ad47641e50773823ceebe3a47","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    return new_dimensions"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def update_name(name_base, extension):"},{"line_number":22,"context_line":"    if name_base:"},{"line_number":23,"context_line":"        return _extend_name_base(name_base, extension)"},{"line_number":24,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_1277a9a0","line":21,"updated":"2016-08-24 06:46:55.000000000","message":"Same as above.\n\n+ That\u0027s kind of confusing I would expect that I return do extension if that\u0027s passed, however here it seems reversed.\nMaybe that\u0027s only about names you used for variables.","commit_id":"d77bdb2b218a8cd93281b810e09c8b7414bf10c9"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"905565607aa071a1997792e04237be0efb4de6e0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    return new_dimensions"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def update_name(name_base, extension):"},{"line_number":22,"context_line":"    if name_base:"},{"line_number":23,"context_line":"        return _extend_name_base(name_base, extension)"},{"line_number":24,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_cd757432","line":21,"in_reply_to":"1ac06dbe_1277a9a0","updated":"2016-08-24 07:19:24.000000000","message":"Maybe it\u0027s the naming. I think postfix may be a better name.","commit_id":"d77bdb2b218a8cd93281b810e09c8b7414bf10c9"}]}