)]}'
{"monasca_tempest_tests/tests/api/test_alarm_transitions.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"8e066b4c49a556bfc93e07b9ec76770cc0d63430","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self._send_measurement(metric_def, 1)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        alarm_id, initial_state \u003d self._wait_for_alarm_creation(definition_id)"},{"line_number":208,"context_line":"        self.assertEqual(\"UNDETERMINED\", initial_state)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        self._send_measurement(metric_def, 20)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8855c7c4","line":207,"updated":"2018-06-08 14:25:35.000000000","message":"Since you added this, I think you want to change the _wait_for_alarm_creation() call at line 212 to be _wait_for_alarm_transition(). The alarm will definitely have been created by 212 and while the transition should be very fast, it is not instantaneous. By giving it a little time to transition, you will avoid false failures of the test.","commit_id":"322b89599a557a798ef863916c1f21056530fd1e"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"1ce568010e54d10e9f4cb61956f4fc6f1d03d00e","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        self._send_measurement(metric_def, 1)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        alarm_id, initial_state \u003d self._wait_for_alarm_creation(definition_id)"},{"line_number":208,"context_line":"        self.assertEqual(\"UNDETERMINED\", initial_state)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        self._send_measurement(metric_def, 20)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2bbed264","line":207,"in_reply_to":"5f7c97a3_8855c7c4","updated":"2018-06-11 08:05:54.000000000","message":"Good catch. Thank you Craig!","commit_id":"322b89599a557a798ef863916c1f21056530fd1e"}]}