)]}'
{"monasca-tempest-plugin":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bfdaf3ff_f491e59a","updated":"2019-01-15 14:04:11.000000000","message":"remove","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"}],"monasca_tempest_tests/clients/event_api.py":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 FUJITSU LIMITED"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_d4ece12a","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"updated":"2019-01-15 14:04:11.000000000","message":"8 or 9","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 FUJITSU LIMITED"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_3751d7d9","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"in_reply_to":"bfdaf3ff_d4ece12a","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"}],"monasca_tempest_tests/services/events_api_client.py":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 FUJITSU LIMITED"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_f4e6c544","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"updated":"2019-01-15 14:04:11.000000000","message":"9?","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 FUJITSU LIMITED"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_f764afbb","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"in_reply_to":"bfdaf3ff_f4e6c544","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"}],"monasca_tempest_tests/tests/event_api/base.py":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 FUJITSU LIMITED"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_9444191d","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"updated":"2019-01-15 14:04:11.000000000","message":"8 or 9","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 FUJITSU LIMITED"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_b75e27e4","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"in_reply_to":"bfdaf3ff_9444191d","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from datetime import datetime"},{"line_number":16,"context_line":"from os import path"},{"line_number":17,"context_line":"import pytz"},{"line_number":18,"context_line":"import random"},{"line_number":19,"context_line":"import string"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from tempest.common import credentials_factory as cred_factory"},{"line_number":24,"context_line":"from tempest import test"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_145029d4","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":11},"updated":"2019-01-15 14:04:11.000000000","message":"why this imports are separate?","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from datetime import datetime"},{"line_number":16,"context_line":"from os import path"},{"line_number":17,"context_line":"import pytz"},{"line_number":18,"context_line":"import random"},{"line_number":19,"context_line":"import string"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import json"},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from tempest.common import credentials_factory as cred_factory"},{"line_number":24,"context_line":"from tempest import test"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_57733b81","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":11},"in_reply_to":"bfdaf3ff_145029d4","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@staticmethod"},{"line_number":32,"context_line":"def get_simple_event():"},{"line_number":33,"context_line":"    json_file_path \u003d path.join(path.dirname(__file__),"},{"line_number":34,"context_line":"                               \u0027req_simple_event.json\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_b4059dc4","line":31,"range":{"start_line":31,"start_character":1,"end_line":31,"end_character":13},"updated":"2019-01-15 14:04:11.000000000","message":"remove","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@staticmethod"},{"line_number":32,"context_line":"def get_simple_event():"},{"line_number":33,"context_line":"    json_file_path \u003d path.join(path.dirname(__file__),"},{"line_number":34,"context_line":"                               \u0027req_simple_event.json\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_7770bf73","line":31,"range":{"start_line":31,"start_character":1,"end_line":31,"end_character":13},"in_reply_to":"bfdaf3ff_b4059dc4","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        return json.loads(f.read())"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def get_header(header\u003d{}, content_type\u003d\u0027application/json\u0027):"},{"line_number":40,"context_line":"    header.update({\u0027Content-Type\u0027: content_type,"},{"line_number":41,"context_line":"                   \u0027kbn-version\u0027: CONF.monitoring.kibana_version})"},{"line_number":42,"context_line":"    return header"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_d4a4e1bb","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":14},"updated":"2019-01-15 14:04:11.000000000","message":"update_header","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        return json.loads(f.read())"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def get_header(header\u003d{}, content_type\u003d\u0027application/json\u0027):"},{"line_number":40,"context_line":"    header.update({\u0027Content-Type\u0027: content_type,"},{"line_number":41,"context_line":"                   \u0027kbn-version\u0027: CONF.monitoring.kibana_version})"},{"line_number":42,"context_line":"    return header"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_176db397","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":14},"in_reply_to":"bfdaf3ff_d4a4e1bb","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def generate_simple_event_type_string():"},{"line_number":46,"context_line":"    letters \u003d string.ascii_lowercase"},{"line_number":47,"context_line":"    return \u0027\u0027.join((random.choice(letters) for _ in range(15)))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_149a696d","line":46,"range":{"start_line":46,"start_character":14,"end_line":46,"end_character":36},"updated":"2019-01-15 14:04:11.000000000","message":"Should we also test for spaces or other special characters?","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def generate_simple_event_type_string():"},{"line_number":46,"context_line":"    letters \u003d string.ascii_lowercase"},{"line_number":47,"context_line":"    return \u0027\u0027.join((random.choice(letters) for _ in range(15)))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_d78e4b26","line":46,"range":{"start_line":46,"start_character":14,"end_line":46,"end_character":36},"in_reply_to":"bfdaf3ff_149a696d","updated":"2019-01-22 09:37:26.000000000","message":"Normal event_type dose not contain special characters(only .).","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":50,"context_line":"def generate_simple_event(event_type\u003dNone, timestamp\u003dNone, events\u003dNone, num_of_events\u003d1):"},{"line_number":51,"context_line":"    if event_type is None:"},{"line_number":52,"context_line":"        event_type \u003d generate_simple_event_type_string()"},{"line_number":53,"context_line":"    if timestamp is None:"},{"line_number":54,"context_line":"        timestamp \u003d datetime.now(tz\u003dpytz.utc).strftime(\"%Y-%m-%dT%H:%M:%SZ%z\")"},{"line_number":55,"context_line":"    if events is None:"},{"line_number":56,"context_line":"        events \u003d\\"},{"line_number":57,"context_line":"            [{"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_7499756c","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":78},"updated":"2019-01-15 14:04:11.000000000","message":"move this to line before using `timestamp` variable","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":50,"context_line":"def generate_simple_event(event_type\u003dNone, timestamp\u003dNone, events\u003dNone, num_of_events\u003d1):"},{"line_number":51,"context_line":"    if event_type is None:"},{"line_number":52,"context_line":"        event_type \u003d generate_simple_event_type_string()"},{"line_number":53,"context_line":"    if timestamp is None:"},{"line_number":54,"context_line":"        timestamp \u003d datetime.now(tz\u003dpytz.utc).strftime(\"%Y-%m-%dT%H:%M:%SZ%z\")"},{"line_number":55,"context_line":"    if events is None:"},{"line_number":56,"context_line":"        events \u003d\\"},{"line_number":57,"context_line":"            [{"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_97dc4347","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":78},"in_reply_to":"bfdaf3ff_7499756c","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                        \u0027nova_object.data\u0027: {"},{"line_number":67,"context_line":"                            \u0027architecture\u0027: \u0027x86_64\u0027,"},{"line_number":68,"context_line":"                            \u0027availability_zone\u0027: \u0027nova\u0027,"},{"line_number":69,"context_line":"                            \u0027created_at\u0027: \u00272012-10-29T13:42:11Z\u0027}}}}] * num_of_events"},{"line_number":70,"context_line":"    simple_event \u003d {\u0027timestamp\u0027: timestamp,"},{"line_number":71,"context_line":"                    \u0027events\u0027: events}"},{"line_number":72,"context_line":"    return simple_event"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_347e8d19","line":69,"range":{"start_line":69,"start_character":68,"end_line":69,"end_character":85},"updated":"2019-01-15 14:04:11.000000000","message":"move it to next line to make it more visible","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                        \u0027nova_object.data\u0027: {"},{"line_number":67,"context_line":"                            \u0027architecture\u0027: \u0027x86_64\u0027,"},{"line_number":68,"context_line":"                            \u0027availability_zone\u0027: \u0027nova\u0027,"},{"line_number":69,"context_line":"                            \u0027created_at\u0027: \u00272012-10-29T13:42:11Z\u0027}}}}] * num_of_events"},{"line_number":70,"context_line":"    simple_event \u003d {\u0027timestamp\u0027: timestamp,"},{"line_number":71,"context_line":"                    \u0027events\u0027: events}"},{"line_number":72,"context_line":"    return simple_event"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_b7e14701","line":69,"range":{"start_line":69,"start_character":68,"end_line":69,"end_character":85},"in_reply_to":"bfdaf3ff_347e8d19","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                            \u0027architecture\u0027: \u0027x86_64\u0027,"},{"line_number":68,"context_line":"                            \u0027availability_zone\u0027: \u0027nova\u0027,"},{"line_number":69,"context_line":"                            \u0027created_at\u0027: \u00272012-10-29T13:42:11Z\u0027}}}}] * num_of_events"},{"line_number":70,"context_line":"    simple_event \u003d {\u0027timestamp\u0027: timestamp,"},{"line_number":71,"context_line":"                    \u0027events\u0027: events}"},{"line_number":72,"context_line":"    return simple_event"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_f4ac858d","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":19},"updated":"2019-01-15 14:04:11.000000000","message":"can\u0027t you simply return it here instead of creating another variable?","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                            \u0027architecture\u0027: \u0027x86_64\u0027,"},{"line_number":68,"context_line":"                            \u0027availability_zone\u0027: \u0027nova\u0027,"},{"line_number":69,"context_line":"                            \u0027created_at\u0027: \u00272012-10-29T13:42:11Z\u0027}}}}] * num_of_events"},{"line_number":70,"context_line":"    simple_event \u003d {\u0027timestamp\u0027: timestamp,"},{"line_number":71,"context_line":"                    \u0027events\u0027: events}"},{"line_number":72,"context_line":"    return simple_event"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_57cb3b52","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":19},"in_reply_to":"bfdaf3ff_f4ac858d","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"0f6318b3fd5f1a7e25f4807b4d64458c0505bda8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    if event_type is None:"},{"line_number":52,"context_line":"        event_type \u003d generate_simple_event_type_string()"},{"line_number":53,"context_line":"    if events is None:"},{"line_number":54,"context_line":"        events \u003d\\"},{"line_number":55,"context_line":"            [{"},{"line_number":56,"context_line":"                \u0027dimensions\u0027: {"},{"line_number":57,"context_line":"                    \u0027service\u0027: \u0027compute\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9fdfeff1_cd100eaf","line":54,"updated":"2019-03-04 12:45:10.000000000","message":"Add space","commit_id":"b9844f90c304cdcbd6171d20378e9190b32d1a07"}],"monasca_tempest_tests/tests/event_api/test_simple.py":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 FUJITSU LIMITED"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_14c1092f","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"updated":"2019-01-15 14:04:11.000000000","message":"8 or 9","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 FUJITSU LIMITED"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_77e3df06","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"in_reply_to":"bfdaf3ff_14c1092f","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class BaseEventsTestCase(base.BaseEventsTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def check_if_events_is_present_in_db(self, event_type):"},{"line_number":28,"context_line":"        return len(self.events_search_client.search_event_by_event_type(event_type)) \u003e 0"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def send_and_retrieve_events(self, events\u003dNone, header\u003dNone, events_number\u003d1):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_34d1adfc","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":26},"updated":"2019-01-15 14:04:11.000000000","message":"are","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class BaseEventsTestCase(base.BaseEventsTestCase):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def check_if_events_is_present_in_db(self, event_type):"},{"line_number":28,"context_line":"        return len(self.events_search_client.search_event_by_event_type(event_type)) \u003e 0"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def send_and_retrieve_events(self, events\u003dNone, header\u003dNone, events_number\u003d1):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_17f053c9","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":26},"in_reply_to":"bfdaf3ff_34d1adfc","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            events \u003d base.generate_simple_event(event_type, num_of_events\u003devents_number)"},{"line_number":34,"context_line":"        if header is None:"},{"line_number":35,"context_line":"            header \u003d base.get_header()"},{"line_number":36,"context_line":"        response,  _ \u003d self.events_api_client.send_events(events, header)"},{"line_number":37,"context_line":"        self.assertEqual(200, response.status)"},{"line_number":38,"context_line":"        test_utils.call_until_true(self.check_if_events_is_present_in_db,"},{"line_number":39,"context_line":"                                   RETRY_COUNT * RETRY_WAIT,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_f4f3259d","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":19},"updated":"2019-01-15 14:04:11.000000000","message":"too man spaces","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            events \u003d base.generate_simple_event(event_type, num_of_events\u003devents_number)"},{"line_number":34,"context_line":"        if header is None:"},{"line_number":35,"context_line":"            header \u003d base.get_header()"},{"line_number":36,"context_line":"        response,  _ \u003d self.events_api_client.send_events(events, header)"},{"line_number":37,"context_line":"        self.assertEqual(200, response.status)"},{"line_number":38,"context_line":"        test_utils.call_until_true(self.check_if_events_is_present_in_db,"},{"line_number":39,"context_line":"                                   RETRY_COUNT * RETRY_WAIT,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_37ed57ef","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":19},"in_reply_to":"bfdaf3ff_f4f3259d","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"a0068f455a3819204c29dc70e80489b9f971ce56","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @decorators.attr(type\u003d\u0027gate\u0027)"},{"line_number":51,"context_line":"    def test_multiple_events(self):"},{"line_number":52,"context_line":"        self.send_and_retrieve_events(events_number\u003d2)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @decorators.attr(type\u003d\u0027gate\u0027)"},{"line_number":55,"context_line":"    def test_missing_body(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bfdaf3ff_7435f545","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":53},"updated":"2019-01-15 14:04:11.000000000","message":"I would increase it to 5 or 10","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"7c62fc1ce4595dc982aad828fa4e581553bf4728","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @decorators.attr(type\u003d\u0027gate\u0027)"},{"line_number":51,"context_line":"    def test_multiple_events(self):"},{"line_number":52,"context_line":"        self.send_and_retrieve_events(events_number\u003d2)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @decorators.attr(type\u003d\u0027gate\u0027)"},{"line_number":55,"context_line":"    def test_missing_body(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_f7c02f53","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":53},"in_reply_to":"bfdaf3ff_7435f545","updated":"2019-01-22 09:37:26.000000000","message":"Done","commit_id":"b312e4f01e6e053a8edf0567bdadedb5a5c638d5"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"2472185b20e041a4cc1b998feb122ae6500af799","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.assertEqual(events_number, len(response))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.attr(type\u003d\u0027gate\u0027)"},{"line_number":47,"context_line":"    def test_single_event(self):"},{"line_number":48,"context_line":"        self.send_and_retrieve_events()"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9fdfeff1_aaf3d109","line":46,"updated":"2019-01-25 16:24:08.000000000","message":"Can you mark at least one test (preferable this one) as \u0027smoke\u0027 test, too? Like:\n\n@decorators.attr(type\u003d[\"gate\", \"smoke\"])","commit_id":"ddd5fff362099cf327428c37a1e77f001cd76546"},{"author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"change_message_id":"cc0b4547a70c2c1d9c5046370c3f3de37573b467","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.assertEqual(events_number, len(response))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @decorators.attr(type\u003d\u0027gate\u0027)"},{"line_number":47,"context_line":"    def test_single_event(self):"},{"line_number":48,"context_line":"        self.send_and_retrieve_events()"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9fdfeff1_6d9322a5","line":46,"in_reply_to":"9fdfeff1_aaf3d109","updated":"2019-02-05 14:07:32.000000000","message":"Done","commit_id":"ddd5fff362099cf327428c37a1e77f001cd76546"}]}