)]}'
{"monasca_tempest_tests/tests/api/test_dimensions.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e789c989b5b3a99fae0555043ba71d23aa791a45","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":122,"context_line":"        self.assertTrue({\u0027links\u0027, \u0027elements\u0027} \u003d\u003d set(response_body))"},{"line_number":123,"context_line":"        response_values_length \u003d len(response_body[\u0027elements\u0027])"},{"line_number":124,"context_line":"        values \u003d [str(response_body[\u0027elements\u0027][i][\u0027dimension_value\u0027])"},{"line_number":125,"context_line":"                  for i in range(response_values_length)]"},{"line_number":126,"context_line":"        self.assertEqual(values, self._dim_values_for_metric1)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_c27b7f78","line":124,"updated":"2019-07-12 16:03:44.000000000","message":"Similar comments to the unit tests on the API change. Please can we keep the old tests to ensure that we test the original behaviour, and add new tests for the time scoping. Ideally in the new tests, we should check that this actually works. Do we need to change  `helpers.create_metric` so that it can create some old metrics or something?\n\nIt will be nice to test the case of when just the start time, or just the end time are specified too.","commit_id":"0eadf090a70b2123a7d578cea93cba5a151dd7d0"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"cd103ec38995aa35f3e349d97a41bc5bfed99434","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(TestDimensions, cls).resource_setup()"},{"line_number":34,"context_line":"        start_timestamp \u003d int(round(time.time() * 1000))"},{"line_number":35,"context_line":"        start_time_iso \u003d helpers.timestamp_to_iso(start_timestamp)"},{"line_number":36,"context_line":"        # NOTE (brtknr): use interval of a day because the tag based queries"},{"line_number":37,"context_line":"        # appear to only support smallest granularity of a day, and disregard"},{"line_number":38,"context_line":"        # time of day, which is fine for most use cases."},{"line_number":39,"context_line":"        day \u003d 60 * 60 * 24 * 1000"},{"line_number":40,"context_line":"        end_timestamp \u003d start_timestamp + 10 * day"},{"line_number":41,"context_line":"        end_time_iso \u003d helpers.timestamp_to_iso(end_timestamp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_f57f9fa8","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":56},"updated":"2019-07-25 15:07:40.000000000","message":"Please could we confirm that this is an intended feature via the InfluxDB mailing list? I\u0027m worried about relying on something which might suddenly stop working in the next release.\n\nIt would also be nice to ask if there is a better way of doing this. 1 day granularity is livable, but for someone using the API, or Grafana, it could be confusing to have hostnames returned from outside the query interval.","commit_id":"ba50eb3f81914afc6461403785f86c7e18dd1458"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"61ec00d402229617fc8a30085cd58fc3f859af64","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        cls._end_time \u003d end_time_iso"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        backend \u003d os.environ.get(\u0027MONASCA_METRICS_DB\u0027, None)"},{"line_number":102,"context_line":"        cls._supports_timerange \u003d (backend \u003d\u003d \u0027influxdb\u0027) if backend else True"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        param \u003d \u0027?start_time\u003d\u0027 + start_time_iso"},{"line_number":105,"context_line":"        returned_name_set \u003d set()"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_631c316a","line":102,"range":{"start_line":102,"start_character":34,"end_line":102,"end_character":57},"updated":"2019-07-29 09:47:01.000000000","message":"Instead I\u0027d rather make use of Test Attributes [1] and mark all the tests which require functionality only available in InfluxDB. Then these tests can be disabled with regex in the job configuration [2].\n\n[1] https://docs.openstack.org/tempest/latest/HACKING.html#test-attributes\n[2] https://opendev.org/openstack/monasca-api/src/branch/master/.zuul.yaml#L47\n\nAlternatively we could let Cassandra driver throw NotImplemented exception when query parameters are set, but I\u0027m not sure if that\u0027s what we want.","commit_id":"b2df3ed62a161717be6fc7c589e0cbf5522766f3"},{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"94eab95d9abe4d7dbddf67c52369a4079882da7e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        cls._end_time \u003d end_time_iso"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        backend \u003d os.environ.get(\u0027MONASCA_METRICS_DB\u0027, None)"},{"line_number":102,"context_line":"        cls._supports_timerange \u003d (backend \u003d\u003d \u0027influxdb\u0027) if backend else True"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        param \u003d \u0027?start_time\u003d\u0027 + start_time_iso"},{"line_number":105,"context_line":"        returned_name_set \u003d set()"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_632191fb","line":102,"range":{"start_line":102,"start_character":34,"end_line":102,"end_character":57},"in_reply_to":"7faddb67_631c316a","updated":"2019-07-29 10:30:04.000000000","message":"I dont think we want Cassandra to throw NotImplemented exception as that would break backward compatibility. I have implemented the attribute filter... lets see if the tests pass...","commit_id":"b2df3ed62a161717be6fc7c589e0cbf5522766f3"}]}