)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3a49972684091502b504d3a3ae7ff6e202b25503","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael James Hoppal \u003cmichael.jam.hoppal@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-02-19 16:44:57 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changing state change reason and adding functionality to pass values of each subalarm when transition occurs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ifeb8fa8e203adfab8ec84ec3aad13835dc2c62ea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba7be1f8_55aa1971","line":7,"updated":"2015-02-20 15:44:57.000000000","message":"The first line is too long. Guidelines say 50 characters or less. Jenkins won\u0027t fail it on this repo but it will on the others","commit_id":"d1a17a4e1e8bb7d9fdcfc04263c11c49e8df90a5"}],"thresh/src/main/java/monasca/thresh/domain/model/Alarm.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3a49972684091502b504d3a3ae7ff6e202b25503","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        stringBuilder.append(alarmTransitionSubAlarm.subAlarmExpression);"},{"line_number":71,"context_line":"        if (!AlarmState.UNDETERMINED.equals(alarmState))"},{"line_number":72,"context_line":"          stringBuilder.append(\" with the values: \").append(alarmTransitionSubAlarm.currentValues);"},{"line_number":73,"context_line":"      } "},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"    if (AlarmState.UNDETERMINED.equals(alarmState)) {"},{"line_number":76,"context_line":"      return String.format(\"No data was present for the sub-alarms: %s\", stringBuilder.toString());"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_d0f8d7e7","line":73,"updated":"2015-02-20 15:44:57.000000000","message":"trailing whitespace","commit_id":"d1a17a4e1e8bb7d9fdcfc04263c11c49e8df90a5"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3a49972684091502b504d3a3ae7ff6e202b25503","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  public boolean evaluate(AlarmExpression expression) {"},{"line_number":131,"context_line":"    transitionSubAlarms.clear();"},{"line_number":132,"context_line":"    AlarmState initialState \u003d state;"},{"line_number":133,"context_line":"    boolean unitialized \u003d false;"},{"line_number":134,"context_line":"      "},{"line_number":135,"context_line":"    for (SubAlarm subAlarm : subAlarms.values()) {"},{"line_number":136,"context_line":"      if (AlarmState.UNDETERMINED.equals(subAlarm.getState())) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_d517e94f","line":133,"updated":"2015-02-20 15:44:57.000000000","message":"I\u0027m fine with you changing this to a boolean as it is more clear but then you might as well rename to something spelled right","commit_id":"d1a17a4e1e8bb7d9fdcfc04263c11c49e8df90a5"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3a49972684091502b504d3a3ae7ff6e202b25503","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    transitionSubAlarms.clear();"},{"line_number":132,"context_line":"    AlarmState initialState \u003d state;"},{"line_number":133,"context_line":"    boolean unitialized \u003d false;"},{"line_number":134,"context_line":"      "},{"line_number":135,"context_line":"    for (SubAlarm subAlarm : subAlarms.values()) {"},{"line_number":136,"context_line":"      if (AlarmState.UNDETERMINED.equals(subAlarm.getState())) {"},{"line_number":137,"context_line":"        unitialized \u003d true;"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_15d8a1ee","line":134,"updated":"2015-02-20 15:44:57.000000000","message":"Trailing whitespace","commit_id":"d1a17a4e1e8bb7d9fdcfc04263c11c49e8df90a5"}],"thresh/src/main/java/monasca/thresh/domain/model/SubAlarmStats.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3a49972684091502b504d3a3ae7ff6e202b25503","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    double[] values \u003d stats.getViewValues();"},{"line_number":123,"context_line":"    boolean thresholdExceeded \u003d false;"},{"line_number":124,"context_line":"    boolean hasEmptyWindows \u003d false;"},{"line_number":125,"context_line":"    subAlarm.getCurrentValues().clear();"},{"line_number":126,"context_line":"    for (double value : values) {"},{"line_number":127,"context_line":"      if (Double.isNaN(value)) {"},{"line_number":128,"context_line":"        hasEmptyWindows \u003d true;"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_b0e8c37d","line":125,"updated":"2015-02-20 15:44:57.000000000","message":"In general this type of call is not recommended. You don\u0027t know if the method is returning the actual List or a copy of it. We do know in this case because SubAlarm is one of our classes, but it is better to get in the habit of the better pattern where there is a clearCurrentValues() and addCurrentValue() on SubAlarm","commit_id":"d1a17a4e1e8bb7d9fdcfc04263c11c49e8df90a5"}]}
